Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp575520pxb; Thu, 9 Sep 2021 07:26:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQbSPtO/hXyDqjlgxM9cWZP1umGPe2x41Zz1/TMmzqElCZPX7qpdlKsezhr27K6BJ5OmVQ X-Received: by 2002:a17:906:c25a:: with SMTP id bl26mr3741447ejb.345.1631197602757; Thu, 09 Sep 2021 07:26:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631197602; cv=none; d=google.com; s=arc-20160816; b=LC/WS1wgC1zNvGtf3XQiucHm0XNm/PnXZ/TfQ6C2zXl5Z3tpTCPnD64LaiOjiRZjeW 4JgP0fHi+gyui+VoChTpsuQXA6kuyD+nd2RIZIULuaAIeW7OFcB5QlFFptT4vcu8fElv 5gmEEveKXKjrBuwJfq2Y3ts4vQYXLQRGO61sA8S6F2qMmdKFyu3NHvMDIeqy/aXAWvY9 iMVY3EG25sSTMyx8ifZjuOiQPhh7zYiEPD7F9mpeJz/oHZbMTdqdqmlfJRXTEN9bsM6L kivuff37Hn1XA0GUQoCrWqCc7yXSr+9Ur9ssGuinGs+7ew2SfTRF6klGGyJPLpYgOwPD dw0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yaXPdkw/Y9GdnRrZu+T/3Q1JexcjWMNdLrpPjZG0BhA=; b=VspG9Qs35zMvDMDhr9p6ib7CkQlF5pYUdLX0D8glciLKyMqaQfTDKsjWaYZa5MqIor eT8MT/3xaV/rundSrTlEOZ2cLhXGhj77DrvrKDiRf8AWJckQL7ZMPVJePWvTqQVFdSFj Oi38hLC0rNBcM9jYrSUinliVymfx3UFDpkzEEzZfCuSk1olyOGNA7Xt8V0klWGo38xH0 Ik6u2ETSuQISV6ZfR0u4+kjl42PC9DA93AT51a4dPYHyGEW7oVjbFV9wE60R5shYk8nz qqLC1EhEwhfIlRGFUMe70LYghtY1dIWbFsbp5o9fWoIS9q8Qqf+AoYIt/lk2cD3h1pDf yS/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=D2U7cyco; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h10si2127106edk.552.2021.09.09.07.26.15; Thu, 09 Sep 2021 07:26:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=D2U7cyco; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245645AbhIIOZr (ORCPT + 99 others); Thu, 9 Sep 2021 10:25:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235271AbhIIOZj (ORCPT ); Thu, 9 Sep 2021 10:25:39 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4565C120D58; Thu, 9 Sep 2021 05:57:49 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id i28so2836854ljm.7; Thu, 09 Sep 2021 05:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yaXPdkw/Y9GdnRrZu+T/3Q1JexcjWMNdLrpPjZG0BhA=; b=D2U7cycoQUakuVjq4AfwqLpDws5gRVABN3oZXOPsGA9tx1klPjt3fuGdthO9PRQyPj JjTfsoFHoQytvwYxGWTUr0xt6onfHdJavozJVa55xU2HxhD2l1EFovVSZPWgNY2l+5RK 9Gufd6PR33/i4kY05o8oqmGhh/U8tmA2vLexbDBom+fOn1oWMvIx21lzAs/qSWeHAkFE wnJR2zAOHONpcwfAsHW0phzKMPE3AFd3q7gyS0HDPZIve7L1pZc7fRauGRsNg4il4DN0 qB3Tf8KNgC6pzQpbMCiUeG8qDrJKrao7RX9AQ47CiuhyVkWYphxLO26DheX0FHpQCo8k f0GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yaXPdkw/Y9GdnRrZu+T/3Q1JexcjWMNdLrpPjZG0BhA=; b=GsKpJDez0Xijh0/odx1jwIYzXkhWkjv3DFXXnGpj6RMClcmTer0DjaYgwOkvj1jcEQ U7o1nEyzA5z8brsBn+hQRY1ZRDQRKpYZY6xoQdsRhZhEOOWBr/ypTb0KbwVq9WXMEhCZ pDzHjN/gkK8rmX4DFcBh6l1RS47D1jJ03tsidO0midlHqpDzMHO3NezdYlCiR5cnW0uI XRP2sISqwuuuDpsfYHTy0l8+IRIn4M6BVM2Lw2CunI9DSbyWpmqEftSBAKM09QTfycFg q2EM1kYL2UR/AN/d/cBWpA1vxAa0UZBIgtlrspWFCpJMWYnHBDYjazc0CE/JY0xWzr+m dX6A== X-Gm-Message-State: AOAM532Ux0x0JtcqXpALR3WPha/GP6oCdQG4oMugrM7fNA53EOCP4OwD eNcN5BY8yOTE5LqiQx7V3N0iMdTGGrE= X-Received: by 2002:a2e:955:: with SMTP id 82mr2107879ljj.274.1631192268253; Thu, 09 Sep 2021 05:57:48 -0700 (PDT) Received: from kari-VirtualBox (85-23-89-224.bb.dnainternet.fi. [85.23.89.224]) by smtp.gmail.com with ESMTPSA id b12sm185350ljf.62.2021.09.09.05.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 05:57:47 -0700 (PDT) Date: Thu, 9 Sep 2021 15:57:46 +0300 From: Kari Argillander To: Konstantin Komarov Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/3] fs/ntfs3: Change max hardlinks limit to 4000 Message-ID: <20210909125746.3io24xmh377ca4nh@kari-VirtualBox> References: <89127d37-a38a-d15c-36f1-62f2ac0f4507@paragon-software.com> <20210909123034.mlsq57bsjvonwwd2@kari-VirtualBox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210909123034.mlsq57bsjvonwwd2@kari-VirtualBox> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 09, 2021 at 03:30:34PM +0300, Kari Argillander wrote: > On Thu, Sep 09, 2021 at 01:58:04PM +0300, Konstantin Komarov wrote: > > xfstest 041 works with 3003, so we need to And it would be good to write generic/041. This way grepping is little easier. > > raise limit. > > No need to linebreak. > > > > > Signed-off-by: Konstantin Komarov > > --- > > fs/ntfs3/ntfs.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/fs/ntfs3/ntfs.h b/fs/ntfs3/ntfs.h > > index 6bb3e595263b..0006481db7fa 100644 > > --- a/fs/ntfs3/ntfs.h > > +++ b/fs/ntfs3/ntfs.h > > @@ -21,7 +21,8 @@ > > #define NTFS_NAME_LEN 255 > > > > /* ntfs.sys used 500 maximum links on-disk struct allows up to 0xffff. */ > > -#define NTFS_LINK_MAX 0x400 > > +/* xfstest 041 creates 3003 hardlinks. */ > > It think comment is unnecessary here. If you think this is necassarry > comment then please but it same comment block as last row. > > > +#define NTFS_LINK_MAX 4000 > > What draw backs there is if this is 4000? We really do not care about > xfstests if we have some reason to not do this. This info can be but > to commit message. > > > //#define NTFS_LINK_MAX 0xffff > > We can probably same time get rid of this. > > > > > /* > > -- > > 2.28.0 > > >