Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp575527pxb; Thu, 9 Sep 2021 07:26:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqmF28cV1Q169Lx+VjYpJtIORaq+xK6ziD0LZNGNc8/Gy5FsSm2dVomO6sgvN1rhTVuBgY X-Received: by 2002:a92:d445:: with SMTP id r5mr1467355ilm.255.1631197603560; Thu, 09 Sep 2021 07:26:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631197603; cv=none; d=google.com; s=arc-20160816; b=Ox5vZ89qeUu/EcLMtMkHb5IgxzQGLtptFECF5wRy012uncE8E8IkDXhh4VKfXyxTO4 6e0vcADaAD9NOYjebEKOCfJzB/hpAMehVuIot25a0Jv47uV1Im1x6kccKc8nonPDBsFg OQd6jZaJo3mjULP5CjSHj8qR9mCmraetY4X+YfYvQfEmSFCJ9zLOxllJwokcvPs9QO9r 6H0sPdO3wRKCYxRYdiV6SH3FWz8qyDIJSYORdSfmK8knyMmL/QcNXJ+dLwizZsC1FZHo G3nkorDcew3Fgnc4t8aLj6ilmVtUoYgvBZKYkmmMSqHIqkxinUnHy1Wv8RPlzmz7qjZI bxFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=VXBqdGZV180Tlah+cVQrTrUES/kEF10pr/rM/UOgwDw=; b=x+UzVQD7iOY1kH9yUdIAjY6ae+FG0wfJ39RRdQ+aqU1LnqVcmd6hi0aYVgDi9LALsX RxpIbDuOpBL6O8vNlSeu1pflPvcLunUhR0d85RRGmqwBILu/htm2QXo0T+xNxA8p/TMZ AXmlgQg2rVgSchNeiLfDfxRp2EX/RTStWIlxvQIzWfxhE5T5y4oDjTArXeHo4FOfvJPc H0AFakplp8XIkCtrBvuqETYfS0HcQxLila/q57pTVHfAaN84Ghk20rvjL/BzfLZtie55 CKHSvWt4Dg0yPxyPR7xYuIeHN6t37E6H6FaqMCMa6aUvaSrOfsmjIVSbEfwwWFMZXv4T Uj0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=ZmrWVy5U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s16si1694537ilh.179.2021.09.09.07.26.29; Thu, 09 Sep 2021 07:26:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=ZmrWVy5U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237093AbhIIOZd (ORCPT + 99 others); Thu, 9 Sep 2021 10:25:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237690AbhIIOZ0 (ORCPT ); Thu, 9 Sep 2021 10:25:26 -0400 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A8ABC125127 for ; Thu, 9 Sep 2021 05:57:27 -0700 (PDT) Received: by mail-il1-x129.google.com with SMTP id x5so1794650ill.3 for ; Thu, 09 Sep 2021 05:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VXBqdGZV180Tlah+cVQrTrUES/kEF10pr/rM/UOgwDw=; b=ZmrWVy5URFDxQTuLq82DOsdwoy1iv6TWlp3VcRyKlMnmA+xJ9lImnUPPg81fQiu7cT U7RaxGExbCGnUPjR6c9MeGu25BnjX0HYiCVwHiFeL1Cbm9TU73tEj5gNsrU/k+OQbmgN SGv4KNaiNi77Yngsv0bU4XjFnDQazE3re6UBdhG12d2myTS6V7qnhaFBgYg4llFtQ1or S2BaZTyq/0Tj4ufikxBPOq48N3q3ppHYA1Y8U1a7mUhGyts/T3oBAhqpfuwiupQUKgNL rx2J62DFPcrW2AdaAMHznekwWft/lTclVyWyuKc5z2FxdmaquOIZ5Simzv/oovzeR68r g3ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VXBqdGZV180Tlah+cVQrTrUES/kEF10pr/rM/UOgwDw=; b=tta994Ra7+74yTGPI/AxTSJUVKIS6M9WvfZwIbG9Drz4/zlgGsME6azGcPj9JNnF55 tNAUBly9/Ki4vmEfY2LMOROgKOcRUmR4RYIfhmPXmUGV+OFAw7H82qTh+cM1f9OojXG3 iPr32V7d69zAYAiTrsl+vxZCm8+3S2Re1k1eJ2yRqGdWdf7ZTNzbymzZwLIIgXY/rSXs djNKXacSr9ft3lAKoZGEHBS0bUG9YyeI9XYZ2MYuTEzImnjE1mruourZzF1Asc2inekg J66YkElurYl6yDzm5WsN6eeegoMopB8xr2EhL4J6DqLJShoO+SH6z9TyMfztlR8q6ZMk DJwQ== X-Gm-Message-State: AOAM532Capu6QHHzE92lstBM/B0kFqGUYolpHMisIZR9bP8ARRlZRTOT tNrkU4/wZqhfXIzMzyJIU6KyZWu9f/xWxQ== X-Received: by 2002:a92:cdac:: with SMTP id g12mr2082056ild.201.1631192246585; Thu, 09 Sep 2021 05:57:26 -0700 (PDT) Received: from [192.168.1.116] ([66.219.217.159]) by smtp.gmail.com with ESMTPSA id o15sm859294ilo.73.2021.09.09.05.57.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Sep 2021 05:57:26 -0700 (PDT) Subject: Re: [PATCH] io-wq: fix memory leak in create_io_worker() To: qiang.zhang@windriver.com, asml.silence@gmail.com Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210909115822.181188-1-qiang.zhang@windriver.com> From: Jens Axboe Message-ID: <6ab6186c-1267-a8ac-9da1-3fc83be1f82e@kernel.dk> Date: Thu, 9 Sep 2021 06:57:25 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210909115822.181188-1-qiang.zhang@windriver.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/9/21 5:58 AM, qiang.zhang@windriver.com wrote: > From: "Qiang.zhang" > > BUG: memory leak > unreferenced object 0xffff888126fcd6c0 (size 192): > comm "syz-executor.1", pid 11934, jiffies 4294983026 (age 15.690s) > backtrace: > [] kmalloc_node include/linux/slab.h:609 [inline] > [] kzalloc_node include/linux/slab.h:732 [inline] > [] create_io_worker+0x41/0x1e0 fs/io-wq.c:739 > [] io_wqe_create_worker fs/io-wq.c:267 [inline] > [] io_wqe_enqueue+0x1fe/0x330 fs/io-wq.c:866 > [] io_queue_async_work+0xc4/0x200 fs/io_uring.c:1473 > [] __io_queue_sqe+0x34c/0x510 fs/io_uring.c:6933 > [] io_req_task_submit+0x4b/0xa0 fs/io_uring.c:2233 > [] io_async_task_func+0x108/0x1c0 fs/io_uring.c:5462 > [] tctx_task_work+0x1b3/0x3a0 fs/io_uring.c:2158 > [] task_work_run+0x73/0xb0 kernel/task_work.c:164 > [] tracehook_notify_signal include/linux/tracehook.h:212 [inline] > [] handle_signal_work kernel/entry/common.c:146 [inline] > [] exit_to_user_mode_loop kernel/entry/common.c:172 [inline] > [] exit_to_user_mode_prepare+0x151/0x180 kernel/entry/common.c:209 > [] __syscall_exit_to_user_mode_work kernel/entry/common.c:291 [inline] > [] syscall_exit_to_user_mode+0x1d/0x40 kernel/entry/common.c:302 > [] do_syscall_64+0x42/0xb0 arch/x86/entry/common.c:86 > [] entry_SYSCALL_64_after_hwframe+0x44/0xae > > when create_io_thread() return error, and not retry, the worker object > need to be freed. Thanks, this one looks complete. -- Jens Axboe