Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 9 Sep 2021 17:01:41 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Huang Rui <ray.huang@amd.com>
Cc:     "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Borislav Petkov <bp@suse.de>, Ingo Molnar <mingo@kernel.org>,
        linux-pm@vger.kernel.org, Deepak Sharma <deepak.sharma@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Nathan Fontenot <nathan.fontenot@amd.com>,
        Jinzhou Su <Jinzhou.Su@amd.com>,
        Xiaojian Du <Xiaojian.Du@amd.com>,
        linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 04/19] cpufreq: amd: introduce a new amd pstate driver to
 support future processors
Message-ID: <YToh1Vhei2PyhlW+@hirez.programming.kicks-ass.net>
References: <20210908150001.3702552-1-ray.huang@amd.com>
 <20210908150001.3702552-5-ray.huang@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210908150001.3702552-5-ray.huang@amd.com>
Precedence: bulk

On Wed, Sep 08, 2021 at 10:59:46PM +0800, Huang Rui wrote:

> +struct amd_pstate_perf_funcs {
> +	int (*enable)(bool enable);
> +	int (*init_perf)(struct amd_cpudata *cpudata);
> +	void (*update_perf)(struct amd_cpudata *cpudata,
> +			    u32 min_perf, u32 des_perf,
> +			    u32 max_perf, bool fast_switch);
> +};

> +static int
> +amd_pstate_enable(struct amd_pstate_perf_funcs *funcs, bool enable)
> +{
> +	if (!funcs)
> +		return -EINVAL;
> +
> +	return funcs->enable(enable);
> +}

> +static int amd_pstate_init_perf(struct amd_cpudata *cpudata)
> +{
> +	struct amd_pstate_perf_funcs *funcs = cpufreq_get_driver_data();
> +
> +	if (!funcs)
> +		return -EINVAL;
> +
> +	return funcs->init_perf(cpudata);
> +}

> +static int
> +amd_pstate_update_perf(struct amd_cpudata *cpudata, u32 min_perf,
> +		       u32 des_perf, u32 max_perf, bool fast_switch)
> +{
> +	struct amd_pstate_perf_funcs *funcs = cpufreq_get_driver_data();
> +
> +	if (!funcs)
> +		return -EINVAL;
> +
> +	funcs->update_perf(cpudata, min_perf, des_perf,
> +			   max_perf, fast_switch);
> +
> +	return 0;
> +}

> +static struct amd_pstate_perf_funcs pstate_funcs = {
> +	.enable = pstate_enable,
> +	.init_perf = pstate_init_perf,
> +	.update_perf = pstate_update_perf,
> +};

> +static int __init amd_pstate_init(void)
> +{
> +	int ret;
> +	struct amd_pstate_perf_funcs *funcs;

> +
> +	funcs = &pstate_funcs;

What is the purpose of this seemingly pointless indirection? Showing off
how good AMD hardware is at doing retpolines or something?