Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 0/3] Fix for KSZ DSA switch shutdown
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Vladimir Oltean <olteanv@gmail.com>, p.rosenberger@kunbus.com,
        woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
        vivien.didelot@gmail.com, f.fainelli@gmail.com,
        davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210909095324.12978-1-LinoSanfilippo@gmx.de>
 <20210909101451.jhfk45gitpxzblap@skbuf>
 <81c1a19f-c5dc-ab4a-76ff-59704ea95849@gmx.de>
 <20210909114248.aijujvl7xypkh7qe@skbuf>
 <20210909125606.giiqvil56jse4bjk@skbuf>
 <trinity-85ae3f9c-38f9-4442-98d3-bdc01279c7a8-1631193592256@3c-app-gmx-bs01>
 <YTokNsh6mohaWvH0@lunn.ch>
From:   Lino Sanfilippo <LinoSanfilippo@gmx.de>
Message-ID: <8d168388-4388-c0ec-7cfa-5757bf5b0c24@gmx.de>
Date:   Thu, 9 Sep 2021 18:46:49 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YTokNsh6mohaWvH0@lunn.ch>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 09.09.21 at 17:11, Andrew Lunn wrote:
>> Andrew: the switch is not on a hat, the device tree part I use is:
>
> And this is not an overlay. It is all there at boot?
>

Well actually we DO use an overlay. The dev tree snipped I posted was an e=
xcerpt form
fdtdump. The concerning fragment looks like this in the overlay file:


        fragment@4 {
                target =3D <&spi6>;
                __overlay__ {
                        #address-cells =3D <1>;
                        #size-cells =3D <0>;
                        pinctrl-names =3D "default";
                        pinctrl-0 =3D <&spi6_pins>, <&spi6_cs_pins>;
                        cs-gpios =3D <&gpio 16 GPIO_ACTIVE_LOW>,
                                   <&gpio 18 GPIO_ACTIVE_LOW>;
                        status =3D "okay";

                        ksz9897: ksz9897@0 {
                                compatible =3D "microchip,ksz9897";
                                reg =3D <0>;
                                spi-max-frequency =3D <50000000>;
                                spi-cpha;
                                spi-cpol;
                                reset-gpios =3D <&expander_core 13 GPIO_AC=
TIVE_LOW>;
                                status =3D "okay";

                                ports {
                                        #address-cells =3D <1>;
                                        #size-cells =3D <0>;
                                        /* PORT 1 */
                                        port@0 {
                                                reg =3D <0>;
                                                label =3D "cpu";
                                                ethernet =3D <&genet>;
                                        };
                                        /* PORT 2 */
                                        port@1 {
                                                reg =3D <1>;
                                                label =3D "pileft";
                                        };
                                        /* PORT 3 */
                                        port@2 {
                                                reg =3D <2>;
                                                label =3D "piright";
                                        };
                                        /*
                                         * PORT 4-7 unused
                                         */
                                };
                        };

                        tpm: tpm@1 {
                                compatible =3D "infineon,slb9670";
                                pinctrl-names =3D "default";
                                pinctrl-0 =3D <&tpm_pins>;
                                reg =3D <1>;
                                spi-max-frequency =3D <1000000>;
                                interrupt-parent =3D <&gpio>;
                                #interrupt-cells =3D <2>;
                                interrupts =3D <10 IRQ_TYPE_LEVEL_LOW>;
                                status =3D "okay";
                        };
                };
        };


But probably this does not matter any more now
that Vladimir was able to reproduce the issue.

> I was just thinking that maybe the Ethernet interface gets opened at
> boot, and overlay is loaded, and the interface is opened a second
> time. I don't know of anybody using DSA with overlays, so that could
> of been the key difference which breaks it for you.
>
> Your decompiled DT blob looks O.K.
>
>     Andrew
>