Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Prakash Sangappa <prakash.sangappa@oracle.com>
To:     Jann Horn <jannh@google.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
        "mingo@redhat.com" <mingo@redhat.com>
Subject: Re: [RESEND RFC PATCH 1/3] Introduce per thread user-kernel shared
 structure
Thread-Topic: [RESEND RFC PATCH 1/3] Introduce per thread user-kernel shared
 structure
Thread-Index: AQHXpQ/g06hPOdU64EmuN7MijWkmM6ua8BWAgAEGoIA=
Date:   Thu, 9 Sep 2021 17:30:45 +0000
Message-ID: <F1DBA19D-8151-42AF-9C97-DF75159B8F88@oracle.com>
References: <1631147036-13597-1-git-send-email-prakash.sangappa@oracle.com>
 <1631147036-13597-2-git-send-email-prakash.sangappa@oracle.com>
 <CAG48ez1isvC9c8aem1m6n2uPPHzG4H-otDW7yEUJXDktf=q0Ag@mail.gmail.com>
In-Reply-To: <CAG48ez1isvC9c8aem1m6n2uPPHzG4H-otDW7yEUJXDktf=q0Ag@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vzzWc0ByZ6+UY3zNDjZIbd7bC+UB6kMgoDUSqG4ObelIE24/VHmdyT5HOoBi?=
 =?us-ascii?Q?BU8biN4YLP67KD5iynz8+azE3QOC+w5GcYWasS+OhNoKnO8oWjl8yXvCKArR?=
 =?us-ascii?Q?mTdNJZA1mDf2XCWYbBWn70UAV2ozJ+oJTGpSeb8J98gTwG0/ugWd1FMgnifC?=
 =?us-ascii?Q?oQPFYmN0sC7mp9h3azHudruJ9/qWXBMyaNsac9s8iLQifNIt6bnmB3bStWjG?=
 =?us-ascii?Q?aUy8HswnfGSSO0F6zKgHoMXy8MrYhngwfD18IwQABqmWaxpF7gM5nQRK7amK?=
 =?us-ascii?Q?1OBCbW2AXPhrcq5yobNc0hwlT0/njn1oxR8vhcOC6R/1RLGaJR09VdORLbmV?=
 =?us-ascii?Q?vqXRV8UI2D3IcxGy0m6Rm0V9OCBnJ/A0f/5DfnJVwmZk4qDvFKWw8YkpDjqG?=
 =?us-ascii?Q?LDV9aBGZVVPPaei41jX+nm4jX/VekIWbJ9CdDiG8fF4LebaFOSXgorzHQmho?=
 =?us-ascii?Q?iparxeNeybixOzwQUQIYuAgPu1cC+Yaat/qlsR+8Tm8/VyiZAvoYpVr8alrz?=
 =?us-ascii?Q?HyqNatJAOjXtID36iXI9p33FZx07Y1vXA6dryQXQNNsk2gCVcoV1kLQewlqh?=
 =?us-ascii?Q?UmJ7xMBovfXtRCX7Y0AWPknWsG3YrPZXuZ/cWnbbulFhjvJ4Z1sYoKxYzrCo?=
 =?us-ascii?Q?qwuLvbaXMXONIQIFdPAMm0TCXPu3FHKVpsrwTuNgzGAZK2M4J1S1iqNVQ493?=
 =?us-ascii?Q?gJBSN8d9K9H9eVIChO4jwt+1KLUhd9zCowBvZ4HMAmuXyabyA3VeRbe4nI5v?=
 =?us-ascii?Q?p9w8lr5H9caRP6HU+AfNYn0VgIYA3fNg4YUjKDL+thUlt5i0OVp75JyjHupQ?=
 =?us-ascii?Q?UYJ4lKZwFlbJPC+UyKpPzns9NjC88HyridxniTpy+2Jw4j36nKkQwtXFSSOe?=
 =?us-ascii?Q?k+RSZMAabYq/fiu90GzA5iL0pVGOxuKT1EwTDlv9J2CNeNB6QNR7EWBWFWYO?=
 =?us-ascii?Q?Y38wbntHmV8jVouk5+0kzqXnkY7LiagDyAOyuUA6unxzxEFlzLbkB/xZQ4Jw?=
 =?us-ascii?Q?ULpU+ewv5xRGYCFNr71UZ7Hf3f7yTywDeIPxp5HhUKY2c941rzWXRMYwobTy?=
 =?us-ascii?Q?GGi9EbcxI2iqWmKPDVV8ynljq9ZIk0qpWA//4aj5hjO+3nSp+mq3AjnGDwh7?=
 =?us-ascii?Q?x0y60Dlx5iKFO8N/sQWQAoE46YS2MKacRBE+FRoee8Akm+VURhNzKJnaFjya?=
 =?us-ascii?Q?vztymAG4RE2jXWNo/iJCuxQItQ8hDKGALWpuVy+tC3HMMM+EGY8Gsvi7H+uS?=
 =?us-ascii?Q?RWFk9HoeqMcnyYjmrhjWekn5jrvsy5tk7aO0jVaeKjnASr+ZNPaUTSiCaKDd?=
 =?us-ascii?Q?vHjObsDn2+5L6625zIH2NvGQJp6/uKfkuYvtMRIiKAAg44LnTKQRmHSK8UPi?=
 =?us-ascii?Q?gBF3A88=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <435572A83659224A98041FEB7BC3A475@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2629.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa4bccdb-4587-412c-f2e8-08d973b78e49
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2021 17:30:45.2816
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /tq2gIR8Qr5Vqt8g+WC6STwRFDxcK/pQtGs686TarXuuxqEQm6V8y/vZeIpJpcXaVTYiYdQ+1NNpawvgJMDru5zuDOGUZhfrJwqbPU4O0x8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4815
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10102 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0
 mlxlogscore=999 malwarescore=0 spamscore=0 mlxscore=0 suspectscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109030001 definitions=main-2109090107
X-Proofpoint-GUID: kTqr9MIRyza9t-OdU20lLG8dgVU0vqny
X-Proofpoint-ORIG-GUID: kTqr9MIRyza9t-OdU20lLG8dgVU0vqny
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Sep 8, 2021, at 6:50 PM, Jann Horn <jannh@google.com> wrote:
>=20
> On Thu, Sep 9, 2021 at 2:16 AM Prakash Sangappa
> <prakash.sangappa@oracle.com> wrote:
>> A structure per thread is allocated from a page that is shared mapped
>> between user space and kernel as means for faster communication. This wi=
ll
>> facilitate sharing information, Ex: per thread stats shared between kern=
el
>> and user space, that can be read by applications without the need for
>> making frequent system calls in latency sensitive code path.
> [...]
>> +               /* Try to map as high as possible, this is only a hint. =
*/
>> +               pg->vaddr =3D get_unmapped_area(NULL, TASK_SIZE - PAGE_S=
IZE,
>> +                                       PAGE_SIZE, 0, 0);
>=20
> I don't have an opinion on the rest of this patch, but from a security
> perspective, please don't map things at fixed addresses; let the mmap
> code pick some random address that it wants to use. If an attacker
> manages to overwrite some userspace pointer with chosen data, we don't
> want them to know an address where they can be sure something is
> mapped.

Sure. I will address this.=20
Thanks,
-Prakash