Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp755343pxb; Thu, 9 Sep 2021 11:12:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaRROiFNboRTMmJGOFZ1BNELD+3qLSiB6zjNxIJvCGqgWt0FML586pmbZj3WX3h7NLCde0 X-Received: by 2002:a17:906:e1a:: with SMTP id l26mr5016968eji.45.1631211128481; Thu, 09 Sep 2021 11:12:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631211128; cv=none; d=google.com; s=arc-20160816; b=jugvSDh6WJd26HGZqVuQxZXPl37hrZmtOP5iUEob6AbaP9qnJPpvtCt/X0ZZkFRvV0 bxA9f7EDiy12FxaPRB/2np/WJ00uYKRJxr6+dDcRt9pmRhheSkMKGkoS3uF99owmKwSP rFSMyOZCw3W8TsAypHdwoZt+2inWs1GNVIDA/PP+K+FZ1of6yawSNBHq4wlSeEmfuYiT 8iLKyhPYwyg8jVjJEIYyaZBXafg02HK85TT0fHW2aYm6wU1LO5OFiAyEuRMbEfbKRE4d drV3Nf1DXMrjTtbrMh/yLLwzlIMhyc5ccht5ZIZecVvNZsWyn7yx6iilltHO4ZevWXC1 FOIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XyzdfVcXNWHz2AnLeeSYWunihPeiHYmqdtq+pDc6YuI=; b=u3svjF0N6OwfmiJWx8wtrBPmPkVLOjmzk+ftmEMBTkQq0B499+ErCdpkCLEbOhJuJy nEAtBOw7KA2YIDqtGkkgBPOQT95ky9Ja1yyltnc/20vVURS3tbvlH2XFcAoe1mTuGUL6 uEPwrZd1JGrJFQfm4He4hr19VfSYZ5GlJktvZmlBszWcpHsiQxfOTIj2U4vO4Z4Uhq1I pyljxsA8osm9nxhEn56VP/gK/7MJTCk3yslseSACaWtOhO1hUA5Yn7T6dihF4kM7N25k JNzBYfRr28OmPCkWrdKjSqAG1uGCKV2Fb16D3vOLk/Pr7GTaMVlZ3qdLe+iWxN9vcDXt Jmig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=S9rT8RXz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r24si3274076ejy.194.2021.09.09.11.11.44; Thu, 09 Sep 2021 11:12:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=S9rT8RXz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243609AbhIISLP (ORCPT + 99 others); Thu, 9 Sep 2021 14:11:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243456AbhIISLI (ORCPT ); Thu, 9 Sep 2021 14:11:08 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A154CC061574 for ; Thu, 9 Sep 2021 11:09:57 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id r3so4358929ljc.4 for ; Thu, 09 Sep 2021 11:09:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XyzdfVcXNWHz2AnLeeSYWunihPeiHYmqdtq+pDc6YuI=; b=S9rT8RXz5SICnplyyuiERWwzAiKoLRp5EKF50aEp3PGd47T0Rh7EtvsixVSJLQJ1qW lVqfKMCGh0L+IUTYg8VJujFywfRvzcVxfFaLd4q9J+aQGs6V+MLoI1npO/IZ9g3F0slc wvvnTSWXGRmbdSbl9khYlirdxZfLetqeIAqtTlDncRwR3HP1zcUE7+y/lFUo3ltL/M8i iK/tYM2Snq2TxqTFxU050YNu4mCzMHRkFtQqHiBrKBQ8w2VEjeMF8AD8YA/jMapA/fAL VCPspyRQ6IHFXhMmUiv7R57PQEye759px6PNOEfUjuZlGLdqSC2kRoVvUu1hwgaF4/EK KZzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XyzdfVcXNWHz2AnLeeSYWunihPeiHYmqdtq+pDc6YuI=; b=K9fibrx0Vf38nWbC0yLBoUp8R/HgG7tQDo9bHGE7NtAL85bX6CCMwMD8qpghlEIxtZ K7+4iXmGhr7wiIojDg4HWIYOMDBggsyuVew7dYebWL/+i9VQXxt0kXdS1Am+70HfAsj+ z59fZe2/5KIP/7PjqNx240crlqkdgmMhvf8PTQ3ABgLIMOhu8iIrYo+EgehZ76ldUuw1 nhi1cprF3dTvc/hG7rriuoIMOZW0o+I2xKuaR7vC/sOhptliPXoYtG/U0eo7kROP+1X9 +b39s5naSUIaX7tVFHGhVahRCPwHq555yv8sI3Zx/EoaNcY2/G2Zk5izsXU9YV5O7XZG CLlA== X-Gm-Message-State: AOAM531/X/PyJ6nPm8XQl4maby2joVwBxy0y6xxNVdyoER0oo0PX89s5 wlmCtKMQHWB/4HRTjcqcNunTTiXJ2q4= X-Received: by 2002:a05:651c:11c7:: with SMTP id z7mr938354ljo.288.1631210996000; Thu, 09 Sep 2021 11:09:56 -0700 (PDT) Received: from kari-VirtualBox.telewell.oy (85-23-89-224.bb.dnainternet.fi. [85.23.89.224]) by smtp.gmail.com with ESMTPSA id u2sm270276lff.238.2021.09.09.11.09.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 11:09:55 -0700 (PDT) From: Kari Argillander To: Konstantin Komarov , ntfs3@lists.linux.dev Cc: Kari Argillander , linux-kernel@vger.kernel.org, Christian Brauner Subject: [PATCH 03/11] fs/ntfs3: Remove impossible fault condition in fill_super Date: Thu, 9 Sep 2021 21:09:34 +0300 Message-Id: <20210909180942.8634-4-kari.argillander@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210909180942.8634-1-kari.argillander@gmail.com> References: <20210909180942.8634-1-kari.argillander@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove root drop when we fault out. This can never happened because when we allocate root we eather fault when no root or success. Signed-off-by: Kari Argillander --- fs/ntfs3/super.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c index 6ddc0051fe73..793c064833c2 100644 --- a/fs/ntfs3/super.c +++ b/fs/ntfs3/super.c @@ -1297,12 +1297,6 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc) out: iput(inode); - - if (sb->s_root) { - d_drop(sb->s_root); - sb->s_root = NULL; - } - return err; } -- 2.25.1