Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp757683pxb; Thu, 9 Sep 2021 11:15:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxN4JzfUk2NH/xMCsfQ3jzu1iYd75FuhjBFz5GSr8zNzvvZFs1Jmb+l+FK84RGzhGbx4qr X-Received: by 2002:aa7:c649:: with SMTP id z9mr4577521edr.304.1631211334322; Thu, 09 Sep 2021 11:15:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631211334; cv=none; d=google.com; s=arc-20160816; b=G9AmOtv7VqbyBszveUVTMvtZSIspQhjTnt804JRyDaOr++uPN5+9A8C02SSfMmCubS Y3/2zU3xfkgYP0ultS1ElEbbXh4+r/EHI50I2GXinWFJo1U5QBs9xEMaUgHCZBIVU6ao xEtLv/sBkv1ytpZ93BozMh0u9EUM2NQl1yINe2mM7rn7OVx62viJrXSwyv6jyPG+FuCm j42ZHidYpBYKqyvTcw5H5Hx0jjFHQbJGFqJpvgCefmrSC4tXaD1B9e6XMRsjhY7LfVX/ ZYCDCCXhKaMG07tKXWWb8IBEm7dUc7GT1O0QsZNob0MMSJ7B5pYaeE1NzgQtcdJUgRk6 886A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+ZfipCwxhRp6Ie3Aw8psddkQkoxd2J2YHBmheHWPB+M=; b=soVTWBH4/lBTn+4iwGKtpyzRMdcTlvbSC1GBpLsoV87t26LctjbRoo0rgNvkaq7Oqx 2Ckc//tZhipaND2TYCakjwLTVU9yGVZuaIqtVL9Uoppsa//iWBXKIpS27GYou1B4c2cw bhdglPuRu7LvdVgpYMAMEiQqh94ah3DzUPDOY/HQYEyDt7ysILRkUTRmeAnOw4PrWKez AGJhREoy8Shepp2UJN6tSNUq0ZZSwF6Ibz48N4JCbm0uvVefLA6VDXZuJy3P0+W6MmI9 0j8s9N1DT0r4t2u6qFj86FgGeMBUho8YeM1hHBJkUzEn6nLr/hyP2gi+01ilEwMY/Kjm Y+1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=kUOdeKUq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c102si2886750edf.195.2021.09.09.11.15.09; Thu, 09 Sep 2021 11:15:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=kUOdeKUq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244907AbhIISLv (ORCPT + 99 others); Thu, 9 Sep 2021 14:11:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243881AbhIISLR (ORCPT ); Thu, 9 Sep 2021 14:11:17 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32487C061757 for ; Thu, 9 Sep 2021 11:10:07 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id m4so4345783ljq.8 for ; Thu, 09 Sep 2021 11:10:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+ZfipCwxhRp6Ie3Aw8psddkQkoxd2J2YHBmheHWPB+M=; b=kUOdeKUqJMNDgRmus6zXohIAtzc233o7W3lzXHUGyl7zkndtyB1FgmVsbZ1tYyw3JX yGZSFenrNgMzFjZJXwIFR7OQrrMEXwGejegAqaxSDpidIazAr2bcGhzDktfxORMpEmhF bFeKINoyNFY4RxaFhruu4Z3nSppUxIGbaE7rBx03TaxLNPRp7QVLYCh1YF5s8FfvTWs5 4HQ/HyOVPcAzLWIx4T7c7PSuwE574hTC30z5MD+gboo8ZO1swEL/2p9JfqiGYeKk0nal 5MIIwE/VHw96JJNeZqcZJEgr0zCCr/1J8UUPeTbSnHDSRHz+Ov1XXdXPt3UBy22shYth mdaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+ZfipCwxhRp6Ie3Aw8psddkQkoxd2J2YHBmheHWPB+M=; b=2o9TH03cL9gzAnCF0zek+S3FEw/H64LKBk+ae0IlAr3I1S7QLUjD34oenwstK6+gM4 MNqYGLLj4AEO/VVjsFW2knJ9OluX+cE6Ndj81MM1pm+YpQKfZLUFH/fZ7tmce0PV2xm2 55uYV7+/u2mWfYk1jR+P1Hqom6PFoDj/N7G9tBT+7+taD0ogwoGqtBoiVi1xze7hBvI1 2zqXTFeeJAN+xAWPXqqpFNgntvhA5D+hfW5hpGIvsYpUDRj8o3LHuTTK8+AnRU+JqBvt klBAVccfzJHfjUeNi8DmZyXnc9vy5C1QvJofoCAGd6e+GSOxSKCFQcXFd37XB8JPuNBO mj8w== X-Gm-Message-State: AOAM5301JM+XUdFkf01lWN+8QmQ9qgJkl5YMSw3tHGIOs5I13NuaHNgb PFm9OEtVmLXjyFHRiyyLygY= X-Received: by 2002:a05:651c:54d:: with SMTP id q13mr949179ljp.526.1631211005502; Thu, 09 Sep 2021 11:10:05 -0700 (PDT) Received: from kari-VirtualBox.telewell.oy (85-23-89-224.bb.dnainternet.fi. [85.23.89.224]) by smtp.gmail.com with ESMTPSA id u2sm270276lff.238.2021.09.09.11.10.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 11:10:05 -0700 (PDT) From: Kari Argillander To: Konstantin Komarov , ntfs3@lists.linux.dev Cc: Kari Argillander , linux-kernel@vger.kernel.org, Christian Brauner Subject: [PATCH 10/11] fs/ntfs3: Initialize pointer before use place in fill_super Date: Thu, 9 Sep 2021 21:09:41 +0300 Message-Id: <20210909180942.8634-11-kari.argillander@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210909180942.8634-1-kari.argillander@gmail.com> References: <20210909180942.8634-1-kari.argillander@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Initializing should be as close as possible when we use it so that we do not need to scroll up to see what is happening. Also bdev_get_queue() can never return NULL so we do not need to check for !rq. Signed-off-by: Kari Argillander --- fs/ntfs3/super.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c index 9a096be32fb2..321fcfce64e1 100644 --- a/fs/ntfs3/super.c +++ b/fs/ntfs3/super.c @@ -877,7 +877,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc) int err; struct ntfs_sb_info *sbi = sb->s_fs_info; struct block_device *bdev = sb->s_bdev; - struct request_queue *rq = bdev_get_queue(bdev); + struct request_queue *rq; struct inode *inode; struct ntfs_inode *ni; size_t i, tt; @@ -906,9 +906,8 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc) return -EINVAL; } - if (!rq || !blk_queue_discard(rq) || !rq->limits.discard_granularity) { - ; - } else { + rq = bdev_get_queue(bdev); + if (blk_queue_discard(rq) && rq->limits.discard_granularity) { sbi->discard_granularity = rq->limits.discard_granularity; sbi->discard_granularity_mask_inv = ~(u64)(sbi->discard_granularity - 1); -- 2.25.1