Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp865960pxb; Thu, 9 Sep 2021 14:05:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7Alj/pAdgVEJqwSPwaWdM+ukTJvNWAZV8LkP1SCtqgX9goasnYyLHg62ndWBqx3WV2AUn X-Received: by 2002:a6b:ba57:: with SMTP id k84mr4290482iof.131.1631221539758; Thu, 09 Sep 2021 14:05:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631221539; cv=none; d=google.com; s=arc-20160816; b=eYEwJtUwvqBDsLbg0hzeDwv7mIG8XMI1yBz8b2H9myLN6JjgL/vV3jfvttrs2pticE /kx6+HvVsXIHS6FWUBGNaiJ33Xx1/LOSn+wk1WpKjrsQ3753NgEBvdDbt1WYm+wDszbS T7fas06YVlXfLkXwH1HsVFe+atttHCEno6VmSX1pBM0XuAMRoay8Nd9k9H+lbJg4IdX0 B7phd6qvZu5uO4ZfBXWDx0Oxl5pNuaOCSz4YiENCyQvsn8w2QXHjTd3pge2IWXCPuDXN QkjrXSyqYHTvjPYb+6Jc+dshZsfNSW4Md+aYX4voQ1j6FqPjZINPVzRoVtVtujGTbXVC Qu4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8PTE0Yp5aDkSeBEqIuFJReXHpA2uRHL4THhzDtBtHM8=; b=inyZm4sgt3yj5oZF9YiPgdo11peg8Xjgbwap9Imtqhqc56w0om0PoHRjWChhzbO1IG MYyYpehGfE8e+5H6f0TYnMfbh3c/oq27jQqtj0H5++868j1YslibqZ0uE8DOaRAb4c4y hYnr6ZC/HJ79HyjcodVPIvE/USpeD2ZsxbXshiA6UBmxdnM1Ud0Svtm8MUhsl/oACNG6 wXeJ9ssaM8nIPTy2MZd3VMuHULp0Mu/2gWXe/pSwRr2Omsas/IHt/DV8UxttMQqjWd19 RmktOXMqXWby3jhGsDXfHBxcsWMm6K51B126LiAlgfDzgXiA6NTJb+PWdul/6tUCOSXv az7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hUm04el1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p14si3379207iov.81.2021.09.09.14.05.26; Thu, 09 Sep 2021 14:05:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hUm04el1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347276AbhIIVDg (ORCPT + 99 others); Thu, 9 Sep 2021 17:03:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347762AbhIIVDC (ORCPT ); Thu, 9 Sep 2021 17:03:02 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80A82C0613C1 for ; Thu, 9 Sep 2021 14:01:49 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id n4so1901743plh.9 for ; Thu, 09 Sep 2021 14:01:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8PTE0Yp5aDkSeBEqIuFJReXHpA2uRHL4THhzDtBtHM8=; b=hUm04el1zXzdBx52xN3cigDxnD1hqWSFUO2ijZO9vUniVOCWCPnQZtbLvdsMaNNm/f yvw2mPOpV0JpHty1NPK1u3cpMEGA6caOD26/7i+BN3OxqZYM6L/Msi49GV3tAWY3DX3M BE+0Y5hEQft4W9Y9v755culUmqPWyizS7U1Bc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8PTE0Yp5aDkSeBEqIuFJReXHpA2uRHL4THhzDtBtHM8=; b=1mXzQZB4G9dSV64HPLSdX9/H3oA4FGGsv3vRlTfp6jKG0duFLH8+Ezg3jPAkf4LozL c66iz5JHdbCjRXJI2E5JgxTW3wbU3kygzEEvSExqSzNwmnbCpyTm1khuU5jFagsrogaG GiXJc3MIIF3o5G02sgCm0eu0rnZhyLsYtA7rZ6wfqE+I3xeI2VnTnbk8rAdysbLjBuyt h3b9uoAaGcte+I4P6LKrvikIxnWouN8cUxj0gM5HlMJUniTAT2U/nmTu73DK8PZCNw/L ZrbC9VJv9pqPn60/0DyxhXwrQLssvLLVMarkx54szTfsEYV0TqQDTNmGbAWchMwhiZ6S Ch7Q== X-Gm-Message-State: AOAM533sOmDWFoZcugw3gLYfAOhcghB197AYh4bRJ8QQTlWwzGw7o0lS QJAcIDijAGYIdXao+AsGo3fncA== X-Received: by 2002:a17:902:ec90:b0:13a:34f9:cfe9 with SMTP id x16-20020a170902ec9000b0013a34f9cfe9mr4621219plg.74.1631221309002; Thu, 09 Sep 2021 14:01:49 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:8da3:b0fb:4261:2c10]) by smtp.gmail.com with ESMTPSA id l143sm177069pfd.60.2021.09.09.14.01.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 14:01:48 -0700 (PDT) From: Douglas Anderson To: Thierry Reding , Rob Herring , Sam Ravnborg Cc: devicetree@vger.kernel.org, Maxime Ripard , Thomas Zimmermann , Linus W , Daniel Vetter , linux-arm-msm@vger.kernel.org, Steev Klimaszewski , Maarten Lankhorst , Bjorn Andersson , David Airlie , dri-devel@lists.freedesktop.org, Douglas Anderson , linux-kernel@vger.kernel.org Subject: [PATCH v4 14/15] drm/panel-edp: Don't re-read the EDID every time we power off the panel Date: Thu, 9 Sep 2021 14:00:30 -0700 Message-Id: <20210909135838.v4.14.Ib810fb3bebd0bd6763e4609e1a6764d06064081e@changeid> X-Mailer: git-send-email 2.33.0.309.g3052b89438-goog In-Reply-To: <20210909210032.465570-1-dianders@chromium.org> References: <20210909210032.465570-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The simple-panel driver is for panels that are not hot-pluggable at runtime. Let's keep our cached EDID around until driver unload. Signed-off-by: Douglas Anderson Acked-by: Sam Ravnborg --- Changes in v4: - panel-simple-edp => panel-edp Changes in v3: - ("Don't re-read the EDID every time") moved to eDP only patch. drivers/gpu/drm/panel/panel-edp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index a83ef9905ea7..817c60858ef8 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -362,9 +362,6 @@ static int panel_edp_suspend(struct device *dev) regulator_disable(p->supply); p->unprepared_time = ktime_get(); - kfree(p->edid); - p->edid = NULL; - return 0; } @@ -758,6 +755,9 @@ static int panel_edp_remove(struct device *dev) if (panel->ddc && (!panel->aux || panel->ddc != &panel->aux->ddc)) put_device(&panel->ddc->dev); + kfree(panel->edid); + panel->edid = NULL; + return 0; } -- 2.33.0.309.g3052b89438-goog