Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <5cdc5c42-e218-7be5-a2e9-2c412bb8a840@nvidia.com>
Date:   Thu, 9 Sep 2021 15:26:43 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH] rapidio: Avoid bogus __alloc_size warning
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>
Cc:     kernel test robot <lkp@intel.com>,
        Matt Porter <mporter@kernel.crashing.org>,
        Alexandre Bounine <alex.bou9@gmail.com>,
        Jing Xiangfeng <jingxiangfeng@huawei.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Souptick Joarder <jrdr.linux@gmail.com>,
        "Gustavo A . R . Silva" <gustavoars@kernel.org>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
References: <20210909161409.2250920-1-keescook@chromium.org>
 <20210909132752.4bde36ccf50720e56160f00c@linux-foundation.org>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20210909132752.4bde36ccf50720e56160f00c@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmF2b3RzYVVtY3JRUFpyWEFwdG5BVlRnMXc3Z3F3NHdpNjdDbmI2SkRwRUtN?=
 =?utf-8?B?emt1MEdnQ0RaSTg1LzIrRVFFNkJIVW9VQUhpMjhuYThkTjZVOU5NVmFhRlR0?=
 =?utf-8?B?VVhPUFZvc3YxSlZLekR3aWFRdk1LaFoxaFpIeTFpZWkzRDcyZndKWWVRVmhv?=
 =?utf-8?B?MDlQRUtFaVR5SS8wQVZremVtdHFjOVAvTllBVHhKOThwVjh2TldqeCtWMUQ4?=
 =?utf-8?B?Yk1YUjkzVS9tVEFYdjR6Y1NzaUN1RS9PVVJMaGhNbVJTSEFOWmlDQ051bnRk?=
 =?utf-8?B?Q3pwY3lBbmV1RklSVDBFdjFpTHJUVEpqRm45cEpHazJUdE9WVjhiNUpaSmxO?=
 =?utf-8?B?bW1WZzcrdkNqeCsxUW9EVE9TdXRzNXdtdzRldHJHa09MZDZRbW9hYWlYRWVn?=
 =?utf-8?B?VGVvNWhteDNZaEk3Ti81VUdRTjlsUTVsdFZVZzVVM1ZCR3lZY0E2OGNhbk1h?=
 =?utf-8?B?aEh2YzZERzdyR1RIZ1lHUHV0REhYdXhvN2h1T2NxWTBPbHUwYUdtVUNib3Nh?=
 =?utf-8?B?ejlEQUZ4dTllRkc5QTlTemkzb1VUQnR0SXVDTzU2aEFlQUoreDRucUZNaXNs?=
 =?utf-8?B?cUlaazNINW5uV2FYL3h5MmRnVHVYTE90d0VZY1hTZjdHaWlpcGNqNkh2MUhB?=
 =?utf-8?B?UlQxakwyR3ZrSmZ3d0VnTHI1MXhYd3dYOHBGajhHQkFiaW5NY1VaVVBEYndG?=
 =?utf-8?B?dmEyU0V2ZnZWOWU5M0tXZHA0b0hiRmV3a1I3Z3ZxY0U4T3dBVERoTmhtTDAy?=
 =?utf-8?B?YkY1NS9UMjhEdmNVOGF5Nmg4TU5PVmFIeUpLUS9rZ0EvUVhLZDFrY3FyWjFL?=
 =?utf-8?B?WHA2NzRWQmV5MEJpTk9DVy82L2VnR1M1RzJXc2N6Tll6dlBrQlhDUUFPVjA0?=
 =?utf-8?B?S29NWHh3ejZ1bHlzSFZDUnR1d3NlQXluelNHaU91SmJKWk9QRlJDSmZ1WmlF?=
 =?utf-8?B?amxwT3pRUWszV2JLNmQyaUE0SUEvcWFFb0x3clI5a3BId2R5emUvS2krakxt?=
 =?utf-8?B?QkZDNHhqbm1hTktuOWFLeVcvK0Izd28zNnA3MDR2eHB6YXAwRmEyT0Z6YmJt?=
 =?utf-8?B?M0xkajNYbjJQSTB0Q1A3NExQcVhJQk9qOEpEV21Sa0hyY1JqQ0xibUtVY3lR?=
 =?utf-8?B?NG1LMk40Z2ljRFE1dGFvU3JZaGptRnlVNnE5OTVPaDh6cnVTM3l5d2hFVkVn?=
 =?utf-8?B?NVB4SzFjbVVLL2M2MGZTdENLN2xpZU5QMnRITkEzTUhKbjdUN1IvNStEaFdW?=
 =?utf-8?B?d2VRNEhldmlQVFBuYlBSQUV4UzN1QTQzaXVaYVFVUk1zV2EwMmx6UGxQeE0x?=
 =?utf-8?B?S2N0REE4b2Zub2NqWE9TQ0xNTmwwdFZaR1dpYVFpTTlqSFRQUmNKZkNoczNC?=
 =?utf-8?B?OUxHcmc3ak5kNTJ3azdHNWZ3RXBFK0x1VmRBcGRrSHBIbE05TWZlSWtZUFdz?=
 =?utf-8?B?a1ZENVdvRVkySC8xcVBnSE56YlNHRnZhNFE2SzZXd29BcTdUenExR1B6WUtG?=
 =?utf-8?B?YkUxVC9MdFZIdmUxVG9WdUlMSXdRRGFIaW1XaXU0R2Jjc3pnU1FROTVLVVhs?=
 =?utf-8?B?dXM4V3c1cG04MzBCTk9zWkdoUmkraDFVRDJUVTNiNFJhZnhZNE1DeU4rWUZ4?=
 =?utf-8?B?OHkxMnZBd3oveG54c1B5M1J2bVVJZEtXVjd6eG5GaHpJUllLMTkyWXYwUmRq?=
 =?utf-8?B?cHYxVGxUbDd6SWpTRndNdE42eVFBMDJVb1E5YzFVM1JCVCtRY0w4OG1LR3Jx?=
 =?utf-8?Q?V7kkfJwIEGB/GRHQbxGRdAlGn8s84tWc76KAgi9?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24d5d93a-5099-4ef2-865c-08d973e0e825
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2021 22:26:45.5343
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9L3KYQHA6XIfePbSWZSKF15PSWrCZNkaOrXtNApwvj2yH4B7W7Cz+5fvATRbFe1Ijx/8txcE+YMXQoWKGE74vg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4967
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/9/21 13:27, Andrew Morton wrote:
...
>>     include/linux/thread_info.h:213:4: error: call to '__bad_copy_to' declared with attribute error: copy destination size is too small
>>       213 |    __bad_copy_to();
>>           |    ^~~~~~~~~~~~~~~
>>
>> But the allocation size and the copy size are identical:
>>
>> 	transfer = vmalloc(array_size(sizeof(*transfer), transaction.count));
>> 	if (!transfer)
>> 		return -ENOMEM;
>>
>> 	if (unlikely(copy_from_user(transfer,
>> 				    (void __user *)(uintptr_t)transaction.block,
>> 				    array_size(sizeof(*transfer), transaction.count)))) {
> 
> That's an "error", not a warning.  Or is this thanks to the new -Werror?
> 
> Either way, I'm inclined to cc:stable on this, because use of gcc-9 on
> older kernels will be a common thing down the ages.
> 
> If it's really an "error" on non-Werror kernels then definitely cc:stable.
> 

It looks like a hard error, not a warning upgraded by -Werror: I did a local
repro, then ran with V=1, removed all -Werror parts of the gcc invocation,
ran again, and still reproduced the error.

I also verified that the patch causes the error to go away.

Also, I can't find anything wrong with the diffs, so:

Reviewed-by: John Hubbard <jhubbard@nvidia.com>


thanks,
-- 
John Hubbard
NVIDIA