Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 18/19] cpupower: print amd-pstate information on cpupower
To:     Huang Rui <ray.huang@amd.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Borislav Petkov <bp@suse.de>, Ingo Molnar <mingo@kernel.org>,
        linux-pm@vger.kernel.org
Cc:     Deepak Sharma <deepak.sharma@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Nathan Fontenot <nathan.fontenot@amd.com>,
        Jinzhou Su <Jinzhou.Su@amd.com>,
        Xiaojian Du <Xiaojian.Du@amd.com>,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20210908150001.3702552-1-ray.huang@amd.com>
 <20210908150001.3702552-19-ray.huang@amd.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <70bef125-398b-8a3c-07f5-a4ebc68dc0c8@linuxfoundation.org>
Date:   Thu, 9 Sep 2021 16:46:39 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210908150001.3702552-19-ray.huang@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/8/21 9:00 AM, Huang Rui wrote:
> amd-pstate kernel module is using the fine grain frequency instead of
> acpi hardware pstate. So the performance and frequency values should be
> printed in frequency-info.
> 
> Signed-off-by: Huang Rui <ray.huang@amd.com>
> ---
>   tools/power/cpupower/utils/cpufreq-info.c | 27 ++++++++++++++++++++---
>   1 file changed, 24 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c
> index f9895e31ff5a..9eabed209adc 100644
> --- a/tools/power/cpupower/utils/cpufreq-info.c
> +++ b/tools/power/cpupower/utils/cpufreq-info.c
> @@ -183,9 +183,30 @@ static int get_boost_mode_x86(unsigned int cpu)
>   	printf(_("    Supported: %s\n"), support ? _("yes") : _("no"));
>   	printf(_("    Active: %s\n"), active ? _("yes") : _("no"));
>   
> -	if ((cpupower_cpu_info.vendor == X86_VENDOR_AMD &&
> -	     cpupower_cpu_info.family >= 0x10) ||
> -	     cpupower_cpu_info.vendor == X86_VENDOR_HYGON) {
> +	if (cpupower_cpu_info.vendor == X86_VENDOR_AMD &&
> +	    cpupower_cpu_info.caps & CPUPOWER_CAP_AMD_PSTATE) {
> +		printf(_("    AMD PSTATE Highest Performance: %u. Maximum Frequency: "),
> +		       amd_pstate_get_data(cpu, HIGHEST_PERF));
> +		print_speed(amd_pstate_get_data(cpu, MAX_FREQ));
> +		printf(".\n");
> +
> +		printf(_("    AMD PSTATE Nominal Performance: %u. Nominal Frequency: "),
> +		       amd_pstate_get_data(cpu, NOMINAL_PERF));
> +		print_speed(amd_pstate_get_data(cpu, NOMINAL_FREQ));
> +		printf(".\n");
> +
> +		printf(_("    AMD PSTATE Lowest Non-linear Performance: %u. Lowest Non-linear Frequency: "),
> +		       amd_pstate_get_data(cpu, LOWEST_NONLINEAR_PERF));
> +		print_speed(amd_pstate_get_data(cpu, LOWEST_NONLINEAR_FREQ));
> +		printf(".\n");
> +
> +		printf(_("    AMD PSTATE Lowest Performance: %u. Lowest Frequency: "),
> +		       amd_pstate_get_data(cpu, LOWEST_PERF));
> +		print_speed(amd_pstate_get_data(cpu, MIN_FREQ));
> +		printf(".\n");
> +	} else if ((cpupower_cpu_info.vendor == X86_VENDOR_AMD &&
> +		    cpupower_cpu_info.family >= 0x10) ||
> +		   cpupower_cpu_info.vendor == X86_VENDOR_HYGON) {
>   		ret = decode_pstates(cpu, b_states, pstates, &pstate_no);
>   		if (ret)
>   			return ret;
> 

Same issue here - amd specific code sprinkled all over the common routines.
Needs fixing.

thanks,
-- Shuah