Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp953242pxb; Thu, 9 Sep 2021 16:13:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdIVdp9oLwdveB21Fs6j3d41GlA4mPT/sxtQf4AHHLFaK2DlRb4qdWfLEBU6A7z/45FLsC X-Received: by 2002:a05:6602:1543:: with SMTP id h3mr4535209iow.123.1631229181921; Thu, 09 Sep 2021 16:13:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631229181; cv=none; d=google.com; s=arc-20160816; b=AEwc5Q1OkIlPK+84agW6Umo6uK6KOY8Y/lBTn5NIpp3YiDuSxJlgXaTPCSl+17DJjL K7+ov7Rkma6dZSFusByxcjSjvM/j2aYD4DlKl1YRvsQQK4uHQh/RoEuIJIXq1HKMYKFq 0Vmf6IShVM0jiQzJlAKbOLyBOfBB7oUqCJxgRwSE1qi/7XkmDwuO4GhmNt31KklVS4lA Dd9X4Jcs1tDT+DnPfNymfyG4EPJgkwQH+RoOWFatr0OccUwy5sS50RNQ+KgWDUvbdzmV rhiM3gRXzf/YBH5NXrhnkLoyjqiP7Gl2eC79fuTYREr8OAt/xaPI2UESNDCfR+aN7mk0 BTiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=TfUtny4azavFnt1xUPr0uAanX+WNSYDx6khaN6Xinis=; b=oSmKY9pwfpxKgD9v0FE19KA6ZvO7Xif9XQuLuJmDlY7Rr8aWZzFClRuNQRRoerhVHm BTGzys08nbA0SCHSZEQhWBdPrVShiwkyvc8BBk7yI/1f9I2LM9EHc3tsD+OFvMa8/BwN 2SA7puJe1vnbExpBMW61XTqzwRmntVgVix89JNWxy7Jnics2ByYYrb2nyTSMVsrgUVnh sc69f+HDozY4mDCmDT917b3JVJFE+6ws/5jJydCb0XLi7g9B+e1E142oLByIdtqgtP0B GkyacOGy4CpOPVvSlTp9uZTCENOnaxUbsopDMEtiijIUmatKYL3vG0/K/eA1GWWBDv1K jvYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=uGmstYBO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a7si2670420ila.35.2021.09.09.16.12.50; Thu, 09 Sep 2021 16:13:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=uGmstYBO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348704AbhIIXMV (ORCPT + 99 others); Thu, 9 Sep 2021 19:12:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:50388 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347875AbhIIXMU (ORCPT ); Thu, 9 Sep 2021 19:12:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 678DC610FF; Thu, 9 Sep 2021 23:11:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1631229070; bh=qI+46Ea8gyDuK37vgtlT0gB4jyidNDsAKRJ3889xuwc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uGmstYBOpdTL/asymH2h1fKfJ+cTNRyP1qVB2RQKnRBfkEiiwctc0tY6Q0wU292MJ SXD9ci1kp4aVYZ3OlDvDawcpabPKzo6y2pFG1KPGiL+vzlAAaUywrUs8vlKAaVyU4N 0AO+p2asdgUIK7+MtfxxSvuoxU1bSk76SAR68V4c= Date: Thu, 9 Sep 2021 16:11:09 -0700 From: Andrew Morton To: Kees Cook Cc: kernel test robot , Matt Porter , Alexandre Bounine , Jing Xiangfeng , Ira Weiny , John Hubbard , Souptick Joarder , "Gustavo A . R . Silva" , Dan Carpenter , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] rapidio: Avoid bogus __alloc_size warning Message-Id: <20210909161109.14b147628de07ed7c20d84ae@linux-foundation.org> In-Reply-To: <202109091549.FF8E0C61E2@keescook> References: <20210909161409.2250920-1-keescook@chromium.org> <20210909132752.4bde36ccf50720e56160f00c@linux-foundation.org> <202109091549.FF8E0C61E2@keescook> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 9 Sep 2021 15:51:23 -0700 Kees Cook wrote: > > That's an "error", not a warning. Or is this thanks to the new -Werror? > > This is a "regular" error (__bad_copy_to() uses __compiletime_error()). > > > Either way, I'm inclined to cc:stable on this, because use of gcc-9 on > > older kernels will be a common thing down the ages. > > > > If it's really an "error" on non-Werror kernels then definitely cc:stable. > > I would expect that as only being needed if __alloc_size was backported > to -stable, which seems unlikely. Ah. Changelog didn't tell me that it's an __alloc_size thing. What's the status of the __alloc_size() patchset, btw?