Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp1079047pxb; Thu, 9 Sep 2021 20:01:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxn74lWcPWCpjEUCoKqH/iCK3IDCEhi5ApOFT7vV7gSDdvUqh/LFP0PrnI4pRJJmQmjdd9w X-Received: by 2002:a17:907:3f18:: with SMTP id hq24mr6876293ejc.384.1631242913145; Thu, 09 Sep 2021 20:01:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631242913; cv=none; d=google.com; s=arc-20160816; b=LTyTJQ8u3K1pN3+qO1XiLUF9MApkAdO9qj0SzZ+svBsEGSOR0xT99weqNaC/MZj1Pj 6SWcY2Y6NOecvAdl4X9F/gKtP7ERk0H/Dl/7rUm4CmW8bGPyNA90VO7g0yp8/bXgrZcR O8nmCuGXXtziQpFlsz2Myp3UMsFvf2M5Dj/63KrcUzslVbeCyTNpBkj+ohHPubct1bU6 KmY/b7vJbxLdlrDqx84cR4qjETOJGTJvf2UKYGPu8l4GhOC+p42PyKcP0raHIuVxtTjw YcWNC3o5+u7t+hm/vBneUSB69t99R9YGKryIgyeh35swdmM7ubasOYKlmTM0VRdt/In6 XvyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=XIEJT9NQApq9D23CGoDgacVCse/1/fLUyNxLxfjLqdY=; b=y+UemyId6R2x/dSj4jD6fc2SiZ+hMJzXzVdMrbSi+BC5WA76mOgpZISobeWdhzL9/W jWV7W75nY82de5yWlUxrtgNU+97O7zL44eLS8ImMwAkrIA1LgXYGxoO2EIXR+waQj4kn rJNTh2ei5l10ZAAtL54XXkONf4obqZzyL1iOH72ZKDx1MYGIJXtZ9xNW+x3qy/P61HMl byQbfwdeem/RGlaJ8sYAMBjrooBM5A1DObDDbGNPtz3uHei5+x9O9HotjP0Aiuu0xXsG 2rNAXB2eAPATlnCy5M5LsgpAhSOPmtVDxPG7alvdFKRrZkCMnmQ76m14x4rM9PkbL3Ix 92og== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c12si1256913ede.275.2021.09.09.20.01.29; Thu, 09 Sep 2021 20:01:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229900AbhIJDBS (ORCPT + 99 others); Thu, 9 Sep 2021 23:01:18 -0400 Received: from zeniv-ca.linux.org.uk ([142.44.231.140]:58820 "EHLO zeniv-ca.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbhIJDBR (ORCPT ); Thu, 9 Sep 2021 23:01:17 -0400 Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOWji-002mkY-ON; Fri, 10 Sep 2021 02:57:54 +0000 Date: Fri, 10 Sep 2021 02:57:54 +0000 From: Al Viro To: Jens Axboe Cc: Linus Torvalds , Pavel Begunkov , Linux Kernel Mailing List , linux-fsdevel Subject: Re: [git pull] iov_iter fixes Message-ID: References: <5971af96-78b7-8304-3e25-00dc2da3c538@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5971af96-78b7-8304-3e25-00dc2da3c538@kernel.dk> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 09, 2021 at 03:19:56PM -0600, Jens Axboe wrote: > Not sure how we'd do that, outside of stupid tricks like copy the > iov_iter before we pass it down. But that's obviously not going to be > very efficient. Hence we're left with having some way to reset/reexpand, > even in the presence of someone having done truncate on it. "Obviously" why, exactly? It's not that large a structure; it's not the optimal variant, but I'd like to see profiling data before assuming that it'll cause noticable slowdowns.