Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 10 Sep 2021 07:50:10 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Kees Cook <keescook@chromium.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        kernel test robot <lkp@intel.com>,
        Matt Porter <mporter@kernel.crashing.org>,
        Alexandre Bounine <alex.bou9@gmail.com>,
        Jing Xiangfeng <jingxiangfeng@huawei.com>,
        Ira Weiny <ira.weiny@intel.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Souptick Joarder <jrdr.linux@gmail.com>,
        "Gustavo A . R . Silva" <gustavoars@kernel.org>,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] rapidio: Avoid bogus __alloc_size warning
Message-ID: <20210910045010.GO1935@kadam>
References: <20210909161409.2250920-1-keescook@chromium.org>
 <20210909132752.4bde36ccf50720e56160f00c@linux-foundation.org>
 <202109091549.FF8E0C61E2@keescook>
 <20210909161109.14b147628de07ed7c20d84ae@linux-foundation.org>
 <202109091849.53C9A8AD@keescook>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202109091849.53C9A8AD@keescook>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UaEzzUx6t7e88guowYqZKQXw++kdtASQp7E1JwO9htgZM/rngclPg8scry0Q?=
 =?us-ascii?Q?Nzbb4UbdhrHHLDuFKlVQ7e5ZLgY4mTnuiQuvoLsMaXqdfF41Y67SherCMru/?=
 =?us-ascii?Q?mzM8WyoF5yrmIC5a4YgsjeKaGtMuVJecYw9SkTLQ1gYGEVFJImc5cGFcfuWH?=
 =?us-ascii?Q?TuDPTalpVL2PRSV8hHRGFCbHzAaj2xcky/0PiALb5hJFfXkSDxtLqP2Dvb+L?=
 =?us-ascii?Q?p9YuaaARboux1VfNKpTdjIJ4GJTxsrUMZt9ULF+ieSc4bch7jDdenXb/JJiX?=
 =?us-ascii?Q?jI2jFmg2QHmUwe0N6Ope62anxqN62G/Aqbt3yh0QwQJz2d3Nrq8jo0/O8+wu?=
 =?us-ascii?Q?MkvkSFFn9wPBEkGrnqLEhCNz1w7XYS0YgIJZeesI/z0+uvyU4BKxQ6hBM/FQ?=
 =?us-ascii?Q?qaoSvUEQ25C0GoLLjXORfW8ejC9zhnHEaQ8cNv/5YDr3v0ZjNbXUCNWdQwXY?=
 =?us-ascii?Q?1oRHiUs/8SYTntgA1OPp37DI4676ikkCa5tOJUkAhQgbW57HOfC+CA2qqv5q?=
 =?us-ascii?Q?3Bq4sgV8fueQTCsNwzK9EH5WizAAzBVqfatk4ost4Cb/NsjnWMFpTiacNYSy?=
 =?us-ascii?Q?7aWW/nufvhs8ARbGMRDtI2luvmc3Qi/4Zsap0QLeencNe0H+WP0tf/lv0CFJ?=
 =?us-ascii?Q?HuqA7ehIOUoly3/PdYjwvXTlykEHgdVJaS6t+J9lGrYCwAs9eqBUUlPIZA1G?=
 =?us-ascii?Q?ehY4mbxF6Msf+huA+L0dHB5HdXEm7A4NW/ZgliCEzT53sNntTvdVmoT6nr1X?=
 =?us-ascii?Q?8qsc6WeQ+s5C25EbDyUcKp1ggM0t2YGDx+cZMQmiKxPTWtCpklrjTNINjq0C?=
 =?us-ascii?Q?0msLcW91c9BwxBtfwl/RgZni+4ntEAiWukCXnTfHxayNtC0zQV9b/Fym1b/g?=
 =?us-ascii?Q?jsyvcrzbkmAdx/eGyAt4kwI1xHVumagNoW0S+Os17w3JoiO61vToTLmt+AoG?=
 =?us-ascii?Q?EZyn2a/httfaYNp0KPZUBnPLVk3b1YlWC/mseqGFEQM9ufMh5R6o2ZV/ati1?=
 =?us-ascii?Q?0cX1253vN8AsR6yMsgqAQz/sPyk50qEymN5ypRwBIg46V0okqBPPVXg8CubR?=
 =?us-ascii?Q?UyZSVTptn0ts+NNLzMCbOBeuy29xWl9wCvEJFcqsM5I6+F20cfcoLCND5xhm?=
 =?us-ascii?Q?qxPJTDSqSwABye1cikkxN5MZIF7fD3POYs5Ma5k03WFHxi2UwRYOIjwaidE8?=
 =?us-ascii?Q?bkYpehMq3534t2Mp7MmrC1QWGkHkwooah8TxrGXzLW3JZzU6Hm+22IhSI88T?=
 =?us-ascii?Q?tdAr9ZGgRYf+1hNzNnepwQ4JjvPBThUWSZrTX3pgrBpxyvXvrSl3DuUii6jK?=
 =?us-ascii?Q?fwFV3U48MfmFpvkUWk4eK7Lk?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8bbd1449-a3ce-4a9f-d512-08d974168218
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2021 04:50:27.3142
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sFxAm2jix5lzwTS/C+ysl1KSzQjzOHwmMBxS3YpcCgnnO/xUU6QQH7Vcke46s3ipvXYAf4b/f2y0gXRYCLCicdqPyFHn8tIt/AlCO2X5ul4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4561
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10102 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 bulkscore=0
 suspectscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001
 definitions=main-2109100027
X-Proofpoint-GUID: hUW7RFsTO2VhspaRjLu4WXyNTMGmrTre
X-Proofpoint-ORIG-GUID: hUW7RFsTO2VhspaRjLu4WXyNTMGmrTre
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 09, 2021 at 06:52:27PM -0700, Kees Cook wrote:
> On Thu, Sep 09, 2021 at 04:11:09PM -0700, Andrew Morton wrote:
> > On Thu, 9 Sep 2021 15:51:23 -0700 Kees Cook <keescook@chromium.org> wrote:
> > 
> > > > That's an "error", not a warning.  Or is this thanks to the new -Werror?
> > > 
> > > This is a "regular" error (__bad_copy_to() uses __compiletime_error()).
> > > 
> > > > Either way, I'm inclined to cc:stable on this, because use of gcc-9 on
> > > > older kernels will be a common thing down the ages.
> > > > 
> > > > If it's really an "error" on non-Werror kernels then definitely cc:stable.
> > > 
> > > I would expect that as only being needed if __alloc_size was backported
> > > to -stable, which seems unlikely.
> > 
> > Ah.  Changelog didn't tell me that it's an __alloc_size thing.
> 
> Er, it's in the Subject, but I guess I could repeat it?
> 

This is how the email looks like to Andrew.

https://sylpheed.sraoss.jp/images/sylpheed2-mainwindow.png

Try to find the subject in that nonsense.  Same for everyone else on
email as well.

https://marc.info/?l=linux-kernel&m=163120404328790&w=2

I only either read the subject or the body of the commit message and
never both.  :P

regards,
dan carpenter