Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 9 Sep 2021 22:48:14 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Kees Cook <keescook@chromium.org>,
        kernel test robot <lkp@intel.com>,
        Matt Porter <mporter@kernel.crashing.org>,
        Alexandre Bounine <alex.bou9@gmail.com>,
        Jing Xiangfeng <jingxiangfeng@huawei.com>,
        Ira Weiny <ira.weiny@intel.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Souptick Joarder <jrdr.linux@gmail.com>,
        "Gustavo A . R . Silva" <gustavoars@kernel.org>,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] rapidio: Avoid bogus __alloc_size warning
Message-Id: <20210909224814.7460f8dfa3134742b90b34eb@linux-foundation.org>
In-Reply-To: <20210910045010.GO1935@kadam>
References: <20210909161409.2250920-1-keescook@chromium.org>
        <20210909132752.4bde36ccf50720e56160f00c@linux-foundation.org>
        <202109091549.FF8E0C61E2@keescook>
        <20210909161109.14b147628de07ed7c20d84ae@linux-foundation.org>
        <202109091849.53C9A8AD@keescook>
        <20210910045010.GO1935@kadam>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 10 Sep 2021 07:50:10 +0300 Dan Carpenter <dan.carpenter@oracle.com> wrote:

> On Thu, Sep 09, 2021 at 06:52:27PM -0700, Kees Cook wrote:
> > On Thu, Sep 09, 2021 at 04:11:09PM -0700, Andrew Morton wrote:
> > > On Thu, 9 Sep 2021 15:51:23 -0700 Kees Cook <keescook@chromium.org> wrote:
> > > 
> > > > > That's an "error", not a warning.  Or is this thanks to the new -Werror?
> > > > 
> > > > This is a "regular" error (__bad_copy_to() uses __compiletime_error()).
> > > > 
> > > > > Either way, I'm inclined to cc:stable on this, because use of gcc-9 on
> > > > > older kernels will be a common thing down the ages.
> > > > > 
> > > > > If it's really an "error" on non-Werror kernels then definitely cc:stable.
> > > > 
> > > > I would expect that as only being needed if __alloc_size was backported
> > > > to -stable, which seems unlikely.
> > > 
> > > Ah.  Changelog didn't tell me that it's an __alloc_size thing.
> > 
> > Er, it's in the Subject, but I guess I could repeat it?
> > 
> 
> This is how the email looks like to Andrew.
> 
> https://sylpheed.sraoss.jp/images/sylpheed2-mainwindow.png
> 
> Try to find the subject in that nonsense.  Same for everyone else on
> email as well.
> 
> https://marc.info/?l=linux-kernel&m=163120404328790&w=2
> 
> I only either read the subject or the body of the commit message and
> never both.  :P

I read the body if the subject looks relevant ;)

But that subject reads to me as "rapidio: Avoid bogus *blah* warning". 
We have soooooo many alloc_foo functions that one's eyes glaze over
something like "alloc_size"

Why?  Because the identifier "__alloc_size" is of great significance
to Kees because he wrote the thing.  Everyone else just sees "*blah*".