Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp1187403pxb; Thu, 9 Sep 2021 23:32:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybKvyT9fGt7JLMp6ij8B+ZCMSpdL6YDP8h9DbgjIl8BUkrZxB3NmyXWdMMgFzvivMGmEkN X-Received: by 2002:aa7:df92:: with SMTP id b18mr924874edy.47.1631255578846; Thu, 09 Sep 2021 23:32:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631255578; cv=none; d=google.com; s=arc-20160816; b=W1V4uEOJvQ9fz/3DTHOoImSYocaCjXRNII4vEiMmrveAfXYjS3wccfDiOSezOUfL9H 6ebb83LI8H8fhkpaAB9bdXRs6F8D96kZPEiPDFANAwzj8KVyTwbuDDDvB+W3jkDDWyPs PJu+pLFEyX7AIfPt/QlSdTQWjoJvpJqUYttWZq3OWeKXgbPy7LZxDv0ZrU1nePbaHznM Iz9vBbjFkjhXlVrfZWk2p50n+U+i1YhFkX8rXyXBYMxoqyQXZIMCr7syB9Xeh4q4Bru1 t2myyeL6cGXD47qfG0UzbhBDVxzsWIbMp3cs6QVBE3fIZ9fB/VxB35vE5nd9ttkvf2wn OYEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SqoyNLPV12UI+aH0KY3hvzjuZwQ2VZlAP4igBb/D7xg=; b=fl1sADsuA3oBKVZhmHyboZjDJj9v4kDSrGVvRq7dTBbQOfYa9+7EoqSrzgoOrqglhY aCein5ibaYTyLo1Dd/MKSAZJTSomb8NsuNUMSwIjhCtMFO82RaBYikXO20M4xS1VopbU LUW2AzCYbx9zAcGwmXOZW1hWQo02XpsRA1pZ2aVk7gBioe6NDqW8unvArbLnD/bi9RPd HR0i564BD8RYryhODokt1AM9BGLwRzmf2q6oxH/dyjy5y/J5VIOH5pdHB9V2zcnH5z+f Ht2xoKnnZmeLChgEDqaZlUzuD/8UQ+fqT5yTpC4w/sv3ZfnL/kSutH6+CaXTDNOOsRfY Ej8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aB535l98; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id yc28si4389773ejb.316.2021.09.09.23.32.32; Thu, 09 Sep 2021 23:32:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aB535l98; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231183AbhIJGad (ORCPT + 99 others); Fri, 10 Sep 2021 02:30:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231204AbhIJGaa (ORCPT ); Fri, 10 Sep 2021 02:30:30 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81F98C061756 for ; Thu, 9 Sep 2021 23:29:20 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id v123so988049pfb.11 for ; Thu, 09 Sep 2021 23:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SqoyNLPV12UI+aH0KY3hvzjuZwQ2VZlAP4igBb/D7xg=; b=aB535l98SeNAaY1Uh99F7nuRtdDDNPyqFS0oRlPK59Shl5turlqFkRRF2pIc7Se6Kk JXCs1tGQtTIYyP5AYMNY7sf1sUAKiJeDBQPXbD2wxT7ivIM8staCntTB+GC1LIbFllPa YVnLB4Qr5a+15SBQs1uksXr+Q9A64TPOLXCl0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SqoyNLPV12UI+aH0KY3hvzjuZwQ2VZlAP4igBb/D7xg=; b=6O9NM1sm60c02MidBCRNwBJ2gAY8Yu+zg8MoaLYFjKNwQ1liE2nqm0EWv8cZ/hq7Vy nlK4+Ste1AW9Nj6+IxS25Z2S9UKN5s+Fi1jRjzVb9iaqphabPzVAs/kGgypOglK3/22i e7iEbZgWBp1rZzcPqsciyYZH5JbPNahkFxyXsWyml7F+f6aG5+324KHFMqUZqXbSm1gU I9R1+7xy++PulUzh3Eld7HU67XYFak4CgkwY0W7M9mgnaym/bI+jwIgz8UxyKvbpjL0K mmZ/Nxv6U/quZrjAjZ8qviXW53IVdxjB/vyrAQHgi9AUIaQim36ikzIICO3Ctk3PB/RM 2vkg== X-Gm-Message-State: AOAM5330kI72JXLnsvabDE4tWXvH4Cgy7tDBC8loA2qPts8SMsyFXfes zC/zjVlKP1Cnnb+z0ltFzmY8zQ== X-Received: by 2002:a63:5c51:: with SMTP id n17mr5975475pgm.376.1631255360120; Thu, 09 Sep 2021 23:29:20 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id a11sm4064214pgj.75.2021.09.09.23.29.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 23:29:19 -0700 (PDT) Date: Thu, 9 Sep 2021 23:29:18 -0700 From: Kees Cook To: Andrew Morton Cc: Dan Carpenter , kernel test robot , Matt Porter , Alexandre Bounine , Jing Xiangfeng , Ira Weiny , John Hubbard , Souptick Joarder , "Gustavo A . R . Silva" , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] rapidio: Avoid bogus __alloc_size warning Message-ID: <202109092327.C582B074C@keescook> References: <20210909161409.2250920-1-keescook@chromium.org> <20210909132752.4bde36ccf50720e56160f00c@linux-foundation.org> <202109091549.FF8E0C61E2@keescook> <20210909161109.14b147628de07ed7c20d84ae@linux-foundation.org> <202109091849.53C9A8AD@keescook> <20210910045010.GO1935@kadam> <20210909224814.7460f8dfa3134742b90b34eb@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210909224814.7460f8dfa3134742b90b34eb@linux-foundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 09, 2021 at 10:48:14PM -0700, Andrew Morton wrote: > On Fri, 10 Sep 2021 07:50:10 +0300 Dan Carpenter wrote: > > This is how the email looks like to Andrew. > > > > https://sylpheed.sraoss.jp/images/sylpheed2-mainwindow.png > > > > Try to find the subject in that nonsense. Same for everyone else on > > email as well. > > > > https://marc.info/?l=linux-kernel&m=163120404328790&w=2 > > > > I only either read the subject or the body of the commit message and > > never both. :P > > I read the body if the subject looks relevant ;) > > But that subject reads to me as "rapidio: Avoid bogus *blah* warning". > We have soooooo many alloc_foo functions that one's eyes glaze over > something like "alloc_size" > > Why? Because the identifier "__alloc_size" is of great significance > to Kees because he wrote the thing. Everyone else just sees "*blah*". Heh. Okay, fair enough. I will make Subject/body independent. It felt redundant to me before, but greater verbosity is a good idea. Sorry! -- Kees Cook