Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 9 Sep 2021 23:29:18 -0700
From:   Kees Cook <keescook@chromium.org>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Dan Carpenter <dan.carpenter@oracle.com>,
        kernel test robot <lkp@intel.com>,
        Matt Porter <mporter@kernel.crashing.org>,
        Alexandre Bounine <alex.bou9@gmail.com>,
        Jing Xiangfeng <jingxiangfeng@huawei.com>,
        Ira Weiny <ira.weiny@intel.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Souptick Joarder <jrdr.linux@gmail.com>,
        "Gustavo A . R . Silva" <gustavoars@kernel.org>,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] rapidio: Avoid bogus __alloc_size warning
Message-ID: <202109092327.C582B074C@keescook>
References: <20210909161409.2250920-1-keescook@chromium.org>
 <20210909132752.4bde36ccf50720e56160f00c@linux-foundation.org>
 <202109091549.FF8E0C61E2@keescook>
 <20210909161109.14b147628de07ed7c20d84ae@linux-foundation.org>
 <202109091849.53C9A8AD@keescook>
 <20210910045010.GO1935@kadam>
 <20210909224814.7460f8dfa3134742b90b34eb@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210909224814.7460f8dfa3134742b90b34eb@linux-foundation.org>
Precedence: bulk

On Thu, Sep 09, 2021 at 10:48:14PM -0700, Andrew Morton wrote:
> On Fri, 10 Sep 2021 07:50:10 +0300 Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > This is how the email looks like to Andrew.
> > 
> > https://sylpheed.sraoss.jp/images/sylpheed2-mainwindow.png
> > 
> > Try to find the subject in that nonsense.  Same for everyone else on
> > email as well.
> > 
> > https://marc.info/?l=linux-kernel&m=163120404328790&w=2
> > 
> > I only either read the subject or the body of the commit message and
> > never both.  :P
> 
> I read the body if the subject looks relevant ;)
> 
> But that subject reads to me as "rapidio: Avoid bogus *blah* warning". 
> We have soooooo many alloc_foo functions that one's eyes glaze over
> something like "alloc_size"
> 
> Why?  Because the identifier "__alloc_size" is of great significance
> to Kees because he wrote the thing.  Everyone else just sees "*blah*".

Heh. Okay, fair enough. I will make Subject/body independent. It felt
redundant to me before, but greater verbosity is a good idea. Sorry!

-- 
Kees Cook