Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp1227495pxb; Fri, 10 Sep 2021 00:41:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgHdoy2oXKLSDS6MODa8UXFSbr/Nakw9mamAo5RdH6DVBgNPC7ABNJq374Pyfl2PB8YhNv X-Received: by 2002:a17:906:ed1:: with SMTP id u17mr8166067eji.304.1631259717180; Fri, 10 Sep 2021 00:41:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631259717; cv=none; d=google.com; s=arc-20160816; b=EisryvMPUMGqQt8ZYCwSnb7PwYQgKOJpV2NXjT6gGnJpTc90EnnuZ7zBA/n+pA89vq zKA2Odjhnv5kq46JJlzemY6CNSK40xDZ3MgSlq7/dds43SNOY4Ms9RfusH5F+pJThkeo 8q6y3TAZGX4OpI+J79rJT+eJcDPyqcpEiHw+T3ouIIRLWa/RKeeQAAyODMWG9ZbLyqfQ e4j7ZYXI4vn1A3vRf9jIFz9fa+2AaHlvSo2Z0BB55JqUk/ToSdXitHTArtGOEjIbzZHf DR11Rl1FgLbv2qtXHw577z78NSqnJTrvem1McgCXtHSL3luDj3GMh68BCqoxf2KSAnqT fcFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=OKoWGsqHXDMYyu+uV7rTXmu0osZyZbPhrGNN3ToBOTk=; b=eo1i+O5yidVgWpOOBNTKOZRSMhle5uprA+bvb07LDvMRQRbSUw31mRp1wXVTi2TPTE MnhUcFsfSbY7hVnXaBi9emA3ThwCB2ZGfTjh67lZhfyE3AGVXXkPBWsil2co+Ln8e/FT rGo3f25XBD1AeEbJfD6YzoKIDj5I3MfJVffec66bcURDL6M3rUmc1lU3uvAYBhiGELZZ lFsiQ0a53K6PePKc0fKXSI1tkUP7XaffeyVjJ1cBXse3kHlJ3VRwDpbwEhbMx+EvmlCb BEkzLcsQJYRZyrC4x+NaYDNaAWFdrg35S4RfQwtG0RHhFlBmfMjbMN0gWTCptErwxOgk Ph8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=rpO3mglP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hs4si5374208ejc.266.2021.09.10.00.41.33; Fri, 10 Sep 2021 00:41:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=rpO3mglP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231586AbhIJHlX (ORCPT + 99 others); Fri, 10 Sep 2021 03:41:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231384AbhIJHlX (ORCPT ); Fri, 10 Sep 2021 03:41:23 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C708DC061574; Fri, 10 Sep 2021 00:40:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OKoWGsqHXDMYyu+uV7rTXmu0osZyZbPhrGNN3ToBOTk=; b=rpO3mglPTdCGsKxRrM0B0CQ2D0 I6u7uKG05K/d12zEbb5ksbimIcVlcbmz0VBvyMNJ2v16NGPibVDB3nRtiE9yrmhDDVqbBD59eKvsb K+dtqQR56MVyblMZCXrwo/3zQ2OyvbuGeh5s87lDq39FvtsLu+SKUmJbqS370RZPFSY3VkR92nxpv LLHBeMdtrLIfe8wLcUOjLUqNgt5ssIui/qmKqGon+hgI8EwJYTP8djPb9osTbGy2731CWns6UQUmQ hIDwUOXkSIVKyRSlRcr8M6ZcYZsGt1qQpU489r08j0v2QHnVLCcSM1/r6cpnLYn4phAaAgzfngnc4 rl3xVTUg==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOb5g-00An2r-Uc; Fri, 10 Sep 2021 07:37:21 +0000 Date: Fri, 10 Sep 2021 08:36:52 +0100 From: Christoph Hellwig To: Linus Torvalds Cc: Christoph Hellwig , Andreas Gruenbacher , Alexander Viro , "Darrick J. Wong" , Jan Kara , Matthew Wilcox , cluster-devel , linux-fsdevel , Linux Kernel Mailing List , ocfs2-devel@oss.oracle.com Subject: Re: [PATCH v7 16/19] iomap: Add done_before argument to iomap_dio_rw Message-ID: References: <20210827164926.1726765-1-agruenba@redhat.com> <20210827164926.1726765-17-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 09, 2021 at 10:22:56AM -0700, Linus Torvalds wrote: > I think you misunderstand. > > Or maybe I do. > > It very much doesn't force sync in this case. It did the *first* part > of it synchronously, but then it wants to continue with that async > part for the rest, and very much do that async completion. > > And that's why it wants to add that "I already did X much of the > work", exactly so that the async completion can report the full end > result. Could be, and yes in that case it won't work.