Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp1293055pxb; Fri, 10 Sep 2021 02:36:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfLkNdRMUU1aqJpLO9KIhYhxBQYwn/1Ya/GPJz6ZO/n/eYCBQwg0mBF/azn485SQtZFdaz X-Received: by 2002:a17:906:3adb:: with SMTP id z27mr8455781ejd.291.1631266587614; Fri, 10 Sep 2021 02:36:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631266587; cv=none; d=google.com; s=arc-20160816; b=T79hrJk/6tR+v8zjDym6ckJSYxf7wGC0M64zDIlabq2d9NETo2Yr+ppaTN/237fVEC pesbeGw7VL8ZQ10X3+/lPfR/g1SMWmLze6VpIhnk9IEC6ojTGGAtpVJS8IrdwRiMxM4y WgJIzdbC2Eiui2yXOcmkpBggcUk6zP6m9sMu/6gTFlcmZy4kdc3GCELFQbUw7Skb3yJ6 aW+DcVANYAyLhXET4YUkXpalLlf3gbdVWssOmiK/dumzKesn9a5Wkyl80YApONAdvhZY uP6EOyuwdzGCw7lcAilR8a3pAPMaCdKNB81kKxNkCpvcVXhSYkjqPgvppPsYWcaHURBl L+Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=PujBo4Hb8X7BvAK3k+DiBnpJzKjZIPnzIZLYviV11rM=; b=IumWuFkwMJMLz+vOfCI2f1Vx/CjSm/YdxLdESSdCTmciEXqYXBN5qeKlIq10E12Brc X4Zm2FQxMoseSNCTQAVY6RWzZ/ilvWoj4+FOz8MIM04LZCgMt8bNhpWttjc1yr1/5yDw Ob3+syYcWQIjg0qU5I3uyZKNALe03QhkLpOpPYix8tVBWhpk4C5+FCFNOgHlc5KLo0i7 OCuhQPQ4XjcLoxk2Ikho9UGAmo7srZpqXUeW3xdSHYcVK9UUMRvhkt5Xli1Pt8MviNwU LBWy0+CZYkul8JWeVPmWtEcfzqKNpmDHieLeQpqOT7tAHFSL4jjKAbr3K/rgeCn6TukW FTvw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k1si4574402ejx.491.2021.09.10.02.35.59; Fri, 10 Sep 2021 02:36:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232078AbhIJJep (ORCPT + 99 others); Fri, 10 Sep 2021 05:34:45 -0400 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]:57785 "EHLO out30-57.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231818AbhIJJeo (ORCPT ); Fri, 10 Sep 2021 05:34:44 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R621e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0UntYNdL_1631266409; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0UntYNdL_1631266409) by smtp.aliyun-inc.com(127.0.0.1); Fri, 10 Sep 2021 17:33:31 +0800 From: Yang Li To: kuba@kernel.org Cc: davem@davemloft.net, anna.schumaker@netapp.com, trond.myklebust@hammerspace.com, chuck.lever@oracle.com, bfields@fieldses.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH -next] UNRPC: Return specific error code on kmalloc failure Date: Fri, 10 Sep 2021 17:33:24 +0800 Message-Id: <1631266404-29698-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Although the callers of this function only care about whether the return value is null or not, we should still give a rigorous error code. Smatch tool warning: net/sunrpc/auth_gss/svcauth_gss.c:784 gss_write_verf() warn: returning -1 instead of -ENOMEM is sloppy No functional change, just more standardized. Reported-by: Abaci Robot Signed-off-by: Yang Li --- net/sunrpc/auth_gss/svcauth_gss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c index 3e776e3..7dba6a9 100644 --- a/net/sunrpc/auth_gss/svcauth_gss.c +++ b/net/sunrpc/auth_gss/svcauth_gss.c @@ -781,7 +781,7 @@ static inline u32 round_up_to_quad(u32 i) svc_putnl(rqstp->rq_res.head, RPC_AUTH_GSS); xdr_seq = kmalloc(4, GFP_KERNEL); if (!xdr_seq) - return -1; + return -ENOMEM; *xdr_seq = htonl(seq); iov.iov_base = xdr_seq; -- 1.8.3.1