Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] of: property: Disable fw_devlink DT support for X86
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Saravana Kannan <saravanak@google.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>, kernel-team@android.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210910011446.3208894-1-saravanak@google.com>
 <YTr4CZW+rOXAjNq9@kroah.com>
From:   Andre Muller <andre.muller@web.de>
Message-ID: <5064e6ca-344d-7eda-3264-50fb63e2e3f3@web.de>
Date:   Fri, 10 Sep 2021 12:37:01 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <YTr4CZW+rOXAjNq9@kroah.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 10/09/2021 08.15, Greg Kroah-Hartman wrote:
> On Thu, Sep 09, 2021 at 06:14:45PM -0700, Saravana Kannan wrote:
>> Andre reported fw_devlink=3Don breaking OLPC XO-1.5 [1].
>>
>> OLPC XO-1.5 is an X86 system that uses a mix of ACPI and OF to populate
>> devices. The root cause seems to be ISA devices not setting their fwnod=
e
>> field. But trying to figure out how to fix that doesn't seem worth the
>> trouble because the OLPC devicetree is very sparse/limited and fw_devli=
nk
>> only adds the links causing this issue. Considering that there aren't m=
any
>> users of OF in an X86 system, simply fw_devlink DT support for X86.
>>
>> [1] - https://lore.kernel.org/lkml/3c1f2473-92ad-bfc4-258e-a5a08ad73dd0=
@web.de/
>> Fixes: ea718c699055 ("Revert "Revert "driver core: Set fw_devlink=3Don =
by default""")
>> Signed-off-by: Saravana Kannan <saravanak@google.com>
>> Cc: Andre Muller <andre.muller@web.de>
>> ---
>>   drivers/of/property.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/of/property.c b/drivers/of/property.c
>> index 0c0dc2e369c0..3fd74bb34819 100644
>> --- a/drivers/of/property.c
>> +++ b/drivers/of/property.c
>> @@ -1444,6 +1444,9 @@ static int of_fwnode_add_links(struct fwnode_hand=
le *fwnode)
>>   	struct property *p;
>>   	struct device_node *con_np =3D to_of_node(fwnode);
>>
>> +	if (IS_ENABLED(CONFIG_X86))
>> +		return 0;
>
> I love it :)
>
> Anyway, getting a "Tested-by:" would be great to have here.  Andre, can
> you verify this solves your issue?

Yes, this patch fixes the issue, the drives work fine.
Tested-by: Andre M=FCller <andre.muller@web.de>

Thanks all,
Andre

>
> thanks,
>
> greg k-h
>