Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] perf annotate: Add fusion logic for AMD microarchs
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        jolsa@redhat.com, yao.jin@linux.intel.com, namhyung@kernel.org,
        kim.phillips@amd.com, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org, ravi.bangoria@amd.com
References: <20210906105640.1040-1-ravi.bangoria@amd.com>
 <20210906105640.1040-2-ravi.bangoria@amd.com> <YTpveO0qqKFTaxTk@kernel.org>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
Message-ID: <6a987cad-6c46-280e-f791-6c59b6628a45@amd.com>
Date:   Fri, 10 Sep 2021 16:47:31 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YTpveO0qqKFTaxTk@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yzk4R2ljdHRDTEJDSGNoNEJ5ME5iR2pvQjZhOGltYTBMckJRaU5KdjJLNkQ0?=
 =?utf-8?B?cXUyU056cjFMT1A2OXMwOEJBVTY1ckVZNWd2Q2wvUkpjSFpDbDRZZWNkeEhL?=
 =?utf-8?B?anlUUnRmc1hFb01ocXhsdE1pRTBMZ1dqZ0ZaVGRTeCtqMStMaVoxeWUyRTBz?=
 =?utf-8?B?b0lvSjlKcXFZT0UzWm91VWFGY3hNelU4NGZ5NXp3V1FyZlcrTGhhS0dHV3Rs?=
 =?utf-8?B?dFpLUjFOd3RvOGI3cFJlaml2TEU2TlNQUEdsNVpnTXZpdWQ3QlhtOCtLQkE2?=
 =?utf-8?B?blVNSHVRMDdXYjlSTThjYlkyVVBNKzRnZk52c2NNU0VhZVNCVWFHRmxpUURB?=
 =?utf-8?B?N3ZrczBmUllGWkR5b3JsTVV6ZTlKcmpHdXkvcVpNS0xKZWFNZkNKZnlUY1pa?=
 =?utf-8?B?VzN4emZxU0l3UEdmZU9HT0Y2bFhybHVROS9zMFZrcDR0SGVOU3piNEpCNVB5?=
 =?utf-8?B?WjlyRjJrSWF3ampialRraTRIckxuaUVnekxMY0srVCsrd2dHOHM1ek5hdlg3?=
 =?utf-8?B?WFozQlFDS2VMY2prNmhVYlBwa1ByQmRGcTBDNVNoQWxUU2I3NkxUMm5RaHp1?=
 =?utf-8?B?b0VNMDhUM2QwcFRMYmlPQ0krWDhlclhVQkdOSjdNUms1VVl1S3k4aXk3Uk03?=
 =?utf-8?B?bkhRYWE2WUNUbVZLV2JleEYwak95M216S3g2QTdVK0U4OFlJTjNnVWVHbU11?=
 =?utf-8?B?dnplMDN0MHV6MU10b3FqMi8xU2FnemRpUTdoZ2NzY2xqcW9HeEtyYkVrbmFv?=
 =?utf-8?B?NDQ1aENZUG9vVmM3dUMwQnN3UjFkTlVZRHNFZHdrdGwvQ2RNL0NMaU1BcG1T?=
 =?utf-8?B?QW5HNWlPVWdsNzJKYVhXTHRQUDZGVXBBNkFreVpOWVhrYTNEZXl6TGZlZzlJ?=
 =?utf-8?B?ejlHbmhlamp0UVFScjhKc0RhVTA2T1hqSUEvTkhVYmcydG96NVQ2czJLY0dH?=
 =?utf-8?B?eFpzTmExYmJmdW9tWTN1VWsvZnBCV1lhRHdRakN3NFZMN0k3VGhHekExQldK?=
 =?utf-8?B?STVqakNNUENjZkZIUkJ5NXg3QklQMG9TdHIwd0g2dGF1cmg0R241U2xsZjRs?=
 =?utf-8?B?dE12bVJydWd3ay9QdFoxbFEvdUZzSmh4TFlUcGxQK1AwRVdIeGovdkgvdDRp?=
 =?utf-8?B?MDJvYjE5TktBRklVOFN2RkEwU2ROY2QzdzBEdnM3cEFOdjZUUm9SQytSeURU?=
 =?utf-8?B?VUhVeG9tcHJYNCszb0l1K2tmcUVJQWR2UmtOVlFxc2tCYzJMZnZTQ3dRdENt?=
 =?utf-8?B?cUMzV0t4QVJJZ0FPVkdtZHlCbmlpQ0tyOFUzckdZSE5oQ3k2Zlk0ak43KzFk?=
 =?utf-8?B?azdXVDJLb0FjdmFxN2EzYXpJTGhQeDltTVpDaUpTQnB1NVRpOHNCNXpPR1VO?=
 =?utf-8?B?dkhaSWo5cFBrTFJaTEhwS1EyN0FiSFkxNGgvVVVRbkZvbTZsZ2tRVlRCVC9R?=
 =?utf-8?B?dlY4anV0NWIzczBiQkN1eWpDcHBiVVV1QW5WSFZQbnR5bE02NkZtY1RNT1U0?=
 =?utf-8?B?bkVobnpQRlhBWllNS05tY0pYcW1FRldTQWp4aDFoNzNsMjVTTHR5RU1SdENl?=
 =?utf-8?B?OVl6alJmTWNJa09SVkJadGRJNzBkdFB5RkxIbjRCcW5FeGI1aHJDVWw2MGRD?=
 =?utf-8?B?VGtuekdob3pTS0t0WXdZb2M0U1A1ZEJ6YzY2L1FNWUp5Wlo5UEhqdzcrRUdo?=
 =?utf-8?B?UnMrajVoVTJCRjZkbEpta21Qa1ZTUVZlYjdaVCs5Q1Zpb0tSSWxiR0Foenky?=
 =?utf-8?Q?1VRW06t1Nq38/tmzrXlT3xLGcKbe4Pza/OWXAQ0?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a20508e8-c664-4979-c2d2-08d9744ca0e1
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2654.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2021 11:17:51.7121
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z0wgg3zsYD/55dMqwyCobabXbSFfGBev89J67r5DmD4exmTaX8v56sT6/4TWJW1gaLYLrJPa2hUEX2t34mL0jw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4400
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>> +static bool x86__ins_is_fused(struct arch *arch, const char *ins1,
>> +			      const char *ins2)
>> +{
>> +	if (strstarts(arch->vendor, "AuthenticAMD"))
>> +		return amd__ins_is_fused(arch, ins1, ins2);
>> +
>> +	return intel__ins_is_fused(arch, ins1, ins2);
>> +}
>> +
> 
> Can we instead make x86__ins_is_fused be a pointer and instead of
> storing arch->vendor we set it to one of amd__ins_is_fused() or
> intel__ins_is_fused()?
> 
> I.e. here:
> 
>>  static int x86__cpuid_parse(struct arch *arch, char *cpuid)
>>  {
>>  	unsigned int family, model, stepping;
>> @@ -184,6 +216,9 @@ static int x86__cpuid_parse(struct arch *arch, char *cpuid)
>>  	if (ret == 3) {
>>  		arch->family = family;
>>  		arch->model = model;
>> +		arch->vendor = strndup(cpuid, 12);
> 
> 		x86__ins_is_fused = strstarts(cpuid, "AuthenticAMD") ?
> 					amd__ins_is_fused :
> 					intel__ins_is_fused;

Sure. Will post v2.

Thanks for the review Arnaldo,
Ravi