Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: [PATCH 1/1] scripts/checkpatch.pl: remove warning for
 pritk_deferred also
Reply-To: maninder1.s@samsung.com
Sender: Maninder Singh <maninder1.s@samsung.com>
From:   Maninder Singh <maninder1.s@samsung.com>
To:     Andy Whitcroft <apw@canonical.com>
CC:     "joe@perches.com" <joe@perches.com>,
        "dwaipayanray1@gmail.com" <dwaipayanray1@gmail.com>,
        "lukas.bulwahn@gmail.com" <lukas.bulwahn@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        AMIT SAHRAWAT <a.sahrawat@samsung.com>,
        Vaneet Narang <v.narang@samsung.com>
In-Reply-To: <YTZ22IfeYanMEMpH@brain>
Message-ID: <20210910124532epcms5p3b63de3ee7ae2511817cb106c55a74946@epcms5p3>
Date:   Fri, 10 Sep 2021 18:15:32 +0530
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <YTZ22IfeYanMEMpH@brain>
        <1629786900-4644-1-git-send-email-maninder1.s@samsung.com>
        <CGME20210824063513epcas5p46ba8b375c3e32fab210640a28041efb6@epcms5p3>
Precedence: bulk

Hi,


>It looks sensible to add `_deferred`, there also looks to be an
>`_deferred_once` variant which should also be added.  See the first
>stanza of `$logFunctions`.  We might also consider splitting up
>`$logFunctions` so that we can consume the reset without that first
>stanza?  Something like this (completly untested):
>
>    our $logFunctionsCore = qr{(?x:
>        (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
>        TP_printk|
>        WARN(?:_RATELIMIT|_ONCE|)|
>        panic|
>        MODULE_[A-Z_]+|
>        seq_vprintf|seq_printf|seq_puts
>    )};
>    our $logFunctions = qr{(?x:
>        printk(?:_ratelimited|_once|_deferred_once|_deferred|)|
>	$logFunctionsCore
>    )};
>


sent V2 patch with testing basic checks:

https://lkml.org/lkml/2021/9/7/329

$ cat test.c


printk_deferred(KERN_ALERT "checking deferred\n");
printk_deferred_once(KERN_ALERT "checking deferred\n");
printk(KERN_ERR"error");
pr_emerg("Protocol: %#06hx\n", ntohs(eth->h_proto));
printk_deferred(KERN_ALERT "Protocol: %#06hx\n", ntohs(eth->h_proto));


WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
#22: FILE: test.c:22:
+printk(KERN_ERR"error");

WARNING: Integer promotion: Using 'h' in '%#06hx' is unnecessary
#23: FILE: test.c:23:
+pr_emerg("Protocol: %#06hx\n", ntohs(eth->h_proto));

WARNING: Integer promotion: Using 'h' in '%#06hx' is unnecessary
#24: FILE: test.c:24:
+printk_deferred(KERN_ALERT "Protocol: %#06hx\n", ntohs(eth->h_proto));


Thanks,
Maninder Singh