Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 10 Sep 2021 11:19:02 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Ravi Bangoria <ravi.bangoria@amd.com>
Cc:     mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        jolsa@redhat.com, yao.jin@linux.intel.com, namhyung@kernel.org,
        kim.phillips@amd.com, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] perf annotate: Add fusion logic for AMD microarchs
Message-ID: <YTtpVpo3d/h5YkVc@kernel.org>
References: <20210906105640.1040-1-ravi.bangoria@amd.com>
 <20210906105640.1040-2-ravi.bangoria@amd.com>
 <YTpveO0qqKFTaxTk@kernel.org>
 <6a987cad-6c46-280e-f791-6c59b6628a45@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6a987cad-6c46-280e-f791-6c59b6628a45@amd.com>
Precedence: bulk

Em Fri, Sep 10, 2021 at 04:47:31PM +0530, Ravi Bangoria escreveu:
> 
> >> +static bool x86__ins_is_fused(struct arch *arch, const char *ins1,
> >> +			      const char *ins2)
> >> +{
> >> +	if (strstarts(arch->vendor, "AuthenticAMD"))
> >> +		return amd__ins_is_fused(arch, ins1, ins2);
> >> +
> >> +	return intel__ins_is_fused(arch, ins1, ins2);
> >> +}
> >> +
> > 
> > Can we instead make x86__ins_is_fused be a pointer and instead of
> > storing arch->vendor we set it to one of amd__ins_is_fused() or
> > intel__ins_is_fused()?
> > 
> > I.e. here:
> > 
> >>  static int x86__cpuid_parse(struct arch *arch, char *cpuid)
> >>  {
> >>  	unsigned int family, model, stepping;
> >> @@ -184,6 +216,9 @@ static int x86__cpuid_parse(struct arch *arch, char *cpuid)
> >>  	if (ret == 3) {
> >>  		arch->family = family;
> >>  		arch->model = model;
> >> +		arch->vendor = strndup(cpuid, 12);
> > 
> > 		x86__ins_is_fused = strstarts(cpuid, "AuthenticAMD") ?
> > 					amd__ins_is_fused :
> > 					intel__ins_is_fused;
> 
> Sure. Will post v2.

Thanks, if you're quick we may get this into this merge window :-)

> Thanks for the review Arnaldo,

- Arnaldo