Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 04/15] block: Add block device LED trigger integrations
To:     =?UTF-8?Q?Marek_Beh=c3=ban?= <kabel@kernel.org>
Cc:     axboe@kernel.dk, pavel@ucw.cz, linux-leds@vger.kernel.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org
References: <20210909222513.2184795-1-arequipeno@gmail.com>
 <20210909222513.2184795-5-arequipeno@gmail.com>
 <20210910032319.71b843d7@thinkpad>
From:   Ian Pilcher <arequipeno@gmail.com>
Message-ID: <4b40f4fc-4baf-c75f-e61f-310fe6d15e0c@gmail.com>
Date:   Fri, 10 Sep 2021 10:00:23 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210910032319.71b843d7@thinkpad>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9/9/21 8:23 PM, Marek Behún wrote:
> On Thu,  9 Sep 2021 17:25:02 -0500
> Ian Pilcher <arequipeno@gmail.com> wrote:
>> Call ledtrig_blkdev_disk_init() from device_add_disk() to ensure that
>> ledtrig is initialized to NULL, in case a driver allocates the structure
>> itself and doesn't use kzalloc()
> 
> No, this is not needed. If someone does not use kzalloc(), they should
> use it. No need to fix other code here.

Yeah.  I'm honestly not sure if this is necessary or not, as I don't
know if there are any drivers that actually have this problem.  I
decided to include this for now, because an uninitialized pointer can
cause memory corruption, etc., when the disk cleanup function follows a
garbage pointer.

This recent commit seems to indicate that until recently drivers were
responsible for doing gendisk allocation.

> commit f525464a8000f092c20b00eead3eaa9d849c599e
> Author: Christoph Hellwig <hch@lst.de>
> Date:   Fri May 21 07:50:55 2021 +0200
> 
>     block: add blk_alloc_disk and blk_cleanup_disk APIs
>     
>     Add two new APIs to allocate and free a gendisk including the
>     request_queue for use with BIO based drivers.  This is to avoid
>     boilerplate code in drivers.

Were those drivers expected to use kzalloc() or otherwise zero out the
entire structure?  I really don't know.

I think that it makes sense to defer to the block subsystem maintainers
on this question.

-- 
========================================================================
                  In Soviet Russia, Google searches you!
========================================================================