Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 10 Sep 2021 11:12:18 -0500
From:   Rob Herring <robh@kernel.org>
To:     Saravana Kannan <saravanak@google.com>
Cc:     Andre Muller <andre.muller@web.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>, kernel-team@android.com,
        devicetree@vger.kernel.org
Subject: Re: [PATCH] of: property: Disable fw_devlink DT support for X86
Message-ID: <YTuD4vxkklqLNOyd@robh.at.kernel.org>
References: <20210910011446.3208894-1-saravanak@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210910011446.3208894-1-saravanak@google.com>
Precedence: bulk

On Thu, 09 Sep 2021 18:14:45 -0700, Saravana Kannan wrote:
> Andre reported fw_devlink=on breaking OLPC XO-1.5 [1].
> 
> OLPC XO-1.5 is an X86 system that uses a mix of ACPI and OF to populate
> devices. The root cause seems to be ISA devices not setting their fwnode
> field. But trying to figure out how to fix that doesn't seem worth the
> trouble because the OLPC devicetree is very sparse/limited and fw_devlink
> only adds the links causing this issue. Considering that there aren't many
> users of OF in an X86 system, simply fw_devlink DT support for X86.
> 
> [1] - https://lore.kernel.org/lkml/3c1f2473-92ad-bfc4-258e-a5a08ad73dd0@web.de/
> Fixes: ea718c699055 ("Revert "Revert "driver core: Set fw_devlink=on by default""")
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> Cc: Andre Muller <andre.muller@web.de>
> ---
>  drivers/of/property.c | 3 +++
>  1 file changed, 3 insertions(+)
> 

Applied, thanks!