Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Guenter Roeck <linux@roeck-us.net>
CC:     "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bart Van Assche <bvanassche@acm.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Bean Huo <beanhuo@micron.com>
Subject: RE: [PATCH v2 1/2] scsi: ufs: Probe for temperature notification
 support
Thread-Topic: [PATCH v2 1/2] scsi: ufs: Probe for temperature notification
 support
Thread-Index: AQHXpUTh8Dhuh0oH5EaZbJTkdwCAEaub62iAgAGEpIA=
Date:   Fri, 10 Sep 2021 16:13:43 +0000
Message-ID: <DM6PR04MB657592A71CA6394C409788B3FCD69@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20210909063444.22407-1-avri.altman@wdc.com>
 <20210909063444.22407-2-avri.altman@wdc.com>
 <20210909165145.GA3973437@roeck-us.net>
In-Reply-To: <20210909165145.GA3973437@roeck-us.net>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qzfrQEsSmYAknT0XbUeSf+sOTyZZf95NkOxiEiDi9ExFhUzcHdP3rXO+n+9G?=
 =?us-ascii?Q?5s+o3waz/cbrB7UKnFGzRNvLQtR1+Y2BDdVYIX+7nJYIULHwxY1Nza+nfKP4?=
 =?us-ascii?Q?Jz3YXfqqAT2MtYL665zvCQn8gOl07JepvGGyg/RWAwLwLKXyQLYevylNuOjC?=
 =?us-ascii?Q?Wr/P2XhZ5dv0Jbwhc5o0Z/5gS5ESoy/N6VrgbNAu8b/fvaRki9dmERDG3/oC?=
 =?us-ascii?Q?YwsV8j3PvnZufhZVd5o98sGMnFUTdgSQgmcVi38NIJNvr9VXt9c/lj7LnRmB?=
 =?us-ascii?Q?62hXSE9iEXBMpgLCzmHDVFq9PmUtRq/g/yeKEPMFMANUpAaMPZbBMZi7Cm/Z?=
 =?us-ascii?Q?OuPJRb9JvUCwBW+wL29UuV6XQP78hc5tz0eJpk7yCQzNSYP1KGMKRtk+CpTP?=
 =?us-ascii?Q?YlPLPZKr2nibrqI1dtOQ0DFCHjVqojA3Q4Hb3YRGrlCacDRgl+dUenUTetZs?=
 =?us-ascii?Q?HNMqwrIPBJCWtvFz2+2j0tMdC2N28dJopREFjf4eOEQbhcOJCs7ZpdONE4BV?=
 =?us-ascii?Q?qCwauJBjqotw3FIPopeAXJUg0q/ccE3OLXuPTpci2+V5ugLMgWexrKYMwbkn?=
 =?us-ascii?Q?eIcBWEG++ANPstFs2n7KNyq3sH9ZV3/OcZeeDSL6iF0PI8MH2/YjK3GTXoQJ?=
 =?us-ascii?Q?wVFGM3h5hLRALCXZcX3/kBDSjstY8PPZvyPo7sMe6SptL3VuCphKkakZTc1e?=
 =?us-ascii?Q?v47NcMJLUNpxHbrZpObVkstWlyHSP3DCe76oS72uso748afQTYNeMfBLdwoO?=
 =?us-ascii?Q?7OJRL+4A9cAbTmk1VSSNZE1tYNTf7+fr1QuWYq/E7GlUJWmPknzCm6/LRRT0?=
 =?us-ascii?Q?9vuq9Bjwc7WMLyGQD8aqQ6EJt3pqnr9nBh88jjZn4dOZFfVBhGS/n3LenGVl?=
 =?us-ascii?Q?vKO4GWN0QlqwSZ0PIKnRMuzdJNQn4DbeXlSukPAqrIG2z7Hd+KJO0UI5E8Ta?=
 =?us-ascii?Q?QHPoIUhNDUyp4GiOPeAIoFxxoQinFn+dRlYazLQlhbcx4aIGeFCGkTnpHvGJ?=
 =?us-ascii?Q?5oin23ZPtB7nEZRtNZLQL+bNLvhIyO00z0in9azmgLaC99b5ipByYqUYTQS/?=
 =?us-ascii?Q?rCIBAAQHXi8TX2pB2G+h2SW+OxHmPasnZs1u4pRyK8mMAKgJ3lxtWCuy1V0t?=
 =?us-ascii?Q?Ghn6tworwbGuGbsf+Lr0+JW6r2LVxJKtjYKnD4N03srSuc01VKy99l3JMzLU?=
 =?us-ascii?Q?t4MuB+VG92Q3zCy9IZgg+5qiJGfP+WrLESFVzjhKChVWMmKD2EGPiyrV8/5I?=
 =?us-ascii?Q?uVX2i041sCE2SwjXKePbZkWwK1LC0C4X3sjYlQSepQH2X5W7wH7csX5gFA4/?=
 =?us-ascii?Q?6b6rP/ZGYVqdm8MAC1pF/4k0?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e34c60c-4f80-45a9-4874-08d97475f5d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Sep 2021 16:13:43.2923
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jCjIwFgu6/+T+3TpqgdzDnGms8wlo3vLSGljwHqCRqQXYFqjQvFNWoRASyRPyX/+qh1MFrc82sAlGlVdXTCxtQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6510
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +     if (IS_ERR(hwmon)) {
> > +             dev_warn(dev, "Failed to instantiate hwmon device\n");
> > +             kfree(data);
> > +             return PTR_ERR(hwmon);
>=20
> If the error is ignored by the caller, it doesn't make sense to return it=
.
Done.

>=20
> > +     }
> > +
> > +     hba->hwmon_device =3D hwmon;
> > +
> > +     return 0;
> > +}
> > +
> > +void ufs_hwmon_remove(struct ufs_hba *hba) {
> > +     if (hba->hwmon_device) {
> > +             struct ufs_hwmon_data *data =3D
> > +                     dev_get_drvdata(hba->hwmon_device);
> > +
> > +             hwmon_device_unregister(hba->hwmon_device);
> > +             hba->hwmon_device =3D NULL;
> > +             kfree(data);
> > +     }
> > +}
>=20
> That function is never called and thus pointless (suggesting that there m=
ay
> be some structural problem in the code).
Yayks... Forgot to call it from ufshcd_remve()
Thanks.

> >
> >       ufshcd_wb_probe(hba, desc_buf);
> >
> > +     ufshcd_temp_notif_probe(hba, desc_buf);
> > +
>=20
> Is that the appropriate place to make this call ?
Yes I think so.
This path is on link startup when the host reads the device configuration.

> > +#ifdef CONFIG_SCSI_UFS_HWMON
> > +int ufs_hwmon_probe(struct ufs_hba *hba, u8 mask); void
> > +ufs_hwmon_remove(struct ufs_hba *hba); #else static inline int
> > +ufs_hwmon_probe(struct ufs_hba *hba, u8 mask) { return 0; } static
> > +inline void nvme_hwmon_remove(struct ufs_hba *hba) {}
>=20
> ufs_hwmon_remove
Done. Thanks.