Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 10/15] leds: trigger: blkdev: Add LED trigger activate
 function
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     axboe@kernel.dk, pavel@ucw.cz, linux-leds@vger.kernel.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        kabel@kernel.org
References: <20210909222513.2184795-1-arequipeno@gmail.com>
 <20210909222513.2184795-11-arequipeno@gmail.com> <YTr/iQBYclqjFri2@kroah.com>
From:   Ian Pilcher <arequipeno@gmail.com>
Message-ID: <8ef9f5c7-ce5c-26ce-b076-35716a15fed8@gmail.com>
Date:   Fri, 10 Sep 2021 11:10:28 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <YTr/iQBYclqjFri2@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/10/21 1:47 AM, Greg KH wrote:
>> +	/* Don't allow module to be removed while any LEDs are linked */
>> +	if (WARN_ON(!try_module_get(THIS_MODULE))) {
> 
> That pattern is racy and broken and never ever ever add it to the kernel
> again please.  All existing in-kernel users of it are also wrong, we
> have been removing them for decades now.

OK.  (I was misled by the instances that you haven't gotten to yet.)

> You have created a "raw" kobject in the device tree now, which means
> that userspace will not be notified of it and will have a "hole" in it's
> knowledge.  Why not just create a named attribute group to this device
> instead?

What would I pass as the first argument to sysfs_create_link() in that
case?

-- 
========================================================================
                  In Soviet Russia, Google searches you!
========================================================================