Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp1645579pxb; Fri, 10 Sep 2021 10:21:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFRP8E5It36HKfsicnNAMnGwVbfJVjf0ydzYGLeEDrwA+ThP1ozKrKHISGepqDUd5zkg22 X-Received: by 2002:a05:6402:40ca:: with SMTP id z10mr2418756edb.378.1631294499594; Fri, 10 Sep 2021 10:21:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631294499; cv=none; d=google.com; s=arc-20160816; b=wAI51KjwL9mJnc0kyQr6/pD/agGpet+RzQHlzGClk8rFpa9JaDhtTSL1Lfo3sGRD33 HqFpikTalycuBk/VlsXhD9qRKHyuRxQeaCo9fOmFcMtq8aeOyHN66Iz3xsx/xt8xGsME XyIVYRodEhRask2o/lWBX5oSf1/HhxtJNM3K6Pg1r3HCCWeNkhXssMk8yMIrv6Cus/QE L8PO4ErNVcyY9LkaR8Q84bFGnrwCtwprToxi5IdfPCtatxACrRBvmCMxWMX3h9FZoFQN fQXOjMZlCBP/9URN4A6NlRfiayXitQTl97PN0o/OdUhR6E+SROzrCS+THnRsBjpCa9Wz 9N4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=02ZeBZU29R1KVCqeFtK2ESzdkVxQ2Opf6evacdtFUxc=; b=fv1wdlF4NCYiiULZW9D/7MVeovXkLgUDLWxN0V0Bnk1IxTVvZ46xBEp8zVA3MBONOt Ar8PRMfO5K6w3IUIhJYBSYih25of6rt4PZSBBpH4l8YotLzlX+l7xUrvVfJssr7KsQHu tK26M30CA3WivKDdF/RwP8+QLS+1jFy3oP2hXjTJCjK9VCN6rv1xeGikswug8sROrNMS gRNlGWAcXmP1E3/z3t95TQ1ac7kQIDQdVULq8dMRpaqBhZhK+0Upd/PgpZGBt4g71ELi D2fBVh3q6rzBqGsy60McqV8hKmV+TqRgA3bt4wlARug1Ljr/pQqDSX22iu3gVLuUoeFX O5fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=jl8XqBWf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p4si5929933edt.283.2021.09.10.10.21.15; Fri, 10 Sep 2021 10:21:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=jl8XqBWf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231171AbhIJRU5 (ORCPT + 99 others); Fri, 10 Sep 2021 13:20:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229664AbhIJRU5 (ORCPT ); Fri, 10 Sep 2021 13:20:57 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00F1CC061574; Fri, 10 Sep 2021 10:19:46 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id v123so2431559pfb.11; Fri, 10 Sep 2021 10:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=02ZeBZU29R1KVCqeFtK2ESzdkVxQ2Opf6evacdtFUxc=; b=jl8XqBWfp5XyTB7oUD+ZWxcBGzhuAaxwldfYoiqmwmuu7Q0tAtyjae8AMreWOPvW0s utgdOKweJtvVQcMTuQ860R6K3q7BZQo0LJTzsQVnaQvtYdiETNccC5381EUxPVRlJlA6 jPx4X7/7G8WVSG0iCUHBUCEUsDbi4iT0tEMDPmmuyWch7/8OgT3uCyodv2A7qlFXBLY+ /bM/jU2Uo3q/m02kK2akuucklj/Utk2fFTD5NhE2h9E4qrhZdZ4QKIHqwOTF0lQIjUAL kRpdxSfJqTzxYKGCgk3MimG/MHNoTxEHF8ARtzieLsNFAMi8d3kqQYWjgrr4zftGIHr5 jBog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=02ZeBZU29R1KVCqeFtK2ESzdkVxQ2Opf6evacdtFUxc=; b=U3Ll7RlflB9kOdjU1b3Jebch8F1oi2XLEqVCvcFei/d4E7Y08capYJTATvoY66D/6d kHBoOnGP/sW05YzLL2OWIGp2XoIg7l1xRBmKQ52YanjKE1VjN2zBgGDk997zin+WTFrT 0Vz6pRECk/1tdBuZUpQFdqMTafhtBza18vKDCFlVWE/+Gjznpi4XP7doj7BU8zGbNCvk AAhB135edg/yLfxYksqKExAoFYsyH3vchOFmZr2IQB1SQgrPsRCd2hjdvx7iUWA0VyVK MNnlr/IfGaA0zknuMOzdBZXRXSpQH8Crw0J87FMZBCc3TFgpPzS+1tIFe4bQ0k/tOjWk vhYw== X-Gm-Message-State: AOAM531LkIoDDvNSYusdVh+XinEQSxxxR/aD9iESS2vqIL/cxX2DHYnm HzoKHU18FDJhxOH1Y88+cbI= X-Received: by 2002:a63:4b53:: with SMTP id k19mr8040709pgl.3.1631294385294; Fri, 10 Sep 2021 10:19:45 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-e24f-43ff-fee6-449f.res6.spectrum.com. [2603:800c:1a02:1bae:e24f:43ff:fee6:449f]) by smtp.gmail.com with ESMTPSA id n22sm5455331pff.57.2021.09.10.10.19.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Sep 2021 10:19:44 -0700 (PDT) Sender: Tejun Heo Date: Fri, 10 Sep 2021 07:19:43 -1000 From: Tejun Heo To: Vipin Sharma Cc: Michal =?iso-8859-1?Q?Koutn=FD?= , "brookxu.cn" , lizefan.x@bytedance.com, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [RFC PATCH 3/3] misc_cgroup: remove error log to avoid log flood Message-ID: References: <86e89df640f2b4a65dd77bdbab8152fa8e8f5bf1.1631077837.git.brookxu@tencent.com> <20210909143720.GA14709@blackbody.suse.cz> <478e986c-bc69-62b8-936e-5b075f9270b4@gmail.com> <20210910092310.GA18084@blackbody.suse.cz> <1679f995-5a6f-11b8-7870-54318db07d0d@gmail.com> <20210910153609.GC24156@blackbody.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Fri, Sep 10, 2021 at 10:16:46AM -0700, Vipin Sharma wrote: > For now, I think we can just have one file, events.local > (non-hierarchical) which has %s.max type entries. This will tell us > which cgroup is under pressure and I believe this is helpful. How about just sticking with hierarchical events? Do you see a lot of downsides with that compared to .local? Thanks. -- tejun