Date: Sun, 10 Dec 2006 13:55:04 -0800
From: Mitchell Blank Jr <mitch@sfgoth.com>
To: Folkert van Heusden <folkert@vanheusden.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: optimalisation for strlcpy (lib/string.c)
Message-ID: <20061210215504.GD47959@gaz.sfgoth.com>
References: <20061210212350.GC30197@vanheusden.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20061210212350.GC30197@vanheusden.com>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 569
Lines: 14

Folkert van Heusden wrote:
> Like the other patch (by that other person), I think it is faster to not
> do a strlen first.

Debatable.  You've replaced a call to the highly-optimized memcpy function
with a byte-by-byte copy.  It's probably a wash performance wise (have you
benchmarked?) and is certainly less clear.

-Mitch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/