Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 10 Sep 2021 15:03:26 -0400
From:   Daniel Jordan <daniel.m.jordan@oracle.com>
To:     Andrey Ryabinin <arbn@yandex-team.com>
Cc:     Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
        bharata@linux.vnet.ibm.com, boris@bur.io, stable@vger.kernel.org
Subject: Re: [PATCH v2 4/5] sched/cpuacct: fix user/system in shown
 cpuacct.usage*
Message-ID: <20210910190326.nwv7kktt42nucoit@oracle.com>
References: <20210217120004.7984-1-arbn@yandex-team.com>
 <20210820094005.20596-1-arbn@yandex-team.com>
 <20210820094005.20596-4-arbn@yandex-team.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210820094005.20596-4-arbn@yandex-team.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bbV+WYwdsh94VqmgXnYDQFIj5nbulC0ARDD2yC5piMDa4Jb5stCm/c59cKrO?=
 =?us-ascii?Q?yI8Ii31oPoNuXF1sG4w+Qj3FLy6uYk7xdhaG9X6EVvShhi04BDT3PIokMA43?=
 =?us-ascii?Q?FI8eSld1UkBIrb/7cnQHw+k2UDRgLJYeCsC0crMG4JHxB4RGekx1PwauURA7?=
 =?us-ascii?Q?3FapPdCEiFMQLvXW9B30dJXq4lbJNsiaDmLzPqnqu5SSPmt6lmEFUQSa08l/?=
 =?us-ascii?Q?rgNM2g0ONBGe5EYjiimOV9uS+v2WPO7aZycAL5oNEibv/TgiQIr2j6zU9liU?=
 =?us-ascii?Q?Rki+8y1oilbyubJ9PXIqpaIyjRupY9hFS3zsm2vIbkkBnKSwCWU+sq+lEkvi?=
 =?us-ascii?Q?baX8d3dg1labY8i6vDRlw981Bkl2/qbPUs3/mCQQg+fqu6Xwt2ly9CE83fgk?=
 =?us-ascii?Q?nHbAU+Plq7MX/PdJnsRVi9oDi61/5icRHaPyxcqatxyYYcqTFSvxqCUHP/ci?=
 =?us-ascii?Q?2OjxyIU2n5B068sIXTkd2pYKoI2RuflAL36jAPpP4S8Dwjjujd3vxTX5nPaS?=
 =?us-ascii?Q?u4lMZCYZ2vmi6xS8CsQjbh8KMEVsWpAT8rFjUwHKTLoEnJ5FIsELvSzRwUTq?=
 =?us-ascii?Q?KV6A8yRZt43Ax7QKtyWMDppgrg0yH8M7PQUo+qwYe6QOPkzjp8poypvBh0Ul?=
 =?us-ascii?Q?QiF8xhXcZAUzwcxx9aHP4Z+RZf9N67FFKX94Of8CHV4h/5QaECVuq4T3283L?=
 =?us-ascii?Q?h5WFzEU85afnWvkqhtld51OHbxwV34kM7r53lpgfx5siVCyCveH1Qcr/L8P0?=
 =?us-ascii?Q?3Z0ROHXJxEN1Zn8lCnntliuluSo4UcJXmbHv6EOEUGgODEnwG4QRVm1yO5+q?=
 =?us-ascii?Q?k4Sfh5I5ginUbkLbId87mT9HoHc8iGIzgs8DlmKuwhO5HbIrXAGatkABR7s2?=
 =?us-ascii?Q?ichtIeojbyAj/HjS5hWobWzUDxKj43Kl+5aPByjng5sFKnKQPlnFwtzyadek?=
 =?us-ascii?Q?ydWi883mDv84tH2rgRPB8I4FY3F315C4+5rNqEX9hfc6rl9FhzaRZmkWcHo5?=
 =?us-ascii?Q?HRmhwFEqNfWdIZcPEcVhBGj6nbIqmZZOFidbYKsdGhbyFQetizkQNLsCNJiT?=
 =?us-ascii?Q?pSv3bQ6PrtPEx5VykcSs1ssGlFnTauA9ZZau2ebCs8duqplIpkEyRtXPZbmH?=
 =?us-ascii?Q?eUV3jM47BrNHV8HFuKY3WYlNjHQOtYUzP1aU/cYa9TkSb04WMc0ByOvIVm3B?=
 =?us-ascii?Q?PKGzZ8pzly0z8xG9XW1MEEjKgHvoZM9GGzp1uZ7A43i1YEwgXbj03SNlQN/c?=
 =?us-ascii?Q?qudKygy0MSX+XuD31JHq/S93HNalboTqxN19CIpBk7zHSgclYsmiI6RMJXJz?=
 =?us-ascii?Q?kcdqcDYn34Xo73ZhZqGoBjMP?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 736f820e-e5ec-4468-f863-08d9748dae20
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2966.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2021 19:03:31.1822
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UaL02+ckm2CYAQ42fVgX5VgX6oTFRtzgDiJscEsg6uCqk/9dAF8cX18ihVhgUvRY5kgbC/36Dcx5Jzi62qlNmWlD2QVv8YDpUSQRWL9cRdI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4386
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10103 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 bulkscore=0
 suspectscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001
 definitions=main-2109100110
X-Proofpoint-GUID: x1pMJYLwp1wlDtPqn5XpY_6eoolRfD2Y
X-Proofpoint-ORIG-GUID: x1pMJYLwp1wlDtPqn5XpY_6eoolRfD2Y
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 20, 2021 at 12:40:04PM +0300, Andrey Ryabinin wrote:
> cpuacct has 2 different ways of accounting and showing user
> and system times.
> 
> The first one uses cpuacct_account_field() to account times
> and cpuacct.stat file to expose them. And this one seems to work ok.
> 
> The second one is uses cpuacct_charge() function for accounting and
> set of cpuacct.usage* files to show times. Despite some attempts to
> fix it in the past it still doesn't work. Sometimes while running KVM
> guest the cpuacct_charge() accounts most of the guest time as
> system time. This doesn't match with user&system times shown in
> cpuacct.stat or proc/<pid>/stat.
> 
> Demonstration:
>  # git clone https://github.com/aryabinin/kvmsample
>  # make
>  # mkdir /sys/fs/cgroup/cpuacct/test
>  # echo $$ > /sys/fs/cgroup/cpuacct/test/tasks
>  # ./kvmsample &
>  # for i in {1..5}; do cat /sys/fs/cgroup/cpuacct/test/cpuacct.usage_sys; sleep 1; done
>  1976535645
>  2979839428
>  3979832704
>  4983603153
>  5983604157

Thanks for expanding on this, and fixing broken cpuacct_charge.

For the series,
Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>