Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     bpf <bpf@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "acme@kernel.org" <acme@kernel.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "kjain@linux.ibm.com" <kjain@linux.ibm.com>,
        Kernel Team <Kernel-team@fb.com>,
        Andrii Nakryiko <andrii@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>
Subject: Re: [PATCH v7 bpf-next 3/3] selftests/bpf: add test for
 bpf_get_branch_snapshot
Thread-Topic: [PATCH v7 bpf-next 3/3] selftests/bpf: add test for
 bpf_get_branch_snapshot
Thread-Index: AQHXpnJ5DR84tw2uP0+VcILLi5UcKKudntGAgAABrYA=
Date:   Fri, 10 Sep 2021 19:04:36 +0000
Message-ID: <931A149F-6CBA-4D4C-8A90-134448AF878F@fb.com>
References: <20210910183352.3151445-1-songliubraving@fb.com>
 <20210910183352.3151445-4-songliubraving@fb.com>
 <20210910185835.GR4323@worktop.programming.kicks-ass.net>
In-Reply-To: <20210910185835.GR4323@worktop.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Mq4Gl//LK1tqeyDCm2mH1KyPQsM+0VjW8NLzb+SYyBy1PFse74zTVvqS4tnN?=
 =?us-ascii?Q?gI/MLtuZBrm+O5lbe0O/PCqFphuo6s5GO7f2C2bdFlr2sK1StDpooWgMY87H?=
 =?us-ascii?Q?4XMGw1dtDEV4ty5qmcZp1OjcqRNeFx3Xtc2QDrCQ/uE/fdczgr33/7dmUKDY?=
 =?us-ascii?Q?TFkFmSzXAQqCz5TeU/VQaE61ehOOFxV+I5TSs4jDQ0VsjOEdZRhDsXCCl3pj?=
 =?us-ascii?Q?enI7i/pQbd5F9uWAkhxvM9nMGeThw/PPBEf3sSH0TUVkw8rvvU9UaneXiZrU?=
 =?us-ascii?Q?0LbZ0EOoIqKfF0tIxvfh4FQZrxOaRM6arcg4CXLCQvezeLqua3Pj9S9TPqkO?=
 =?us-ascii?Q?6/y3q9G13IVMyo3Otxj27LyspufxZ1HAir5xnizku1SPG7/EQu8a5IeszejF?=
 =?us-ascii?Q?O2mGKEfgf6pAQI3kbMpEmdvr1ByHRY/uiDsq2CIvswvXv3V1uApoDwN7MHPv?=
 =?us-ascii?Q?I+hO8KYlv+21CoRFAMrwtJ3Y5kRz5m4OAQFThWnT90pvv6D4R91qS+PanAAg?=
 =?us-ascii?Q?9xNe9C7hAnVLLIi9DqioAlcv249mxnU0Gh2+lZby1LJeEd+rizyqgHvb5WJ7?=
 =?us-ascii?Q?aFxpOkjlb86gvfslFDS3CwaZVzOnv2Nyrp1ThY9Au27kMy6Q4bMhjlPzx6Kj?=
 =?us-ascii?Q?I7Un10XC7j2HznaU7+TsAmn1wFhhEWs1xcSFiu8YRNKITsDAiALK7j5lZvM9?=
 =?us-ascii?Q?8ZBMKX6ZK3RD63ZNoOKZFTx5FvRQNnkFYZy4Ifrt1+tJpeVnqcf/zW2hxQtc?=
 =?us-ascii?Q?AXvC1wyDFfWQqE2LPqnzaiJl9NAc929GYiQZQ0AcjaSkN9w+vs8vxF9+rNBm?=
 =?us-ascii?Q?7oOR1oyZqiN5O76AXWOns/U++jjSnFTdGhJCLQPOgE8vdIoeF8uX++CmPJi+?=
 =?us-ascii?Q?TBOy4FlB14N3dnY20wzr8S/+M5lckdkir0gNzxAAVDFsL2vBefj6jUCClDED?=
 =?us-ascii?Q?s3zx5kDqFSZWtanLukVZ0OqriUOlEuskdJYKkQva3tyJbqp3ckERCy9zF2QG?=
 =?us-ascii?Q?V8Z5jEQ/TMpz/E/+J8CVJZlg5HIbyLAeBFOItAXb6StVH/ofYYWLzE91zOsm?=
 =?us-ascii?Q?PW0C6Z/L/PPJlEuqtvfRHw2+2BMP/+1P3NxC4NA9JUmKOmje/VyropbYnPo2?=
 =?us-ascii?Q?q4Om6kriigINMF9/00MWbJRxtpD7iIagR7gjCT4+uyfs0D41pFgdVuyORYr0?=
 =?us-ascii?Q?Uu6nEwm5w3NjVHBkazgbGCr3u/EnKR4n/cyjz7usxPwxHyP5Ge2nPxwFr/4w?=
 =?us-ascii?Q?HqOPOSQPZhYLr4sRBxUnfDnSz6Z0mSuksr8u+kS6i9jyU6yKXdc3TAiPQ+Pg?=
 =?us-ascii?Q?t7se5ZRiysw+imUWYaIfBh84squ0ZlFjr94/bPyTaztWJommWktn3dlBlKRu?=
 =?us-ascii?Q?VBoQX/s=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <707AE55B13E5E744916A99029F553787@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82bda960-06d1-4eef-a358-08d9748dd574
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Sep 2021 19:04:36.8559
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NlFZs7toqpMMv7jGFbrKLZ4leovHe3rBDQ/uxWOXzHKY2lkjCNtsVza/fvNZHA1H/e7gTaBsm0mqoJg7RGzgew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR15MB5077
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: CzYDznqDm4VtYT24MbFR8mzVck4FRnIr
X-Proofpoint-ORIG-GUID: CzYDznqDm4VtYT24MbFR8mzVck4FRnIr
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-09-10_07:2021-09-09,2021-09-10 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 phishscore=0
 priorityscore=1501 lowpriorityscore=0 suspectscore=0 spamscore=0
 mlxlogscore=978 malwarescore=0 impostorscore=0 adultscore=0 clxscore=1015
 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109030001 definitions=main-2109100110
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Sep 10, 2021, at 11:58 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> 
> On Fri, Sep 10, 2021 at 11:33:52AM -0700, Song Liu wrote:
>> +	/* Given we stop LBR in software, we will waste a few entries.
>> +	 * But we should try to waste as few as possible entries. We are at
>> +	 * about 7 on x86_64 systems.
>> +	 * Add a check for < 10 so that we get heads-up when something
>> +	 * changes and wastes too many entries.
>> +	 */
>> +	ASSERT_LT(skel->bss->wasted_entries, 10, "check_wasted_entries");
> 
> It might be worth pointing out that you can easily bust this limit by
> enabling all the various tracepoints that are still in that code, but
> that that isn't a hard error since that's not the expected use case.
> 
> For example there's the wrmsr tracepoint that will inject 6 or so
> branches on top of that you now have. And I also think there's a
> tracepoint in local_irq_save() that can trigger.

Right. I did some test with a lot of debug config enabled. We do see a lot
more wasted entries there. 

Thanks,
Song