Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] dt-bindings: usb: atmel: add USB PHY type property
To:     cristian.birsan@microchip.com, stern@rowland.harvard.edu,
        gregkh@linuxfoundation.org, nicolas.ferre@microchip.com,
        ada@thorsis.com, alexandre.belloni@bootlin.com,
        ludovic.desroches@microchip.com
Cc:     linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20210910163842.1596407-1-cristian.birsan@microchip.com>
 <20210910163842.1596407-2-cristian.birsan@microchip.com>
From:   Sergei Shtylyov <sergei.shtylyov@gmail.com>
Message-ID: <55c75f95-6a14-7f05-c15c-64d4dbc1dee8@gmail.com>
Date:   Fri, 10 Sep 2021 22:07:21 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210910163842.1596407-2-cristian.birsan@microchip.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello!

On 9/10/21 7:38 PM, cristian.birsan@microchip.com wrote:

> From: Cristian Birsan <cristian.birsan@microchip.com>
> 
> Add USB PHY type property for controllers with HSIC support.
> 
> Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
> ---
>  Documentation/devicetree/bindings/usb/atmel-usb.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/atmel-usb.txt b/Documentation/devicetree/bindings/usb/atmel-usb.txt
> index a4002624ba14..f512f0290728 100644
> --- a/Documentation/devicetree/bindings/usb/atmel-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/atmel-usb.txt
> @@ -39,6 +39,10 @@ Required properties:
>  		"ehci_clk" for the peripheral clock
>  		"usb_clk" for the UTMI clock
>  
> +Optional properties:
> + - phy_type : For multi port host USB controllers, should be one of

   Hyphens are preferred to underscores in the property names.

> +   "utmi", or "hsic".
> +
>  usb1: ehci@800000 {
>  	compatible = "atmel,at91sam9g45-ehci", "usb-ehci";
>  	reg = <0x00800000 0x100000>;

MBR, Sergei