Date: Sun, 10 Dec 2006 14:14:35 -0800
From: Andrew Morton <akpm@osdl.org>
To: Paul Jackson <pj@sgi.com>
Cc: Jay Cliburn <jacliburn@bellsouth.net>, linux-kernel@vger.kernel.org,
       clameter@sgi.com
Subject: Re: [BUG] commit 3c517a61, slab: better fallback allocation
 behavior
Message-Id: <20061210141435.afac089d.akpm@osdl.org>
In-Reply-To: <20061210124907.60c4a0aa.pj@sgi.com>
References: <457C64C5.9030108@bellsouth.net>
	<20061210124907.60c4a0aa.pj@sgi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 967
Lines: 25

On Sun, 10 Dec 2006 12:49:07 -0800
Paul Jackson <pj@sgi.com> wrote:

> Good report - thanks.
> 
> Christoph - fallback_alloc() can be called with interrupts off.
> 
> I fixed the cpuset_zone_allowed() call from fallback_alloc() to avoid
> sleeping.  Notice the __GFP_HARDWALL added in Linus's version, or the
> new function cpuset_zone_allowed_hardwall() in Andrew's version, all
> done in the last week.
> 
> But apparently kmem_getpages() can also sleep, as it calls __alloc_pages().
> 

This is lame.  Please, always always test all new submissions with all the
nice kernel debugging options enabled.

They are summarised in Documentation/SubmitChecklist, along with a number
of other useful bug-prevention suggestions.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/