Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 09/15] leds: trigger: blkdev: Check devices for
 activity and blink LEDs
To:     =?UTF-8?Q?Marek_Beh=c3=ban?= <kabel@kernel.org>
Cc:     axboe@kernel.dk, pavel@ucw.cz, linux-leds@vger.kernel.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org
References: <20210909222513.2184795-1-arequipeno@gmail.com>
 <20210909222513.2184795-10-arequipeno@gmail.com>
 <20210910041713.4722760a@thinkpad>
 <77111c57-dfb5-44c6-c4e9-e18afb468b6e@gmail.com>
 <20210910171211.3c2236c3@thinkpad>
From:   Ian Pilcher <arequipeno@gmail.com>
Message-ID: <1e4986e2-53ba-9a0f-06d1-7cfb25d9f0e6@gmail.com>
Date:   Fri, 10 Sep 2021 16:23:02 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210910171211.3c2236c3@thinkpad>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9/10/21 10:12 AM, Marek Behún wrote:
> On Fri, 10 Sep 2021 10:09:09 -0500
> Ian Pilcher <arequipeno@gmail.com> wrote:
>> You can't add partitions, only whole devices.
> 
> But I should be able to, since partition is a block device in /dev.
> Any block device from /sys/class/block should be possible to add.

I wasn't aware that was something that you were interested in doing.
This will require working with the block_device structure rather than
the gendisk.

One possible benefit of this change ... Assuming that block_device
structures are always allocated by bdev_alloc() *and* I'm correct in
thinking that this means that they are always allocated from the inode
cache, then they are always zeroed out when allocated, so there won't
be any need to explicitly initialize the pointer.

-- 
========================================================================
                  In Soviet Russia, Google searches you!
========================================================================