Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp1808228pxb; Fri, 10 Sep 2021 14:42:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/dypORA+Xlwf6NvuBYxwUQI9/3hGD1w+nqZALbOrcG92h5xDRHbsSgVLoRm307b/eexvp X-Received: by 2002:a05:6e02:503:: with SMTP id d3mr8121564ils.107.1631310157348; Fri, 10 Sep 2021 14:42:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631310157; cv=none; d=google.com; s=arc-20160816; b=GyyjZ+pl5I6Ni/aULt/A98TCKmfe5V6CqYp6618PlzUnFw4zs5X0lOkkgyHLrAGhED E2k4hq9tY6/rfY7BOAIi4fyPgDf6OvuHm4j6Kl/VQXIbX64owA3y293y/jH8siRX4dIj DNULgALUh7+T0NC7iZ2DRiBj1/uBukpELTalGYdTPzboxWLUIbgDLhTY57s4EwxAlj/1 I1CGxqo3/YaQ5F3n5YxYhIGP0an5xpD2Ays9g6DniL1LQEOp2NfTyeLJNNh6eq/99Hm6 76FNj2bOCZWz9VBeNjxtbWZh6PKlrXIm++rx/4Vl7gI07uM0li8xicBS0b8tZiMZTgVC jRaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=leZ9gAJesxiaYyECvXAC95tfjrMi+xyfNBHPusNmXhc=; b=MLV3pB980vAhbtspR5E1MGsLgFX1FIMmeKIceOFFxkFarrcIEZtdGcrNc+jyjzc8jj 31RZbfmRvW2aVgVA71EWd9TJq0asC1DynQ0tNsugP5yBoMfI1cLVnxqN+u835xkIFxfN HgF8AEpt9l/UFtCEklMZkUj0leuYuCzLkroaDxJyslBxe8pLcKNxzq3+gHPmpUdjAThI xWMc4DUuRhj8H9he51HpXZSsbmEye4G9NMlYLdgsBJvTcxyMcOpdoZ/61MZYVlH8j0jd gVz3jAbu1RcjFlsX68C+8ehEtM3nL4pWUn/YDGY22JXRPyt+2rPJbLXpIwlAog7gIGy0 3GTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=jOxNEkfl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i7si5836945ils.74.2021.09.10.14.42.25; Fri, 10 Sep 2021 14:42:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=jOxNEkfl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234577AbhIJVm5 (ORCPT + 99 others); Fri, 10 Sep 2021 17:42:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229543AbhIJVm4 (ORCPT ); Fri, 10 Sep 2021 17:42:56 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 990B3C061574; Fri, 10 Sep 2021 14:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=leZ9gAJesxiaYyECvXAC95tfjrMi+xyfNBHPusNmXhc=; b=jOxNEkflIY8q+uoW+nXRu9FQ7U nFWTvXtl1dJ9Pdrc9LEPeJMj6UZYxV45Kbrks3XU1zNWuNHv7P/xx3oeYZ5zY0wPTPNZm8YiNSbKJ /I/GJbGoeqCrx83c/VDLP24V7Wy9FePPlXS4m4OP8fOma/KSJ9QB9Hd5bpc1cPbw2zEDp25wMk66X pWz6S+8VNX+Mv6ePijXJdLrwWLLnj/jzSXs8gP5kG/k/4HSmFmY08LNzNIWtTKAiCGeLYH7077uX8 PdaX1OJM0a/1qAxKBUkSIjZyAsN2m3eOTA3c/rSQyjB4vNt2zLcj9/gjYCNOuIdF/9wS2gSs+DvBq e/wW9kow==; Received: from [2601:1c0:6280:3f0::aa0b] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOoHH-00DtxH-El; Fri, 10 Sep 2021 21:41:43 +0000 Subject: Re: [PATCH v3] drivers/cdrom: improved ioctl for media change detection To: Lukas Prediger , phil@philpotter.co.uk Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, hch@infradead.org References: <20210910211600.5663-1-lumip@lumip.de> From: Randy Dunlap Message-ID: Date: Fri, 10 Sep 2021 14:41:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210910211600.5663-1-lumip@lumip.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lukas, Just a minor nit: On 9/10/21 2:16 PM, Lukas Prediger wrote: > +#define MEDIA_CHANGED_FLAG 0x1 /* Last detected media change was more \ > + * recent than last_media_change set by\ > + * caller. \ > + */ Drop the "continuation" backslashes. They are not needed. thanks. -- ~Randy