Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp1865420pxb; Fri, 10 Sep 2021 16:28:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzi2+D/KM7aEyAT/yr6+riVKjX5f9T5i5yWV9kwJ5MpeSGcF07vjaTHpIOZgEmVG5XTt4SR X-Received: by 2002:a17:906:a94f:: with SMTP id hh15mr20653ejb.297.1631316504045; Fri, 10 Sep 2021 16:28:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631316504; cv=none; d=google.com; s=arc-20160816; b=py//UpLXazZXOKHGxForcchR9xhfkD+TBW9OAPQY6yLTi3Ebl1j1Khbi+ptkf9Xvy0 +fAhxdt/dxfnSpnxeIpgT+mRlTUNjRbygoSs8eIBt5ejW4njoGJOrp/9sHmXAEJUbF/3 2qhx4SavDgOrkmYK6T0x7TVSyljEwBxfjYFW+S9QDcVepQ9YjuWM2sBBxBq8F2rJ0lye 8kGFPEoz0JkLDjDGlG/0e9LI8SZFghnh9O5L/0Un5IzRB/a67H3LbtnXepuxVtdT3VbV apu+M2jrRbL6iT9CGd1m8Qqa0EDHk9NpEoafmu9yZJsck+sAtEaaLzRVli4VWTKgptI4 ivGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=GCyhfADRMfFOEiIxBq+YxiKU22fwkrJgak5sBNxxnfM=; b=gidNxlXo3e/icSCywYnpVWBSo7TDWKlyxjA2zq0aPnM72OJ467fjppWMbr1wTB01be 0zL7S0WkQllsx8UaTbst9+DcBoHes4vWoL71/hrHUXwl+sJ3b+VH+SjI4Vj9Rb5qXLuX G6w0iLDl3aDVN1MSJktIrTPQ7LFn7DV+fN6UHlBAbHxjkQXYrcod/a6N7H62ZnPpEz/J Owr8sr+CUXRNyyS56GNX2k3VAT32ZTi5pdpbD2SPLrNroxeOHYannh2kS6zpYlyGRSjT Ji5aY4qm4HbFayc2z82R8kj4yCdC2pZtEAwbjXrOQb9mnuW4vl2wjnYL3TtFQCy664y5 GMkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p13Fcm19; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b3si100370ejp.504.2021.09.10.16.28.00; Fri, 10 Sep 2021 16:28:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p13Fcm19; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234656AbhIJX1q (ORCPT + 99 others); Fri, 10 Sep 2021 19:27:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:34734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233121AbhIJX1q (ORCPT ); Fri, 10 Sep 2021 19:27:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 922D4611B0; Fri, 10 Sep 2021 23:26:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631316394; bh=nWCVWm37Cn4aTHD9fKKBK0iiTuNj5cGbnQ7UNy5fjiA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=p13Fcm19TN9LmTK4LlFXJYisdlx8j91SHYqgG2d+C217OScazn4CK+Goc+whmNQJa ccx3b/fMa+GAFLShtrkw2wCd2vAY0tVJ+/AqBkqitqoL9L5oLqKutEGWAUNAK+R3Y/ sJqYpnAww5AVQqbFTNJObMcBwqD6gchOiTNTjN98IwZcwwgsltdB9KUR7ykVRaKEAN o9ueydR3zF1hTRSg1zy6p3RmdqXl4lQpCX4HY/6cZ/OXW5AaL4X2m1jBP05g7PMx33 +7J7HWLwwv6rZO1z4o22ZhLOTgTt2k1dFajut6FdFj+OYvmqqJyJqr4D0oscTPpFLh iOJfITNuWNWmw== Date: Fri, 10 Sep 2021 16:26:33 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 08/12] swiotlb-xen: arrange to have buffer info logged In-Reply-To: <2e3c8e68-36b2-4ae9-b829-bf7f75d39d47@suse.com> Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <2e3c8e68-36b2-4ae9-b829-bf7f75d39d47@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Sep 2021, Jan Beulich wrote: > I consider it unhelpful that address and size of the buffer aren't put > in the log file; it makes diagnosing issues needlessly harder. The > majority of callers of swiotlb_init() also passes 1 for the "verbose" > parameter. > > Signed-off-by: Jan Beulich Acked-by: Stefano Stabellini > --- a/drivers/xen/swiotlb-xen.c > +++ b/drivers/xen/swiotlb-xen.c > @@ -253,7 +253,7 @@ retry: > panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc); > } > > - if (swiotlb_init_with_tbl(start, nslabs, false)) > + if (swiotlb_init_with_tbl(start, nslabs, true)) > panic("Cannot allocate SWIOTLB buffer"); > swiotlb_set_max_segment(PAGE_SIZE); > } >