Received: by 2002:a05:6a10:eb17:0:0:0:0 with SMTP id hx23csp1867747pxb; Fri, 10 Sep 2021 16:32:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDWr+zdSsXY7EwfXWDoud4Dfg8L7Xa0iDn/s+8oA2BPuDIkw7LoFl9tVYvR8LLlfjoAmj5 X-Received: by 2002:a17:906:318b:: with SMTP id 11mr25061ejy.493.1631316735884; Fri, 10 Sep 2021 16:32:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631316735; cv=none; d=google.com; s=arc-20160816; b=eGlCZ9yziy/z7K6MPmhJKCRMHa3ScS5tS/I70wbm3FJuWw+J8k9X3YhJxGHC8OGVoI wQSCxO5nCzRGC6yFXlQHgxE2AvPKfQ/3o2k+m2GKgiC6kqONq7p/WZfPLdNa8BZW/M0y /p9FZDeIkL/BCkjtHV2oqaIYyCcA8+oy88YgfJ9Y6+SUiQmiJlTla6P3W/APlxmLr4RI EAKHR1p5cfQ3kTt07Phn6kIPZw6Zz48Oq4P84LDz4ml3JiFqfMBrSUzFlYTTYCe937Z5 ssig+TpTBFuokdK3ugG5HF0AJiEsm4510TWC31hJXOkPybQ1oyLhAM/qTlGBFCdHDqSo 3/DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=YWF9sfdvbYnB+m8GyR+KKN7LnqOd9oiAV+SjfIr/GIc=; b=g0qZoj+VvylOV7U3ARM6j+MGJhLKkycRrdJBrsJfoMsBgvr2v6/8rhuh+m2/m0+FML Tk1z2ltYNVkWn154xuOjBkRgMVgrcm+NSo4zMR/YlacfkKUgy4ujstgmGjlS+vWWi5Cq QVMaKQJtYSC9CMqTXoGIHOTfgcaEcXIGIu/Ih6Kto4sIxoU6TpU/YfCnzB6JTNcsIgSG NAzni25lPkCgmxVl51xv/u/P3CeUX2fGi0tP9dWHaRDAttlV/LkHdM3ZpYbgBVHwztKa OmrSsJ0AWC/tq9P17dzX47cATwGw+mvgp9y4DIiAnWas6aVTJaf8mubGYU5SKYA5nNgu CfSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DyyDq8G4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp15si69310ejc.221.2021.09.10.16.31.46; Fri, 10 Sep 2021 16:32:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DyyDq8G4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234809AbhIJX2i (ORCPT + 99 others); Fri, 10 Sep 2021 19:28:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:34854 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234790AbhIJX2f (ORCPT ); Fri, 10 Sep 2021 19:28:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 07A4E61211; Fri, 10 Sep 2021 23:27:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631316444; bh=MTpyGMzRwzcZckX1Knm3eAP7QqVukVmqh2sPwyO9Yu0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=DyyDq8G4s5uAzUcahf9t9rQB8ahLVLLBpkqerShVx5NmalJXs5fAu1lbV6IZ+WhzX XAcn58BFCMUD2sKtlYkoaWIFkckUj1/UG44RorEAw795xzQkBz7zwR6wSEi05NuOOs N16VJ43Qr8cCd19Vqqc3v2WDMYtOFsUcEZ1Ea2rRi8kfMBUKc/QPPhBlKfvfLiWffH 2FtDXArYULt2YKZB6w9frMgxvgQzdr+CxoTPUThOoEMb5/xCBMOVbPt/RYXZb8oCc4 qhMZQ+fhiFMz1tqxpuv4aIaj00F7cRdYcTEnPOVI0O+73zBaN39eFLqp6qoZuep4Yw XKCUYsZ6HSUEA== Date: Fri, 10 Sep 2021 16:27:23 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 09/12] swiotlb-xen: drop DEFAULT_NSLABS In-Reply-To: <15259326-209a-1d11-338c-5018dc38abe8@suse.com> Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <15259326-209a-1d11-338c-5018dc38abe8@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Sep 2021, Jan Beulich wrote: > It was introduced by 4035b43da6da ("xen-swiotlb: remove xen_set_nslabs") > and then not removed by 2d29960af0be ("swiotlb: dynamically allocate > io_tlb_default_mem"). > > Signed-off-by: Jan Beulich Reviewed-by: Stefano Stabellini > --- a/drivers/xen/swiotlb-xen.c > +++ b/drivers/xen/swiotlb-xen.c > @@ -152,8 +152,6 @@ static const char *xen_swiotlb_error(enu > return ""; > } > > -#define DEFAULT_NSLABS ALIGN(SZ_64M >> IO_TLB_SHIFT, IO_TLB_SEGSIZE) > - > int xen_swiotlb_init(void) > { > enum xen_swiotlb_err m_ret = XEN_SWIOTLB_UNKNOWN; >