Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 10 Sep 2021 20:32:59 -0700
From:   "H. Peter Anvin" <hpa@zytor.com>
To:     18341265598@163.com, Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org
CC:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Zhaoge Zhang <18341265598@163.com>
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH=5D_kvm=3A_x86=3A_i8259=3A_Converts?= =?US-ASCII?Q?_mask_values_to_logical_binary_values=2E?=
User-Agent: K-9 Mail for Android
In-Reply-To: <1631330841-3507-1-git-send-email-18341265598@163.com>
References: <1631330841-3507-1-git-send-email-18341265598@163.com>
Message-ID: <7CE1178D-729E-400A-A8D5-C8A9CD1BEE26@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

! is already booleanizing=2E There is no need to use !!!=2E

On September 10, 2021 8:27:21 PM PDT, 18341265598@163=2Ecom wrote:
>From: Zhaoge Zhang <18341265598@163=2Ecom>
>
>Signed-off-by: Zhaoge Zhang <18341265598@163=2Ecom>
>---
> arch/x86/kvm/i8259=2Ec | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/arch/x86/kvm/i8259=2Ec b/arch/x86/kvm/i8259=2Ec
>index 0b80263=2E=2Ea8f1d60 100644
>--- a/arch/x86/kvm/i8259=2Ec
>+++ b/arch/x86/kvm/i8259=2Ec
>@@ -92,7 +92,7 @@ static inline int pic_set_irq1(struct kvm_kpic_state *s=
, int irq, int level)
> 	mask =3D 1 << irq;
> 	if (s->elcr & mask)	/* level triggered */
> 		if (level) {
>-			ret =3D !(s->irr & mask);
>+			ret =3D !!!(s->irr & mask);
> 			s->irr |=3D mask;
> 			s->last_irr |=3D mask;
> 		} else {
>@@ -102,7 +102,7 @@ static inline int pic_set_irq1(struct kvm_kpic_state =
*s, int irq, int level)
> 	else	/* edge triggered */
> 		if (level) {
> 			if ((s->last_irr & mask) =3D=3D 0) {
>-				ret =3D !(s->irr & mask);
>+				ret =3D !!!(s->irr & mask);
> 				s->irr |=3D mask;
> 			}
> 			s->last_irr |=3D mask;

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E