Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] perf annotate: Add fusion logic for AMD microarchs
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        jolsa@redhat.com, yao.jin@linux.intel.com, namhyung@kernel.org,
        kim.phillips@amd.com, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20210906105640.1040-1-ravi.bangoria@amd.com>
 <20210906105640.1040-2-ravi.bangoria@amd.com> <YTpveO0qqKFTaxTk@kernel.org>
 <6a987cad-6c46-280e-f791-6c59b6628a45@amd.com> <YTtpVpo3d/h5YkVc@kernel.org>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
Message-ID: <e9525e3c-f0e6-e9ed-6ce5-fc207742c9d4@amd.com>
Date:   Sat, 11 Sep 2021 10:12:28 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YTtpVpo3d/h5YkVc@kernel.org>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?FHwxpKDok7dlrM9xmG38hDE3lwRoEWyOOM/KO59eZ/kGYT0i4Bb+q5BH?=
 =?Windows-1252?Q?22YWubF7oJ+Pa25NxAWZH4P96jTglJdP4kAQUGyeXoCVCWaHSI0s3v7j?=
 =?Windows-1252?Q?LFI1ZsQnwhaagyofPlaFRtsGpSgyCrmtjhhL4hDYqln5k7KTS5u481qx?=
 =?Windows-1252?Q?uvcNE07KJd1ZYk9pXw5Es17+gGSVdx0rfq0l47Gtbnj67RXdh0hal1ve?=
 =?Windows-1252?Q?dIOY35Vg1pP+OIac0Yo9obxq4UFDNqIkdilgzT95qTXka6k4jaNp1vVX?=
 =?Windows-1252?Q?VqwRKtBko2SPJ0FckEdB6uuJs3ziL0YpeE3kAb4hPRgLb5euLo04xGmi?=
 =?Windows-1252?Q?QabtFzR0sv5HOMeAcrvzMijAOQkZim3+QQx8DuxuUazWBmKfD8ke2mJv?=
 =?Windows-1252?Q?2DYb7qCs063OWN6xmDHFXzXBpQgAylX2OtmaoOIzv8LlK0/iStm2LvCm?=
 =?Windows-1252?Q?zhllGh8zjnVYmBZojspoHpeFc7czHLwvnGpdi8W+ZdLbLCvNl89jk2Ey?=
 =?Windows-1252?Q?N1rrSEWp/Tjf8cnPgz9gXsh38+ExX229t/oOjvZtKubDEe/YUjJV0imu?=
 =?Windows-1252?Q?HZMl0+e5u2nhpxBqFIlZNLIEFV2N+T9Ru/Ix19lS6rzzgagk6Zeq4AKH?=
 =?Windows-1252?Q?QcLJOKq1I9O7CUEYTVi1fm4ECzgMOu7OEny1IdLSy9tA3d+pFjhE3JZf?=
 =?Windows-1252?Q?r9+oA9IXEWmPXT+/o7565fxyKqUTV+MRRRTJxm6IodSvz2sHw3WQbAXs?=
 =?Windows-1252?Q?tZI4PyyzCCj8LgmE+d1HgE7fuQZwVCNK9pjQ+Uigr4Gwbt1yg4vlp9J5?=
 =?Windows-1252?Q?D2gi5lZFM81hP0YxK0sd/sy7R49DVv/TPVE9Yl7f/Kzy6ZrR0j8WLWDM?=
 =?Windows-1252?Q?wWS5F9YurMGnHpalfcFIgPFQcVlAbjnRxsVmzpkqz71YOFb0FelRFAFu?=
 =?Windows-1252?Q?kl1d6b7cFr+9nheYoZXrmvJWwUxvG7u4gtFvLiNwuzz6t3I7jY2+ehlU?=
 =?Windows-1252?Q?TsAGezstSg1zF6HXkrkd3SGzt0LttHeck77U271F/5i18Ry1bzOK5EkA?=
 =?Windows-1252?Q?fU7vzkrg0rupCPruVxgq7moeqBlmkFOyseLeV/0PLpxMnvh8FngRSco9?=
 =?Windows-1252?Q?P8NRC2PJZzkkHE9e5QAz+uw7fxd/5Mw9uybSZQGQGQd/JAGO3JT+Kkkr?=
 =?Windows-1252?Q?cXgvEnpgJU2KvQGoS4o8/fSNNagvNTaYZ+2IdClyneYlvEzA55YEqvfR?=
 =?Windows-1252?Q?2Cy+AOrr0QMf/UpMLfgD00vFNMlxgSLj9ofY2G6gjsdyTXXoJ4jnXy+w?=
 =?Windows-1252?Q?P/GKPNBnO8OZo+ZAORzjCqIQdFXMqhxhvinjwvduOXC7DeJb69hlw/an?=
 =?Windows-1252?Q?1IVkzUH5uYNiRpQ4UHVCSeP/FyAy3MZ3x452CTvD4395IVv6JyYuFG9w?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 589e1ef3-60bd-44b8-9157-08d974de9b4e
X-MS-Exchange-CrossTenant-AuthSource: BN7PR12MB2643.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2021 04:42:48.9003
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kBC4//dWVL+RE83tW+dB5E6ZtM1Ki7aFdn6/TzROealOH9HLxYy7llTUGfExTBYjy0EyrRqePQwM9Q0952alPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1780
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10-Sep-21 7:49 PM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Sep 10, 2021 at 04:47:31PM +0530, Ravi Bangoria escreveu:
>>
>>>> +static bool x86__ins_is_fused(struct arch *arch, const char *ins1,
>>>> +			      const char *ins2)
>>>> +{
>>>> +	if (strstarts(arch->vendor, "AuthenticAMD"))
>>>> +		return amd__ins_is_fused(arch, ins1, ins2);
>>>> +
>>>> +	return intel__ins_is_fused(arch, ins1, ins2);
>>>> +}
>>>> +
>>>
>>> Can we instead make x86__ins_is_fused be a pointer and instead of
>>> storing arch->vendor we set it to one of amd__ins_is_fused() or
>>> intel__ins_is_fused()?
>>>
>>> I.e. here:
>>>
>>>>  static int x86__cpuid_parse(struct arch *arch, char *cpuid)
>>>>  {
>>>>  	unsigned int family, model, stepping;
>>>> @@ -184,6 +216,9 @@ static int x86__cpuid_parse(struct arch *arch, char *cpuid)
>>>>  	if (ret == 3) {
>>>>  		arch->family = family;
>>>>  		arch->model = model;
>>>> +		arch->vendor = strndup(cpuid, 12);
>>>
>>> 		x86__ins_is_fused = strstarts(cpuid, "AuthenticAMD") ?
>>> 					amd__ins_is_fused :
>>> 					intel__ins_is_fused;
>>
>> Sure. Will post v2.
> 
> Thanks, if you're quick we may get this into this merge window :-)

v2 Posted: https://lore.kernel.org/lkml/20210911043854.8373-1-ravi.bangoria@amd.com

Thanks,
Ravi