Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp148706pxb; Sat, 11 Sep 2021 00:49:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcmAQO3JouOmWdmCR1bkMKlJAgp/oFs4iL6daFKiuXemhGLq4ZUmSnXG4EZgL5dE/OYCay X-Received: by 2002:a17:907:7856:: with SMTP id lb22mr1733732ejc.264.1631346572600; Sat, 11 Sep 2021 00:49:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631346572; cv=none; d=google.com; s=arc-20160816; b=bS3rnmW+hkF9QiphRnXqtzLlc+e3u7gZmkSGwYsHbay3GPixhUUesvBHKRDCnk9yFF HmjhkbU8Yb3eWtdM7eTjkG+OzQqc/QKM7MJ7teVPamZSaLd90NHV0HhicKjfyd8jczfE 7yTwNJaL5yHK2NbqaI+/GuSpp/isw59UmwKBBZ8mHPx8/+SNwwMG72S2tgg1Sr3lLhmS DNUGa7YKlOjHYQkhlLpNI01au8iiB1G7RcDxpmGBckMA+hvS6QtvOW/ixcrDR1QgNBr/ HrHUh+kvm+IMq823L08htwyz60nh9CngVx/fDlS3DNlgxPtfnMb5aF0+tMYCr7ssMC9/ p+WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=YYOISPRrVmZhy53QquVwzj7wP+CilWSx+6t0E1ssHhU=; b=w39X7gZO/upcE5Jj8m/BfgvLr6pO//vudVdnALTnMQaEV9mAj71YzySfilUEARtV39 CfbwSD1KTPW7sYYRBj0dEZnoCzlRnK/RT9xDhqvUR3B4gk+AtFqpHzEVmdKEcRN72G6A I0jNvqO0N735mlVBFSdjsCe81XIYHWCbixk9VaRqfH4rk1BOWysWEeooulM1XJst6PKt jr9pFoV9Z5YYLIm86of6HVg7BuZ+KYwPqqczkvJrPIsUzFbiXnRCMYi+GMMNsJG3pQYC tS0lV4oUJcHBTeQ/5O+0ZqXBUdsvuSGSnfkw94CQ9bY3dziZ/14B3wjOxpbaBJSMqKxH 70aQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nd33si1305596ejc.139.2021.09.11.00.49.08; Sat, 11 Sep 2021 00:49:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235331AbhIKHqa (ORCPT + 99 others); Sat, 11 Sep 2021 03:46:30 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:16250 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235334AbhIKHqU (ORCPT ); Sat, 11 Sep 2021 03:46:20 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4H64Wj0D9dz8t1s; Sat, 11 Sep 2021 15:44:33 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Sat, 11 Sep 2021 15:45:05 +0800 Received: from huawei.com (10.175.103.91) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Sat, 11 Sep 2021 15:45:05 +0800 From: Yang Yingliang To: , , CC: Subject: [PATCH 1/2] drm/nouveau/kms/nv50-: fix file release memory leak Date: Sat, 11 Sep 2021 15:50:22 +0800 Message-ID: <20210911075023.3969054-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When using single_open() for opening, single_release() should be called, otherwise the 'op' allocated in single_open() will be leaked. Fixes: 12885ecbfe62 ("drm/nouveau/kms/nvd9-: Add CRC support") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/gpu/drm/nouveau/dispnv50/crc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/dispnv50/crc.c b/drivers/gpu/drm/nouveau/dispnv50/crc.c index b8c31b697797..66f32d965c72 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/crc.c +++ b/drivers/gpu/drm/nouveau/dispnv50/crc.c @@ -704,6 +704,7 @@ static const struct file_operations nv50_crc_flip_threshold_fops = { .open = nv50_crc_debugfs_flip_threshold_open, .read = seq_read, .write = nv50_crc_debugfs_flip_threshold_set, + .release = single_release, }; int nv50_head_crc_late_register(struct nv50_head *head) -- 2.25.1