Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp242402pxb; Sat, 11 Sep 2021 03:55:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwU1tHHy2imNjigBtS2lYF3I/UMoFA0xpaSS8FY8fbhcCefqcBZPxzLYT1VVf2UJiDOk/KE X-Received: by 2002:aa7:d648:: with SMTP id v8mr2683148edr.340.1631357712930; Sat, 11 Sep 2021 03:55:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631357712; cv=none; d=google.com; s=arc-20160816; b=H/wIKiiZ97uFK4HvbclWM2YwvVv8Nn6SmL5hyAPoa25tmSgH05u7L7UyVHmP2DDorI Jwsn0LwMbZ+IBOLc42gt2qcX4KMnciFPjLxgQfN781n3QnESXtCKSPEC9+lz7LAqdBAN XYfUaYQANkFgDaJyWnGp3ys+xOkKJIvislEzASXadMFpge5/BXdQ1AsLyCWL6tmjHXhB kKZGKsbsSRGXRuFTBDvrAxC+G6NViiXXBkIjXMBwduw9W4Fi1VzC/L5WHCf+vUYBi347 wmCZWg+cI5XIhVwNkZSH1RUwkBU/NFJHWF/c764EnIDzNGQ7MnPlZiguN4mzkEcCSApa 0aMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=UFYHQK723urgnyZK8cryzPqMETiG1GMvGdqJPFY18rA=; b=t0EukWN/RovLhxdXyyTg6MdzRwKPL5fOuH5LEeWsGSoVJhtrirpdiIIx8yDlF6E3Vn /Mhm7ZEJFq5/smTSsVZCX8rN10eyqGXp1TQlFXizKZNKKgNd7GLSrHz7+fUwDKouoDlM MozdDZ1p3HWZjlEwmCa9saIXpoA1x4hcGW1qogCKHWtIXTnevgDIi5uDCj/IqFASnSrc CzWP6t28/Jt1MhJwhcCMirehKb8gdCXMsBQQ47gESEee353/gm7SJvfnkC2fFOof76e2 lgh7U4Hk4nCgFnwKYeGjQC8KB48iIdzYiqTztJFfKSvl5ptc1WYM1KDR+MomWI5Mgwr7 wnLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=A01dX2Kp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h4si1775019edt.426.2021.09.11.03.54.49; Sat, 11 Sep 2021 03:55:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=A01dX2Kp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235679AbhIKKwX (ORCPT + 99 others); Sat, 11 Sep 2021 06:52:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230131AbhIKKwW (ORCPT ); Sat, 11 Sep 2021 06:52:22 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 750D0C061574; Sat, 11 Sep 2021 03:51:10 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id j2so2783006pll.1; Sat, 11 Sep 2021 03:51:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=UFYHQK723urgnyZK8cryzPqMETiG1GMvGdqJPFY18rA=; b=A01dX2KpNI50iBNYmQtpOWRHyf1K4Wtbh4xi8aDyHDob/58AIZGJNitOTigpLb2XkD +6627sStMks0doTNi/apF95nMP4YylfHQy4Rl+nPWmcf7fKMNuyJKyye/hbkjFB/KU7q k0y+3DtWUAOcKMVemTYk34H1362/OCdBPCwuy/x3QDRpV81BRWNBN+whDMd3ctxutL5+ JEtsK7QlM1yj/JSiaUQpQHy1rYGohZkjVJ+BqLpvxYLHrhddzXDavvsZBOq9tT+p9cRX uKxOVILWmH/eTs9cQz0hHQx9AgNSj9xXcxzFE4tkcZcPQ2ArESAbtc8Gs7oyxrQXNKot +Mxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=UFYHQK723urgnyZK8cryzPqMETiG1GMvGdqJPFY18rA=; b=gsgc1h+I88qkiH2dZ02lk/LvyS/fHLDhfHANjpCOJXvIIVfKgO7M83vTWTwzMNbGqF Lpoqi7mYtcCiSKLuoKEGFu3TUF/EGP7+zqfHsKDEVKU0DrG+UwTfGqnYPepJAZu/WVmL X0TCuVJuS2l4pjOqylzWTKkcH64qBslS7vVpPtXDVLljX+bwnj/W48sV+J0FVWTxlOdV L9XNEVxZjy8nzLvoGGQjhuPPT2/JtCWeoEdrfbjMqIsgxRW3/utEzlWm1C7Ykxx2tqEg e3cjcS2YitxWeldcQ5gVAqDpZIq4kuOXYUR7i8BblS54lYgQt6CTVQ/XFtOPFbFxmDAC cO7Q== X-Gm-Message-State: AOAM533Br150lscEqnXgdfSdi0glJ2AgPhOqRU2kLkLRZY1l2Z0RW40S 2b89FyqSBBReuL2nyw+UoJA= X-Received: by 2002:a17:902:c406:b0:13b:7b40:9c51 with SMTP id k6-20020a170902c40600b0013b7b409c51mr1727663plk.89.1631357470001; Sat, 11 Sep 2021 03:51:10 -0700 (PDT) Received: from ubuntu ([223.106.51.51]) by smtp.googlemail.com with ESMTPSA id n11sm1449900pjh.23.2021.09.11.03.51.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Sep 2021 03:51:09 -0700 (PDT) Date: Sat, 11 Sep 2021 03:50:57 -0700 From: Zhongya Yan To: edumazet@google.com, rostedt@goodmis.org, brendan.d.gregg@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kuba@kernel.org, mingo@redhat.com, davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, hengqi.chen@gmail.com, yhs@fb.com, 2228598786@qq.com Subject: Re: [PATCH] net: tcp_drop adds `reason` and SNMP parameters for tracing v4 Message-ID: <20210911105057.GA4754@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 11 Sep 2021 03:50:12 -0700 Steven Rostedt wrote: > Just curious. Is "Tcp" the normal way to write "TCP" in the kernel? I see > it in snmp_seq_show_tcp_udp() in net/ipv4/proc.c, but no where else > (besides doing CamelCase words). Should these be written using "TCP" > instead of "Tcp". It just looks awkward to me. > > But hey, I'm not one of the networking folks, so what do I know? > > -- Steve I will do it. I guess any other suggestions? I feel like my description may not be accurate. Thanks. --Zhongya Yan