Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp322991pxb; Sat, 11 Sep 2021 06:16:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1btXg9b9rtIEVYdtCwzTXLbW8H4XvF8RpmtQ0Uniqb8Ym6bIIRzQxEmtPuu6VcdPeLwvI X-Received: by 2002:a50:cc08:: with SMTP id m8mr3286959edi.60.1631366180308; Sat, 11 Sep 2021 06:16:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631366180; cv=none; d=google.com; s=arc-20160816; b=Q93SyKfVeGklL+NDOyedHg+bGMQvPjsQ2NbHwWZ3a/yKJtialtvDxom8Xv9WDTyV35 ORA0U7+0+vuCwtSba6+CUE0cg88hP8+C753DDcmGrXseokr9Lwbljd74vVstRbm++Y+W sxOQSl3jFlQknUqrgxiZzoFcTaYJulI8OwVG2aVbDolnr2enJHx5IK3panmQOkR9rFSI p+R0llpBN0b0nFjaZRBVlZXZ/xreCW53KAXPWMgnbQ0b9RWIvb6NmJWkyzS0glqqLcyo ORbC+qIzaNohRp31X1FzTd+bWe37Afzmra3SjvlLI00Wk+plBpwNsZVlv8kMRxV00kCw 0KEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mzFjWi4UwZIvNo9XY3++yXPjx/0mnps15J8Mx8+sBw4=; b=GGXPeG8c90/7rXFw2XS0Sq6s24y47DyimKA16eEITaTId+fIjS2V0CkuwlbSdEmSKf kDyoZR1nxSSwW+64wK7cTwsHydhujHsVEVuvoADm64Z0jVk5R8JAWkvylPidqQ/EL2MJ 1y3pkZvtHxI2h/8zTMrOy6rlBY57A6b1xtT7kQV4WwW5gC+GRljmzISwGUQonmiROjgT NDTpujkk0FowfvIYQjDmIKtH6fuCnaycwPiwl+X9Br/JJ0C503LC49FONHZDxEhGRiT6 1RzVtutGHwsxo2Sr6XkwnAAW8O410y+NSElx6hrHfDEWkwZ54KfWWj0Ufs8AatTL/RV4 Nu1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RlYKeFDp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eb8si2345617edb.108.2021.09.11.06.15.56; Sat, 11 Sep 2021 06:16:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RlYKeFDp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236765AbhIKNOv (ORCPT + 99 others); Sat, 11 Sep 2021 09:14:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:38090 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236327AbhIKNNk (ORCPT ); Sat, 11 Sep 2021 09:13:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7AA67611C3; Sat, 11 Sep 2021 13:12:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631365948; bh=W067M9YuUs/H/l/wOW2OpgBb+e2lq9U28N6uJgw6CEw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RlYKeFDpf0rqGqrD+RDd+g3RZ7TTgFL0jcvWvg+o/RaOvbyhV29vOXCbVe9tiUubc dS7P2zKgCzb5ru+Kryr0Tu2utxoWkkgumDOH/ynsf6U5G/TxOYwjU4w2MVonUISDPS ACDh4QTMTIKoeCQN3k+9Ews/fGZArRDNuhl1M0mCtT4vwSrvpRmc0umvueGCSmKD9G B51heaO2CrU+K+Bg4y420+vsw9Kwuc1fjMkAhYC9eQon1So8LCkfZh1x3u6QaCLJfP ZADmsp7JQjOh4AdBDxUQcA3kXoRR42Pz6+FUzofpE03QJ8khFOzWDGmdprszYv7swB mthwFX9gf3igQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yang Li , Abaci Robot , Logan Gunthorpe , Jon Mason , Sasha Levin , linux-ntb@googlegroups.com Subject: [PATCH AUTOSEL 5.14 29/32] NTB: Fix an error code in ntb_msit_probe() Date: Sat, 11 Sep 2021 09:11:46 -0400 Message-Id: <20210911131149.284397-29-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210911131149.284397-1-sashal@kernel.org> References: <20210911131149.284397-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Li [ Upstream commit 319f83ac98d7afaabab84ce5281a819a358b9895 ] When the value of nm->isr_ctx is false, the value of ret is 0. So, we set ret to -ENOMEM to indicate this error. Clean up smatch warning: drivers/ntb/test/ntb_msi_test.c:373 ntb_msit_probe() warn: missing error code 'ret'. Reported-by: Abaci Robot Signed-off-by: Yang Li Reviewed-by: Logan Gunthorpe Signed-off-by: Jon Mason Signed-off-by: Sasha Levin --- drivers/ntb/test/ntb_msi_test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/ntb/test/ntb_msi_test.c b/drivers/ntb/test/ntb_msi_test.c index 7095ecd6223a..4e18e08776c9 100644 --- a/drivers/ntb/test/ntb_msi_test.c +++ b/drivers/ntb/test/ntb_msi_test.c @@ -369,8 +369,10 @@ static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb) if (ret) goto remove_dbgfs; - if (!nm->isr_ctx) + if (!nm->isr_ctx) { + ret = -ENOMEM; goto remove_dbgfs; + } ntb_link_enable(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO); -- 2.30.2