Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp324392pxb; Sat, 11 Sep 2021 06:18:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7Gx8ulg8nYwp+9ygG+IPSVCXVSjgGU8qE46+5CAbaHLBxeqhciWOwA0+CKfqmyFyS6WcN X-Received: by 2002:aa7:d895:: with SMTP id u21mr3214281edq.300.1631366306210; Sat, 11 Sep 2021 06:18:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631366306; cv=none; d=google.com; s=arc-20160816; b=t8xhBhu69ZF6tPG90c0PoVMdrGm1qofQVGZglmHUMPUTrlKMKliwN2g6edZsEzr6+U PunnxO31qyBHwYGnsb9AGvE4O9R6ImY6nCC6BrP2AWrVYSddgQsbzl+xmGaJSvd6rGxT iPC3uadW2/iLT4AyySMpxfUD4fXQMJmxB4H8nke730z9Anic3yCd7cwQjp4sREzWClmj OjKKcEO6gOPkE2vZLSLtq+REOeGGR4eDZ9Usre5TCWsi4clQDKXDxa2Rnb3Mp3N5wn03 AbukqKnHnVq4uPLiOFpGShqCRvmVxJ9JTJVav6CrXS8m0vGY8R2Dvac3YDyhhXLeCr5p 57fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=F7lCF9hdAversJvozlW/duI8bamPDmu5Va47WdZokpE=; b=NKeOWR9TCak3jx/KDto8LAMlpx9J3G0bIyulb8RsOUJ+YabDGcKjopADExmsHT0J4w es6znWucRsY87rS+x47dQUv8qLCHwO0qVoCVgMDv7nWxm2x73KJ8HxSWSzk0mtntzEt7 JwOXOeA8Argx71L45Mb3cac4zWEbxmht4JyN9x3FHF4IxzrIY6Q9kijUqxSvPT42g13M 46q9i+aA+dQ2IG2lk9+B6apNj+DGhu5UD3lP5xZQUA7xH73roJyDsbD3XNM6AUV4tfkB dtd/FD87yroQgP6/ui1+eESja6WEJCE7OILSRyiNT0Up+GkhbC2b5rz5tOxiWOAixJi5 sAEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kBMp8Gx8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jg4si1903246ejc.285.2021.09.11.06.18.02; Sat, 11 Sep 2021 06:18:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kBMp8Gx8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236006AbhIKNOx (ORCPT + 99 others); Sat, 11 Sep 2021 09:14:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:38164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236348AbhIKNNn (ORCPT ); Sat, 11 Sep 2021 09:13:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 08210611BF; Sat, 11 Sep 2021 13:12:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631365950; bh=EFMNFVAc5CcSijdhhhVHCaxpm6yJnxx8kYaKNOizbCs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kBMp8Gx8eUongj6OpSwfLMKLKZ/Vlf/9JE+rtHXUhqURe7gBUY8smYocC3K9pSKca 4IdmfBinbUdwfNfr+IK6q3j1SowQlJZfQco2gjA8J8W9NrbcVqLlRqfM0IRvRyXQnC r81xMxtQ6TSslmDv+VbLhEnTqypbSD5E2o/ZO6wn8715crkbChGKu2DEkgWbZzh+Um xo/AwESeWa9kZVO8qIr7o1j5uGrgI75Hu8eb2b3Gt5BB4Zar46L7dMiyw8MFSQ2dOz rb3h6SuJD0Nw6keYLdpURDQZa2uS/ZClQGHbfFk44GF6clPlGhQ04FE5kG9Ul3p4xS 9LM8DqE5vETuA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: zhaoxiao , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.14 31/32] stmmac: dwmac-loongson:Fix missing return value Date: Sat, 11 Sep 2021 09:11:48 -0400 Message-Id: <20210911131149.284397-31-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210911131149.284397-1-sashal@kernel.org> References: <20210911131149.284397-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zhaoxiao [ Upstream commit 5289de5929d1758a95477a4d160195397ccffa7b ] Add the return value when phy_mode < 0. Signed-off-by: zhaoxiao Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c index 4c9a37dd0d3f..ecf759ee1c9f 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c @@ -109,8 +109,10 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id plat->bus_id = pci_dev_id(pdev); phy_mode = device_get_phy_mode(&pdev->dev); - if (phy_mode < 0) + if (phy_mode < 0) { dev_err(&pdev->dev, "phy_mode not found\n"); + return phy_mode; + } plat->phy_interface = phy_mode; plat->interface = PHY_INTERFACE_MODE_GMII; -- 2.30.2