Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 12 Sep 2021 01:24:51 +0300
From:   Denis Pauk <pauk.denis@gmail.com>
To:     Andy Shevchenko <andriy.shevchenko@intel.com>
Cc:     Bernhard Seibold <mail@bernhard-seibold.de>,
        Guenter Roeck <linux@roeck-us.net>,
        Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] hwmon: (nct6775) Use sio_data in superio_* (v2)
Message-ID: <20210912012451.60a8ef04@penguin.lxd>
In-Reply-To: <YTo7OnzCRDZuveHN@smile.fi.intel.com>
References: <08262b12-4345-76a9-87be-66d630af3a59@roeck-us.net>
        <20210908213605.9929-1-pauk.denis@gmail.com>
        <YTo7OnzCRDZuveHN@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Thanks for the feedback!

On Thu, 9 Sep 2021 19:50:02 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Thu, Sep 09, 2021 at 12:36:02AM +0300, Denis Pauk wrote:
> 
> Thanks for your contribution!
> My comments below.
> 
> > Rearrange code for directly use struct nct6775_sio_data in superio_*
> > functions  
> 
> Missed period.
> 
> We refer to the functions as superio_*().
> 
> The commit message may need more elaboration (why you are doing this).
> 
> > v2: split changes to separate patches  
> 
> This should go after '---' (cutter) line below. But entire series
> needs: 1) a proper versioning (use `git format-patch -v<n> ...`)
> 2) to NOT be a continuation of the previous one (start a new thread!)
> 3) to have a cover letter (use `git format-patch --cover-letter`)
> 
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=204807  
> 
> BugLink
> 
> > Signed-off-by: Bernhard Seibold <mail@bernhard-seibold.de>
> > Signed-off-by: Denis Pauk <pauk.denis@gmail.com>  
> 
> This is wrong. My understanding that you have to preserve Bernhard's
> authorship and add yourself as Co-developer (see Submitting Patches on
> how to properly use tags).
> 
> ...


Should it be such ?

----
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=204807
Signed-off-by: Denis Pauk <pauk.denis@gmail.com>
Co-Developed-by: Bernhard Seibold <mail@bernhard-seibold.de>
----


> 
> > +struct nct6775_sio_data {  
> 
> > +	int sioreg;  
> 
> It should be unsigned short.
> 
> > +	enum kinds kind;
> > +};  
> 

Should I change all occurrences of sioreg to unsigned short?
Before my patch it was integer. 

--
Best regards,
                  Denis.