Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <51815fbe3e864a0177445b9b17d018a42d603e21.camel@gmx.de>
Subject: Re: ksmbd,transport_rdma.c: Don't include rwlock.h directly
From:   Mike Galbraith <efault@gmx.de>
To:     lkml <linux-kernel@vger.kernel.org>
Cc:     Hyunchul Lee <hyc.lee@gmail.com>,
        Namjae Jeon <namjae.jeon@samsung.com>
Date:   Sun, 12 Sep 2021 04:23:12 +0200
In-Reply-To: <425df999d02a62af13da8e77dbed0f2be750cda8.camel@gmx.de>
References: <425df999d02a62af13da8e77dbed0f2be750cda8.camel@gmx.de>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.41.2 
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

typing hard.. Thag forget type [patch]

On Sun, 2021-09-12 at 04:19 +0200, Mike Galbraith wrote:
>
> rwlock.h specifically asks to not be included directly.
>
> In fact, the proper spinlock.h include isn't needed either,
> it comes with the huge pile that kthread.h ends up pulling
> in, so just drop it entirely.
>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
> ---
> =C2=A0fs/ksmbd/transport_rdma.c |=C2=A0=C2=A0=C2=A0 1 -
> =C2=A01 file changed, 1 deletion(-)
>
> --- a/fs/ksmbd/transport_rdma.c
> +++ b/fs/ksmbd/transport_rdma.c
> @@ -20,7 +20,6 @@
> =C2=A0#define SUBMOD_NAME=C2=A0=C2=A0=C2=A0=C2=A0"smb_direct"
>
> =C2=A0#include <linux/kthread.h>
> -#include <linux/rwlock.h>
> =C2=A0#include <linux/list.h>
> =C2=A0#include <linux/mempool.h>
> =C2=A0#include <linux/highmem.h>
>