Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <08262b12-4345-76a9-87be-66d630af3a59@roeck-us.net>
 <20210908213605.9929-1-pauk.denis@gmail.com> <YTo7OnzCRDZuveHN@smile.fi.intel.com>
 <20210912012451.60a8ef04@penguin.lxd>
In-Reply-To: <20210912012451.60a8ef04@penguin.lxd>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sun, 12 Sep 2021 17:43:24 +0300
Message-ID: <CAHp75VfnNA73c+xBiescOd=YiNR7-zRu91VfFq-MiMhvPy7bGA@mail.gmail.com>
Subject: Re: [PATCH 1/3] hwmon: (nct6775) Use sio_data in superio_* (v2)
To:     Denis Pauk <pauk.denis@gmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@intel.com>,
        Bernhard Seibold <mail@bernhard-seibold.de>,
        Guenter Roeck <linux@roeck-us.net>,
        Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Sep 12, 2021 at 1:26 AM Denis Pauk <pauk.denis@gmail.com> wrote:
> On Thu, 9 Sep 2021 19:50:02 +0300
> Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> > On Thu, Sep 09, 2021 at 12:36:02AM +0300, Denis Pauk wrote:

...

> Should it be such ?

I don't know, but if so, then SoB of Bernhard is missing below.

It's all written in the Submitting Patches document:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=204807
> Signed-off-by: Denis Pauk <pauk.denis@gmail.com>
> Co-Developed-by: Bernhard Seibold <mail@bernhard-seibold.de>

...

> > > +   int sioreg;
> >
> > It should be unsigned short.

> Should I change all occurrences of sioreg to unsigned short?
> Before my patch it was integer.

Ah, then it's fine. Keep the same type then as is.

-- 
With Best Regards,
Andy Shevchenko