Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 12 Sep 2021 19:04:43 +0100
From:   Phillip Potter <phil@philpotter.co.uk>
To:     Lukas Prediger <lumip@lumip.de>
Cc:     axboe@kernel.dk, hch@infradead.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, rdunlap@infradead.org
Subject: Re: [PATCH v3] drivers/cdrom: improved ioctl for media change
 detection
Message-ID: <YT5BO7bUMMkwNCTh@equinox>
References: <CAA=Fs0mEprM0hErRY-kw7bOVqEw3o6X=--OixQ=_fNXdV_-QGQ@mail.gmail.com>
 <20210911174816.55538-1-lumip@lumip.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210911174816.55538-1-lumip@lumip.de>
Precedence: bulk

On Sat, Sep 11, 2021 at 08:48:17PM +0300, Lukas Prediger wrote:
> Hi Randy, Hi Phil,
> 
> >>
> >> Hi Lukas,
> >>
> >> Just a minor nit:
> >>
> >> On 9/10/21 2:16 PM, Lukas Prediger wrote:
> >> > +#define MEDIA_CHANGED_FLAG   0x1     /* Last detected media change was more \
> >> > +                                      * recent than last_media_change set by\
> >> > +                                      * caller.                             \
> >> > +                                      */
> >>
> >> Drop the "continuation" backslashes.
> >> They are not needed.
> >>
> >> thanks.
> >> --
> >> ~Randy
> >>
> 
> Hm, my IDE was complaining about these but I just tested building without and
> that worked fine. No idea what that was about then..
> 
> >
> > Dear Lukas,
> >
> > Happy to take these out for you and save you resubmitting.
> > I'm very happy with patch anyway. Once I hear back from
> > you I'll send onto Jens with my approval after one final test :-)
> >
> 
> That would be very nice of you!
> 
> >
> > Thanks again for the code.
> >
> 
> My pleasure, and thanks for the helpful feedback!
> 
> >
> > Regards,
> > Phil
> 
> Best regards,
> Lukas

Dear Lukas,

This v3 patch does not apply to my tree, or the mainline one for that
matter. A few problems I've noticed that are the cause of this:

Misnamed file:
Documentation/ioctl/cdrom.rst - this file should actually be:
Documentation/userspace-api/ioctl/cdrom.rst (and is in v2)

Failed hunks:
v3 fails on applying the changes to drivers/cdrom/cdrom.c as well, due
to two hunks failing (because of different lines preceding your
changes).

It also fails to apply the second hunk to include/uapi/linux/cdrom.h,
again due to differences in pre-existing content. Did you base this v3
patch against a different/older tree/branch?

Please advise, many thanks. As mentioned before, v2 applied perfectly
fine for me.

Regards,
Phil