Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762640AbWLKHw2 (ORCPT ); Mon, 11 Dec 2006 02:52:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762642AbWLKHw2 (ORCPT ); Mon, 11 Dec 2006 02:52:28 -0500 Received: from rhun.apana.org.au ([64.62.148.172]:2342 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1762640AbWLKHw1 (ORCPT ); Mon, 11 Dec 2006 02:52:27 -0500 Date: Mon, 11 Dec 2006 18:51:11 +1100 To: Andrew Morton Cc: David Miller , mingo@elte.hu, alan@lxorguk.ukuu.org.uk, lenb@kernel.org, linux-kernel@vger.kernel.org, ak@suse.de, torvalds@osdl.org Subject: Re: [patch] net: dev_watchdog() locking fix Message-ID: <20061211075111.GA24994@gondor.apana.org.au> References: <20061207210657.GA23229@gondor.apana.org.au> <20061208151902.4c8bb012.akpm@osdl.org> <20061208235952.GA4693@gondor.apana.org.au> <20061209.140205.126778911.davem@davemloft.net> <20061210234508.cd83a784.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061210234508.cd83a784.akpm@osdl.org> User-Agent: Mutt/1.5.9i From: Herbert Xu Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1191 Lines: 28 On Sun, Dec 10, 2006 at 11:45:08PM -0800, Andrew Morton wrote: > > It spits a nasty during bringup > > e1000: eth0: e1000_probe: Intel(R) PRO/1000 Network Connection > forcedeth.c: Reverse Engineered nForce ethernet driver. Version 0.59. > netconsole: device eth0 not up yet, forcing it > e1000: eth0: e1000_watchdog: NIC Link is Up 100 Mbps Full Duplex > WARNING (!__warned) at kernel/softirq.c:137 local_bh_enable() Normally networking isn't invoked with interrupts turned off, but I suppose we don't have a choice here. This is unique being a place where you can get called with BH on, off, or IRQs off. Given that this is only used for printk, the easiest solution is probably just to disable local IRQs instead of BH. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/