Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762642AbWLKHwd (ORCPT ); Mon, 11 Dec 2006 02:52:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762643AbWLKHwd (ORCPT ); Mon, 11 Dec 2006 02:52:33 -0500 Received: from mx3.cs.washington.edu ([128.208.3.132]:35899 "EHLO mx3.cs.washington.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762642AbWLKHwc (ORCPT ); Mon, 11 Dec 2006 02:52:32 -0500 Date: Sun, 10 Dec 2006 23:52:20 -0800 (PST) From: David Rientjes To: Yasunori Goto cc: Andrew Morton , Linux Kernel ML , Randy Dunlap Subject: Re: [Patch](memory hotplug) Fix compile error for i386 with NUMA config In-Reply-To: <20061211115829.AD68.Y-GOTO@jp.fujitsu.com> Message-ID: References: <20061209183320.0761.Y-GOTO@jp.fujitsu.com> <20061211115829.AD68.Y-GOTO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 718 Lines: 20 On Mon, 11 Dec 2006, Yasunori Goto wrote: > No. > Other arch's arch_add_memory() and remove_memory() have been already > used for NUMA case too. But i386 didn't do it because just > contig_page_data is used. > Current NODE_DATA() macro is defined both case appropriately. > So, this #ifdef is redundant now. > Then I assume the comment directly above this change is also redundant since it explicitly states that the following code is for the non-NUMA case. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/