Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next v2] bpf: Add oversize check before call kvcalloc()
To:     Bixuan Cui <cuibixuan@huawei.com>, <bpf@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     <ast@kernel.org>, <daniel@iogearbox.net>, <andrii@kernel.org>,
        <kafai@fb.com>, <songliubraving@fb.com>,
        <john.fastabend@gmail.com>, <kpsingh@kernel.org>
References: <20210911005557.45518-1-cuibixuan@huawei.com>
From:   Yonghong Song <yhs@fb.com>
Message-ID: <39ffe740-0092-61ee-5af7-8de41b5700c0@fb.com>
Date:   Sun, 12 Sep 2021 19:25:02 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <20210911005557.45518-1-cuibixuan@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eW9yd3dnVXRUbXN6SzlkSzFPaEErcGdRYkF4dy9yZCtaWXh3YmhNUzVueHBN?=
 =?utf-8?B?WWN2R3REbzFWa05TTjVmMUtxc203aXp3Vkp6SGhoZGJ2U3gyK1RVU2IxeVFU?=
 =?utf-8?B?SExaMklDc1NTRGhUMS90b3FBeFFtaURVNlQ2THBmTm93eTMvZzd6a0ZpU1JO?=
 =?utf-8?B?eXVOcjlic1BNb2ViblQ1NHRqYktVSStCRmxENzZIWi82c2ErS0p1cG9jV01p?=
 =?utf-8?B?aVVKUVhPeTc1b0tNV2ZmQWJqT0RKVnZYWENNVXRibTF5b2twQVEwZkJFZlRT?=
 =?utf-8?B?ZFIxMjdDYW12WVQ1M0xwbUNPL2hXbjJtM0dLUnl5UzRpd0ZJR0NsQk8rQkxM?=
 =?utf-8?B?VFVCSkxmOGQ3NHVHdjFIc0szSjJCNVp6aDBIRU9Fb0JiNk9Idld0MkZUWkY0?=
 =?utf-8?B?SHpsNlZya0dWR3J6WlBrNnFmWE9FTEgrZXhHOEhhR0F6dndMOEJaWkZKM2RF?=
 =?utf-8?B?aUZHWm9id3AvU3BWMjk3cmFrU0VTY1lPOUJzbHkwWTJVTytINWFOU3UyQjll?=
 =?utf-8?B?OXNnSnFod05ScnM0VmkycXVFc2FuS1ozM2V3NFZpVU1nMXl4dnp1S1BmZ1Ni?=
 =?utf-8?B?KzZFbVZtaVZjUnAreC9NZUVxZzdYOExzZnpxbThMR092SEJPMXIreitxeFR2?=
 =?utf-8?B?ak54RGNZcDRDRFZ2MGdYTkZHSEU1bFIrd2R2QkdpNDBYb3J5WXFDMUd3MGFL?=
 =?utf-8?B?TGRMcFY5d2JIaXY2OU5tajcvcVV2clZlbDFUMExFbzNCRHhqM25jckp4RWhO?=
 =?utf-8?B?VTA1VzB6RXMrU2k5NDJZVmJFbmpjUzR3WkpFR0IrNG9VWEJPZmtUUHlFSU15?=
 =?utf-8?B?OFdPOXhHbjlGOUhYa1E1ckY5NVY2anphQzQ2NVdjVGJrcTZkcUF0QVpwWWJ5?=
 =?utf-8?B?REZXZmhqVEk5NndpcnM5SzFLR2RsdEJFTkhYWWhBeWRZM3pBM0M5c2pOYVBC?=
 =?utf-8?B?NDMydHlXTXR6VkkwSmVxZlNuTGFOZEFYODN1dkNneUN6alFXRThmUThDblNq?=
 =?utf-8?B?Y3BpSUVZNVVtdHhNR0ROR2ZnWWlPKy9yanNoRTg4SnFZa2dhSDBXVndwdlVi?=
 =?utf-8?B?Rzdad1U3QnNnZzB6aStkVGhoa2tiaDYySldpS20vVm8yMEhYVmlDaFplaW5q?=
 =?utf-8?B?OHNRdGNsMlFMZnA0VFlXTHR2MjdlYUlkYTJFVE8yaVJ4UHgzUzFkQUk0LzZH?=
 =?utf-8?B?ekd1NlFIMlo0ZWVlNC9qVlVhMENGdW9hWWRIUkJMdC9QMkNkbUpmVlk2eGJw?=
 =?utf-8?B?Rnk5ZVNkREo2VW9HVEh1L0ltK25Ec1VDTm1DMHhGVVpBeGhQdnllekpwVC8z?=
 =?utf-8?B?SVp6eHB6WTg2YjdoSkJaS2d3cStFQWQ3WGN5RWdhM3hZNWd2NlM4NjFZUDAy?=
 =?utf-8?B?SFAveU1sR0tCMk50VkpwVFhvc0NhVDNLQ2xyczdZdFE2bFBPRXVKUnBtcGVp?=
 =?utf-8?B?dEFCQUZ3UXBjQm94QmFYSm9pdngzSUVraE9DZ3huYTZJYUprOEJQTy9iU1pk?=
 =?utf-8?B?ZzdUNzNBcmlTbk9sU3lTQ3pTOWJVNmt1SFJGOUFLZVJLaHNJUStJdWxwd2Yy?=
 =?utf-8?B?SVZZSUlFVTdNc1N4dllHOU9IK3NPVHo5MVowaDllUHZSUGRmNmw0VEphTmdm?=
 =?utf-8?B?aXI2R0NUQ0MvMi9IeXJ1QkFlc21XekZXUEtnZnczeXdVWVlvd0pGQkRpUGZa?=
 =?utf-8?B?RjgwbDNnSE9OSEFYNGtJVDhKeCt5aTNleHVGT3ZPS2xaZGtXK25uWlhqNlBD?=
 =?utf-8?B?S1FzeGVNMGxNd3E4VGpjYjFXaUVCUW9HOCtaNTI3YWtXY3g0aUMxaStJUlVS?=
 =?utf-8?B?NlFqcnRHdnJ0UVFGcE9pUT09?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fc3c3190-7ec0-4a59-e277-08d9765db3c7
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 02:25:07.1142
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 82pDvQPA3yQ34tUB5yjO0GhJHrwUC0wKc54ol61hqgYBUJ+qk5YbsINeOwDowrtB
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR15MB3760
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: a9OpBy05VQHUdZm8PSZxYPOz2N9JNjJD
X-Proofpoint-GUID: a9OpBy05VQHUdZm8PSZxYPOz2N9JNjJD
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-09-12_10,2021-09-09_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxscore=0
 priorityscore=1501 impostorscore=0 adultscore=0 malwarescore=0
 suspectscore=0 bulkscore=0 phishscore=0 mlxlogscore=737 spamscore=0
 lowpriorityscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2109030001 definitions=main-2109130015
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/10/21 5:55 PM, Bixuan Cui wrote:
> Commit 7661809d493b ("mm: don't allow oversized kvmalloc() calls") add the
> oversize check. When the allocation is larger than what kmalloc() supports,
> the following warning triggered:
> 
> WARNING: CPU: 0 PID: 8408 at mm/util.c:597 kvmalloc_node+0x108/0x110 mm/util.c:597
> Modules linked in:
> CPU: 0 PID: 8408 Comm: syz-executor221 Not tainted 5.14.0-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> RIP: 0010:kvmalloc_node+0x108/0x110 mm/util.c:597
> Call Trace:
>   kvmalloc include/linux/mm.h:806 [inline]
>   kvmalloc_array include/linux/mm.h:824 [inline]
>   kvcalloc include/linux/mm.h:829 [inline]
>   check_btf_line kernel/bpf/verifier.c:9925 [inline]
>   check_btf_info kernel/bpf/verifier.c:10049 [inline]
>   bpf_check+0xd634/0x150d0 kernel/bpf/verifier.c:13759
>   bpf_prog_load kernel/bpf/syscall.c:2301 [inline]
>   __sys_bpf+0x11181/0x126e0 kernel/bpf/syscall.c:4587
>   __do_sys_bpf kernel/bpf/syscall.c:4691 [inline]
>   __se_sys_bpf kernel/bpf/syscall.c:4689 [inline]
>   __x64_sys_bpf+0x78/0x90 kernel/bpf/syscall.c:4689
>   do_syscall_x64 arch/x86/entry/common.c:50 [inline]
>   do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
>   entry_SYSCALL_64_after_hwframe+0x44/0xae
> 
> Reported-by: syzbot+f3e749d4c662818ae439@syzkaller.appspotmail.com
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>

Acked-by: Yonghong Song <yhs@fb.com>