Received: by 2002:a05:6a10:6d25:0:0:0:0 with SMTP id gq37csp1445736pxb; Sun, 12 Sep 2021 19:51:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGXA6jGgEgjywoPvUfLZa4TnKdl7dtaNf227re3jeWKYmiuMBGgl6W4lu8L2gZGp2HP+lL X-Received: by 2002:a05:6e02:1a6f:: with SMTP id w15mr6506972ilv.281.1631501514806; Sun, 12 Sep 2021 19:51:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631501514; cv=none; d=google.com; s=arc-20160816; b=jdWr9NRBHEpJrWAc+deXIHUpl+rzPYiDEtoTRijVp3MivGab3CPaDNhNKAt3xi6pQb SFMiD0+th5eA3JSTmjq+NtB1L64gvRsKaNL4zNFzedUikp8ymu5/CowsgI5+wjqb6Kcb g5VYwgX89TmVMYJiB+0BjPBAr8trvwnSQ3/m5yK6CjL8AUrlf3sbe6VW1A5MRMiohuRZ LT9zp5hcyJDW9k66RSSiwlB2ckbSvsF/+1N5NBFq6A7Ia2H5olkbRAGBM9DZllH6nLKH 4iubsEE9KPx/YkiaL0s9VM81KbnByJbO5eboFV6CIsCvwfgQW5YA9JdTHlA00heWs1V5 v4hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=JnZ+T81xxeMxYG/DyrFUoeTLNxItYvJm+vAp2jTLAZQ=; b=lhNs+HddKXVkGRSNmmXw2XGd586dr6vyGVZIechad63IK6OuB3M0uGBv7WN9Y9gO5V 7Xj3Fubuo0ff930+/gEu8yUlDrZ1lqEcO1W9uXIlVVYnFD9XNRwUiDEQUDSEsFhU63pb hg0KvbJhwkOMpJKH4ZjV9/Q2Ja0GePBa1ZALT3OwCc1KqFrAtK+mH+5wKU8snpAdinGI KOUxLvynpHu60DYrHI29JfRwghJ73nvYUswrwQgobGRyr9mLtzb/CIZyWQXKx2JvaUA/ kJa6A1UoiN6fb7u4Zc3TRyrBpbS7xhtQbdzh7JUFt7QkfN935yVjQ+H5yvNQPKdh+EtQ J+wA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="jza6yE/f"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m1si4208455ila.78.2021.09.12.19.51.43; Sun, 12 Sep 2021 19:51:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="jza6yE/f"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236968AbhIMCvX (ORCPT + 99 others); Sun, 12 Sep 2021 22:51:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236880AbhIMCvW (ORCPT ); Sun, 12 Sep 2021 22:51:22 -0400 Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A3D1C061574; Sun, 12 Sep 2021 19:50:07 -0700 (PDT) Received: by mail-qv1-xf29.google.com with SMTP id a12so5202402qvz.4; Sun, 12 Sep 2021 19:50:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JnZ+T81xxeMxYG/DyrFUoeTLNxItYvJm+vAp2jTLAZQ=; b=jza6yE/fm8WFHUhKeWJzT2WE+AruH9/IyzcQ9SRwxSdsX7cHFd608qvGhlqG5MY2oc adANEjGGi652gTiZR4H3fElz1JvvB44B13jjMWp9vOu1qJ2TUWCwMHoxYtBDtEBL/4mE gr10Urm6rF6o8yAdfXE4wbiy4D6wM0Hu/7CVlVwKwc/FzagHO0uyi28plkNXpXd5DImb kC6cXJjxNiTz+86DXcfBBgYgAntyClv5/rjD2f8flIvG4fm7QUICOAILaqD1zqktDHf0 IXl3ExCe9DPvmahpIvM+u5SM/L/pCPoSsNYpbA1d3gq0j37IC+hnxUk527o+cDexZdHp ssgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JnZ+T81xxeMxYG/DyrFUoeTLNxItYvJm+vAp2jTLAZQ=; b=43SM4oZfe1iPqrw8Lqo8l86C1lzpPAGcuL2ytKnhtIvuaI7F7fSLeIqCN4dZJzfMhX d81RJcKw9bQq3khN0Q9YcHBqoygoGm9aFQHAULrcVKIMdC91Ox1lQYygzbu3d5JcgMdm jka57w7TqQRMfdH740e/hJjggfGtrZipP2loloUktPDyMsp+UEEC/IkmnhScpPxd9Jhl 845GV9H706yE1pbajL9ROlVR2/QblGyQgutRLvZcszTglHwHthRv2BrLpKWb25I8iFoc EHt6jccFaPWrUmQILcrgZuquLodg7TtVJqJ2tiNJ0Mg6Hh5luWTyoCyRCUWxUs5F1yKF uTSQ== X-Gm-Message-State: AOAM532OrcxDKOKI2pymvbIPpaXY3I8nxLrcTY+DE8+u0XluAWZqwVOw FrVcdq2oPg0aKklTzedGhuyjhkYbkqDEVqYuxlQ= X-Received: by 2002:ad4:470e:: with SMTP id k14mr8559532qvz.55.1631501406118; Sun, 12 Sep 2021 19:50:06 -0700 (PDT) MIME-Version: 1.0 References: <1631092255-25150-1-git-send-email-shengjiu.wang@nxp.com> <1631092255-25150-5-git-send-email-shengjiu.wang@nxp.com> In-Reply-To: From: Shengjiu Wang Date: Mon, 13 Sep 2021 10:49:55 +0800 Message-ID: Subject: Re: [PATCH v4 4/4] dt-bindings: dsp: fsl: update binding document for remote proc driver To: Rob Herring Cc: Shengjiu Wang , ohad@wizery.com, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, daniel.baluta@nxp.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob On Sat, Sep 11, 2021 at 5:43 AM Rob Herring wrote: > > On Wed, Sep 08, 2021 at 05:10:55PM +0800, Shengjiu Wang wrote: > > As there are two drivers for DSP on i.MX, one is for sound open > > firmware, another is for remote processor framework. In order to > > distinguish two kinds of driver, defining different compatible strings. > > What determines which firmware is used? Is it tied to the board? Or for > a given board, users could want different firmware? In the latter case, > this configuration should not be in DT. The compatible string determines which firmware is used. For a given board, users could want different firmware, then need to reboot the kernel and switch to another DTB. > > > For remote proc driver, the properties firmware-name and fsl,dsp-ctrl > > are needed and the mailbox channel is different with SOF. > > > > Signed-off-by: Shengjiu Wang > > --- > > .../devicetree/bindings/dsp/fsl,dsp.yaml | 81 +++++++++++++++++-- > > 1 file changed, 75 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > index 7afc9f2be13a..51ea657f6d42 100644 > > --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > @@ -8,6 +8,7 @@ title: NXP i.MX8 DSP core > > > > maintainers: > > - Daniel Baluta > > + - Shengjiu Wang > > > > description: | > > Some boards from i.MX8 family contain a DSP core used for > > @@ -19,6 +20,10 @@ properties: > > - fsl,imx8qxp-dsp > > - fsl,imx8qm-dsp > > - fsl,imx8mp-dsp > > + - fsl,imx8qxp-hifi4 > > + - fsl,imx8qm-hifi4 > > + - fsl,imx8mp-hifi4 > > + - fsl,imx8ulp-hifi4 > > > > reg: > > maxItems: 1 > > @@ -28,37 +33,63 @@ properties: > > - description: ipg clock > > - description: ocram clock > > - description: core clock > > + - description: debug interface clock > > + - description: message unit clock > > + minItems: 3 > > + maxItems: 5 > > > > clock-names: > > items: > > - const: ipg > > - const: ocram > > - const: core > > + - const: debug > > + - const: mu > > + minItems: 3 > > + maxItems: 5 > > > > power-domains: > > description: > > List of phandle and PM domain specifier as documented in > > Documentation/devicetree/bindings/power/power_domain.txt > > + minItems: 1 > > maxItems: 4 > > How does the same h/w have different number of power domains? For different SoC, the integration is different, on i.MX8QM/8QXP, there are 4 power-domains for DSP, but on i.MX8MP, there are 1 power-domain. > > > > > mboxes: > > description: > > List of <&phandle type channel> - 2 channels for TXDB, 2 channels for RXDB > > + or - 1 channel for TX, 1 channel for RX, 1 channel for RXDB > > (see mailbox/fsl,mu.txt) > > + minItems: 3 > > maxItems: 4 > > > > mbox-names: > > - items: > > - - const: txdb0 > > - - const: txdb1 > > - - const: rxdb0 > > - - const: rxdb1 > > + oneOf: > > + - items: > > + - const: txdb0 > > + - const: txdb1 > > + - const: rxdb0 > > + - const: rxdb1 > > + - items: > > + - const: tx > > + - const: rx > > + - const: rxdb > > These are completely different mailboxes? It is the same mailbox, for this mailbox, there are 16 channels (4 for tx, 4 for rx, 4 for txdb, 4 for rxdb). For sound open firmware and remoteproc firmware, they use different mailbox channels. > > > > > memory-region: > > description: > > phandle to a node describing reserved memory (System RAM memory) > > used by DSP (see bindings/reserved-memory/reserved-memory.txt) > > - maxItems: 1 > > + minItems: 1 > > + maxItems: 4 > > + > > + firmware-name: > > + description: | > > + Default name of the firmware to load to the remote processor. > > + > > + fsl,dsp-ctrl: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + Phandle to syscon block which provide access for processor enablement > > Curious, how is this done with the open sound f/w? Currently the code for this in sound open firmware is not upsteamed, I think this phandle is also applied for sound open firmware. By the way, Should I separate the change of this file from this patch series? Does it belong to your linux tree? Best Regards Wang Shengjiu