Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762690AbWLKJ3j (ORCPT ); Mon, 11 Dec 2006 04:29:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762689AbWLKJ3j (ORCPT ); Mon, 11 Dec 2006 04:29:39 -0500 Received: from smtp.osdl.org ([65.172.181.25]:34470 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762690AbWLKJ3h (ORCPT ); Mon, 11 Dec 2006 04:29:37 -0500 Date: Mon, 11 Dec 2006 01:25:45 -0800 From: Andrew Morton To: Al Viro Cc: Andrew MChuck Ebbert <76306.1226@compuserve.com>, linux-kernel , "Linus Torvalds orton " Subject: Re: [patch] pipe: Don't oops when pipe filesystem isn't mounted Message-Id: <20061211012545.ed945cbd.akpm@osdl.org> In-Reply-To: <20061211092130.GB4587@ftp.linux.org.uk> References: <200612110330_MC3-1-D49B-BC0F@compuserve.com> <20061211005557.04643a75.akpm@osdl.org> <20061211011327.f9478117.akpm@osdl.org> <20061211092130.GB4587@ftp.linux.org.uk> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1565 Lines: 35 On Mon, 11 Dec 2006 09:21:30 +0000 Al Viro wrote: > On Mon, Dec 11, 2006 at 01:13:27AM -0800, Andrew Morton wrote: > > On Mon, 11 Dec 2006 00:55:57 -0800 > > Andrew Morton wrote: > > > > > I think the bug really is the running of populate_rootfs() before running > > > the initcalls, in init/main.c:init(). It's just more sensible to start > > > running userspace after the initcalls have been run. Statically-linked > > > drivers which want to load firmware files will lose. To fix that we'd need > > > a new callback. It could be with a new linker section or perhaps simply a > > > notifier chain. > > > > hm, actually... Add two new initcall levels, one for populate_rootfs() and > > one for things which want to come after it (ie: drivers which want to > > access the filesytem): > > IMO we should just call pipe (and socket) initialization directly at > the same level as slab, task, dcache, etc. spose that would work. But what other initcall-initialised things are not yet available when populate_rootfs() runs? > This is basic stuff needed to get operational kernel. We could try > to put that on an additional initcall level, but then we ought to > take the rest of basic setup there as well. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/